Dirk Mueller
1d8d6856a8
* Avoid exception on inaccessible scripts * Print out the error content on UnicodeError to make flake8 happy * Fix flake8 warning about missing space around operators * Use compressions when checking for backup files * Account for arch specific code in /usr/share * Check for installed libtool wrapper files * Check for missing optional dependencies * Consider gnome help for doc files * Check for noarch package with files in lib64 * Verify if description is longer than summary * Explicitly tell users how to set URL * Ignore pytest_cache directory * confusing-invalid-spec-name * Ignore orig/rej leftovers after patching * Reenable Travis testing against Fedora Rawhide * Check all sections that should not use %buildroot in them * Put in default buildroot value used by Fedora/openSUSE * Stricter interpreter check * Use compileall to avoid %buildroot to be in pyc * Drop deprecated config file usage, 0.88 is pretty old anyway * Adjust Version to not print outdated Copyright * Rework Travis checks against latest Centos and Fedora releases * Fix exception handling * Fix various flake8-import-order test regressions * Blacklist newer pycodestyle warnings * Fix compatibility with file 5.33+ * Python 3.7.0b5 magic number is 3394 * Update TagsCheck.py * pyc related tests: DRY OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory:rpmlint/rpmlint?expand=0&rev=648
51 lines
2.2 KiB
Diff
51 lines
2.2 KiB
Diff
From: Some One <nobody@opensuse.org>
|
|
Date: Thu, 9 Apr 2015 14:55:37 +0200
|
|
Subject: [PATCH] suse-version.diff
|
|
|
|
===================================================================
|
|
---
|
|
SpecCheck.py | 16 ++++++++++++++++
|
|
1 file changed, 16 insertions(+)
|
|
|
|
Index: rpmlint-rpmlint-1.11/SpecCheck.py
|
|
===================================================================
|
|
--- rpmlint-rpmlint-1.11.orig/SpecCheck.py
|
|
+++ rpmlint-rpmlint-1.11/SpecCheck.py
|
|
@@ -49,6 +49,7 @@ packager_regex = re_tag_compile('Package
|
|
buildarch_regex = re_tag_compile('BuildArch(?:itectures)?')
|
|
buildprereq_regex = re_tag_compile('BuildPreReq')
|
|
prereq_regex = re_tag_compile(r'PreReq(\(.*\))')
|
|
+suse_version_regex = re.compile(r'%suse_version\s*[<>=]+\s*(\d+)')
|
|
|
|
make_check_regex = re.compile(r'(^|\s|%{?__)make}?\s+(check|test)')
|
|
rm_regex = re.compile(r'(^|\s)((.*/)?rm|%{?__rm}?) ')
|
|
@@ -389,6 +390,12 @@ class SpecCheck(AbstractCheck.AbstractCh
|
|
if not res.group(1).startswith('%'):
|
|
printWarning(pkg, 'hardcoded-prefix-tag', res.group(1))
|
|
|
|
+ res = suse_version_regex.search(line)
|
|
+ if res and int(res.group(1)) > 0 and int(res.group(1)) < 1315:
|
|
+ printWarning(pkg, "obsolete-suse-version-check", res.group(1))
|
|
+ elif res and int(res.group(1)) > 1550:
|
|
+ printError(pkg, "invalid-suse-version-check", res.group(1))
|
|
+
|
|
res = prereq_regex.search(line)
|
|
if res:
|
|
printError(pkg, 'prereq-use', res.group(2))
|
|
@@ -806,6 +813,15 @@ architecture independent or if some othe
|
|
in some editors but can lead to obscure errors. It should be replaced by a
|
|
regular space.''',
|
|
|
|
+'obsolete-suse-version-check',
|
|
+'''The specfile contains a comparison of %suse_version against a suse release
|
|
+that is no longer in maintenance. Consider removing obsolete parts of your
|
|
+spec file to make it more readable.''',
|
|
+
|
|
+'invalid-suse-version-check',
|
|
+'''The specfile contains a comparison of %suse_version against a suse release
|
|
+that does not exist. Please double check.''',
|
|
+
|
|
'non-standard-group',
|
|
'''The value of the Group tag in the package is not valid. Valid groups are:
|
|
"%s".''' % '", "'.join(VALID_GROUPS),
|