- Fix rpmlint warnings and errors:
+ rsyslog.spec:590: W: %autopatch-not-in-prep:
- applying patches should be done in prep section and in this
case, there is no reason not to do it. Use the opportunity to
switch to %autosetup.
- Do not BuildRequire libtool, autoconf, automake and don't run
autoreconf: the comment indicates this would be needed for
patch1, but likely for an 'older patch1': what we have now
does not touch the build system.
+ E: superfluous-%clean-section: Drop long deprecated %clean
section.
+ E: suse-zypp-otherproviders otherproviders(syslog): simply
provide syslog.
+ W: non-etc-or-var-file-marked-as-conffile: do not mark files in
/usr/share as config; admins are not supposed to change them.
+ rsyslog-doc.x86_64: E: no-binary: build rsyslog-doc as noarch.
+ E: explicit-lib-dependency librdkafka1: the dependency for one
should be in module-kafka, but then is also auto-detected by
RPM.
There 1 warning and 1 error left:
[ 63s] rsyslog.spec:44: E: obsolete-suse-version-check 1230
[ 63s] The specfile contains a comparison of %suse_version against a suse release
[ 63s] that is no longer in maintenance. Consider removing obsolete parts of your
[ 63s] spec file to make it more readable.
=> Not addressed, as I don't know if you care for such old code bases
[ 63s] rsyslog.x86_64: W: obsolete-not-provided rsyslog-module-guardtime
[ 63s] If a package is obsoleted by a compatible replacement, the obsoleted package
[ 63s] should also be provided in order to not cause unnecessary dependency breakage.
[ 63s] If the obsoleting package is not a compatible replacement for the old one,
[ 63s] leave out the Provides.
=> Providing it is likely wrong.
Those warnings/errors could be suppressed by a rsyslog-rpmlintrc file and thus
acknowledging their existence.
OBS-URL: https://build.opensuse.org/request/show/1157999
OBS-URL: https://build.opensuse.org/package/show/Base:System/rsyslog?expand=0&rev=367
99d7809e3c