From 2b26fbdfa02b98298e310bbe33702ccd0b50190a09bc686fee3c4bcde4a99cc0 Mon Sep 17 00:00:00 2001 From: Neal Gompa Date: Sun, 22 Nov 2020 17:59:38 +0000 Subject: [PATCH] Accepting request 849719 from home:manfred-h:devel:languages:rust:rust-1.47 This request actually fixes two issues: - rust-rpmlintrc: Reflect updated LLVM name in the filter. #1: LLVM got updated to version 11, but the rpmlint filter does not reflect it. Fixes: rust.x86_64: E: shlib-policy-name-error (Badness: 10000) libLLVM-11-rust-1_47_0-stable Your package contains a single shared library but is not named after its SONAME. - Make all shared libraries in %{common_libdir} executable; otherwise the %{fdupes} macro will not find any duplicates in %{rustlibdir}. #2: Files which only differ in their protection bits (i.e. execution bit in this case) will not be replaced by a hard link using the %{fdupes} call. This patch fixes: rust.x86_64: E: files-duplicated-waste (Badness: 100) 4349464 Your package contains duplicated files that are not hard- or symlinks. You should use the %fdupes macro to link the files to one. Files in question are from /usr/lib/ and /usr/lib/rustlib/x86_64-unknown-linux-gnu/lib/ OBS-URL: https://build.opensuse.org/request/show/849719 OBS-URL: https://build.opensuse.org/package/show/devel:languages:rust/rust?expand=0&rev=269 --- rust-rpmlintrc | 2 +- rust.changes | 11 +++++++++++ rust.spec | 3 +++ 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/rust-rpmlintrc b/rust-rpmlintrc index 063c1d4..43fe48f 100644 --- a/rust-rpmlintrc +++ b/rust-rpmlintrc @@ -20,4 +20,4 @@ addFilter("clippy.x86_64: W: useless-provides clippy") addFilter("rustfmt.x86_64: W: useless-provides rustfmt") # error when building with bootstrap. ignore for now -addFilter(".*shlib-policy-name-error.*libLLVM-8.*") +addFilter(".*shlib-policy-name-error.*libLLVM-11.*") diff --git a/rust.changes b/rust.changes index ad785fc..f97ae76 100644 --- a/rust.changes +++ b/rust.changes @@ -1,3 +1,14 @@ +------------------------------------------------------------------- +Fri Nov 20 13:40:04 UTC 2020 - Manfred Hollstein + +- Make all shared libraries in %{common_libdir} executable; otherwise + fdupes will not find any duplicates in %{rustlibdir}. + +------------------------------------------------------------------- +Thu Nov 5 09:27:56 UTC 2020 - Manfred Hollstein + +- rust-rpmlintrc: Reflect updated LLVM name in the filter. + ------------------------------------------------------------------- Sun Oct 11 22:43:36 UTC 2020 - William Brown diff --git a/rust.spec b/rust.spec index fc8cac1..496bb3c 100644 --- a/rust.spec +++ b/rust.spec @@ -518,6 +518,9 @@ rm %{buildroot}%{_docdir}/%{name}/*.old # Remove installer artifacts (manifests, uninstall scripts, etc.) find %{buildroot}%{rustlibdir} -maxdepth 1 -type f -exec rm -v '{}' '+' +# The shared libraries should be executable to allow fdupes find duplicates. +find %{buildroot}%{common_libdir} -maxdepth 1 -type f -name '*.so' -exec chmod -v +x '{}' '+' + # The shared libraries should be executable for debuginfo extraction. find %{buildroot}%{rustlibdir} -maxdepth 1 -type f -name '*.so' -exec chmod -v +x '{}' '+'