99fdefd1f8
Add shim-fix-uninitialized-variable.patch to fix the use of uninitialzed variables in lib OBS-URL: https://build.opensuse.org/request/show/225406 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory/shim?expand=0&rev=67
61 lines
1.6 KiB
Diff
61 lines
1.6 KiB
Diff
From ccf21ef9a8868aacf9084400a15d73fcc24a6d39 Mon Sep 17 00:00:00 2001
|
|
From: Peter Jones <pjones@redhat.com>
|
|
Date: Fri, 15 Nov 2013 09:21:53 -0500
|
|
Subject: [PATCH 1/2] Fix wrong sizeof().
|
|
|
|
CHAR16* vs CHAR16**, so the result is the same on all platforms.
|
|
|
|
Detected by coverity.
|
|
|
|
Signed-off-by: Peter Jones <pjones@redhat.com>
|
|
---
|
|
lib/shell.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/lib/shell.c b/lib/shell.c
|
|
index 51de4e0..7337834 100644
|
|
--- a/lib/shell.c
|
|
+++ b/lib/shell.c
|
|
@@ -35,7 +35,7 @@ argsplit(EFI_HANDLE image, int *argc, CHAR16*** ARGV)
|
|
|
|
(*argc)++; /* we counted spaces, so add one for initial */
|
|
|
|
- *ARGV = AllocatePool(*argc * sizeof(*ARGV));
|
|
+ *ARGV = AllocatePool(*argc * sizeof(**ARGV));
|
|
if (!*ARGV) {
|
|
return EFI_OUT_OF_RESOURCES;
|
|
}
|
|
--
|
|
1.8.4.5
|
|
|
|
|
|
From c4277cf343555646dbf0c17679108983af1e8887 Mon Sep 17 00:00:00 2001
|
|
From: Peter Jones <pjones@redhat.com>
|
|
Date: Fri, 15 Nov 2013 09:24:01 -0500
|
|
Subject: [PATCH 2/2] Initialize entries before we pass it to another function.
|
|
|
|
Coverity scan noticed that entries is uninitialized when we pass its
|
|
location to another function.
|
|
|
|
Signed-off-by: Peter Jones <pjones@redhat.com>
|
|
---
|
|
lib/simple_file.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/lib/simple_file.c b/lib/simple_file.c
|
|
index 3af0ec8..d345d87 100644
|
|
--- a/lib/simple_file.c
|
|
+++ b/lib/simple_file.c
|
|
@@ -415,7 +415,7 @@ simple_file_selector(EFI_HANDLE *im, CHAR16 **title, CHAR16 *name,
|
|
CHAR16 *filter, CHAR16 **result)
|
|
{
|
|
EFI_STATUS status;
|
|
- CHAR16 **entries;
|
|
+ CHAR16 **entries = NULL;
|
|
EFI_FILE_INFO *dmp;
|
|
int count, select, len;
|
|
CHAR16 *newname, *selected;
|
|
--
|
|
1.8.4.5
|
|
|