4f72d9c0de
bnc#804631: fix the broken bootpath generated in generate_path() OBS-URL: https://build.opensuse.org/request/show/156025 OBS-URL: https://build.opensuse.org/package/show/devel:openSUSE:Factory/shim?expand=0&rev=10
65 lines
1.6 KiB
Diff
65 lines
1.6 KiB
Diff
From 6b70850baa958b196ec332cf0224ffa9d5a81f5f Mon Sep 17 00:00:00 2001
|
|
From: Gary Ching-Pang Lin <glin@suse.com>
|
|
Date: Thu, 21 Feb 2013 17:49:29 +0800
|
|
Subject: [PATCH] Fix the broken bootpath
|
|
|
|
- The file path from DevicePathToStr may use slash as the file
|
|
seperator. Change all slashes to backslashes to avoid the strange
|
|
bootpath.
|
|
- Remove the redundant backslashes.
|
|
- ImagePath no longer requires the leading backslash.
|
|
- Fix a memory leak
|
|
|
|
Based on the patch from Michal Marek <mmarek@suse.com>
|
|
---
|
|
shim.c | 22 +++++++++++++++++-----
|
|
1 file changed, 17 insertions(+), 5 deletions(-)
|
|
|
|
diff --git a/shim.c b/shim.c
|
|
index 37a5898..690d064 100644
|
|
--- a/shim.c
|
|
+++ b/shim.c
|
|
@@ -919,15 +919,25 @@ static EFI_STATUS generate_path(EFI_LOADED_IMAGE *li, CHAR16 *ImagePath,
|
|
|
|
pathlen = StrLen(bootpath);
|
|
|
|
+ /*
|
|
+ * DevicePathToStr() concatenates two nodes with '/'.
|
|
+ * Convert '/' to '\\'.
|
|
+ */
|
|
+ for (i = 0; i < pathlen; i++) {
|
|
+ if (bootpath[i] == '/')
|
|
+ bootpath[i] = '\\';
|
|
+ }
|
|
for (i=pathlen; i>0; i--) {
|
|
- if (bootpath[i] == '\\')
|
|
+ if (bootpath[i] == '\\' && bootpath[i-1] != '\\')
|
|
break;
|
|
}
|
|
+ if (bootpath[i] == '\\')
|
|
+ bootpath[i+1] = '\0';
|
|
+ else
|
|
+ bootpath[0] = '\0';
|
|
|
|
- bootpath[i+1] = '\0';
|
|
-
|
|
- if (i == 0 || bootpath[i-i] == '\\')
|
|
- bootpath[i] = '\0';
|
|
+ while (*ImagePath == '\\')
|
|
+ ImagePath++;
|
|
|
|
*PathName = AllocatePool(StrSize(bootpath) + StrSize(ImagePath));
|
|
|
|
@@ -944,6 +954,8 @@ static EFI_STATUS generate_path(EFI_LOADED_IMAGE *li, CHAR16 *ImagePath,
|
|
*grubpath = FileDevicePath(device, *PathName);
|
|
|
|
error:
|
|
+ FreePool(bootpath);
|
|
+
|
|
return efi_status;
|
|
}
|
|
|
|
--
|
|
1.7.10.4
|
|
|