From 7fc27c7a3ccbb6aecb8cf4a4a5f91962028cb897 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Mon, 17 Mar 2014 09:07:56 +0100 Subject: [PATCH] BUILD: Link libsss_ldap_common.so to libsss_idmap.so Library libsss_ldap.so does not directly use functions from library libsss_idmap.so. It only call function sdap_idmap_init (from file sdap_idmap.c) which is in library libsss_ldap_common.so sh-4.2$ nm -D --undefined-only /usr/lib64/sssd/libsss_ldap.so | grep idmap U sdap_idmap_init On the other hand, libsss_ldap_common.so uses functions from libsss_idmap but it was not linked to libsss_idmap.so. sh-4.2$ objdump -p /usr/lib64/sssd/libsss_ldap_common.so | grep idmap sh-4.2$ echo $? 1 Reviewed-by: Jakub Hrozek Reviewed-by: Simo Sorce --- Makefile.am | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Index: sssd-1.11.5.1/Makefile.am =================================================================== --- sssd-1.11.5.1.orig/Makefile.am +++ sssd-1.11.5.1/Makefile.am @@ -1618,6 +1618,8 @@ libsss_ldap_common_la_SOURCES = \ src/providers/ldap/sdap_dyndns.c \ src/providers/ldap/sdap_refresh.c \ src/providers/ldap/sdap.c +libsss_ldap_common_la_LIBADD = \ + libsss_idmap.la libsss_ldap_common_la_LDFLAGS = \ -avoid-version @@ -1675,8 +1677,7 @@ libsss_ldap_la_LIBADD = \ $(OPENLDAP_LIBS) \ $(DHASH_LIBS) \ $(KRB5_LIBS) \ - libsss_ldap_common.la \ - libsss_idmap.la + libsss_ldap_common.la libsss_ldap_la_LDFLAGS = \ -avoid-version \ -module