36 lines
1.4 KiB
Diff
36 lines
1.4 KiB
Diff
|
Date: Wed, 12 Dec 2012 20:01:11 +0000
|
||
|
|
From: Andreas Stieger <andreas.stieger@gmx.de>
|
||
|
|
Subject: [PATCH] Prevent false negative results of "make check" in Python
|
||
|
|
References: http://svn.apache.org/viewvc/subversion/trunk/build/run_tests.py?r1=1420904&r2=1420944&pathrev=1420944
|
||
|
|
Upstream: merged
|
||
|
|
|
||
|
|
Patch changes the test harness to prevent some false negatives when
|
||
|
|
running the test suite. Specifically, if a python test initialisation
|
||
|
|
returns in such a way that the test runner doesn't know how to handle
|
||
|
|
the result, change to code to return a non-zero exit code like and,
|
||
|
|
subsequently, have "make check" fail correctly. Reproducible by using
|
||
|
|
Python < 2.5 or missing sqlite3 Python bindings, exit triggered by
|
||
|
|
subversion/tests/cmdline/svntest/__init__.py
|
||
|
|
|
||
|
|
In the openSUSE obs, affects SLE 11 only, when building with unit tests.
|
||
|
|
|
||
|
|
svn diff -c1420944 https://svn.apache.org/repos/asf/subversion/trunk
|
||
|
|
|
||
|
|
---
|
||
|
|
build/run_tests.py | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
Index: subversion-1.7.8/build/run_tests.py
|
||
|
|
===================================================================
|
||
|
|
--- subversion-1.7.8.orig/build/run_tests.py 2012-09-29 05:02:11.000000000 +0100
|
||
|
|
+++ subversion-1.7.8/build/run_tests.py 2012-12-12 20:48:29.000000000 +0000
|
||
|
|
@@ -378,7 +378,7 @@ class TestHarness:
|
||
|
|
('.py', 'U', imp.PY_SOURCE))
|
||
|
|
except:
|
||
|
|
print('Don\'t know what to do about ' + progbase)
|
||
|
|
- raise
|
||
|
|
+ sys.exit(1)
|
||
|
|
|
||
|
|
import svntest.main
|
||
|
|
|