From 4d4e08c3a10acf23e821b3555951954b7ec03404b99e1648fe62ba5eebfc6799 Mon Sep 17 00:00:00 2001 From: "Dr. Werner Fink" Date: Tue, 21 Apr 2015 09:12:13 +0000 Subject: [PATCH 1/3] . OBS-URL: https://build.opensuse.org/package/show/Base:System/systemd?expand=0&rev=866 --- systemd-mini.changes | 7 ++ systemd-mini.spec | 2 +- systemd.changes | 7 ++ systemd.spec | 2 +- ...addentropy-ioctl-to-load-random-seed.patch | 96 +++++++++++++------ 5 files changed, 82 insertions(+), 32 deletions(-) diff --git a/systemd-mini.changes b/systemd-mini.changes index 0ffd755b..3c1a26a7 100644 --- a/systemd-mini.changes +++ b/systemd-mini.changes @@ -1,3 +1,10 @@ +------------------------------------------------------------------- +Mon Mar 16 15:35:31 UTC 2015 - werner@suse.de + +- Add upstream patch + 0001-core-don-t-change-removed-devices-to-state-tentative.patch + to fix the fix of the last backport (bsc#921898) + ------------------------------------------------------------------- Thu Mar 5 11:36:11 UTC 2015 - jengelh@inai.de diff --git a/systemd-mini.spec b/systemd-mini.spec index 07b29708..95168d8f 100644 --- a/systemd-mini.spec +++ b/systemd-mini.spec @@ -1,7 +1,7 @@ # # spec file for package systemd-mini # -# Copyright (c) 2015 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2015 SUSE LINUX Products GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed diff --git a/systemd.changes b/systemd.changes index 0ffd755b..3c1a26a7 100644 --- a/systemd.changes +++ b/systemd.changes @@ -1,3 +1,10 @@ +------------------------------------------------------------------- +Mon Mar 16 15:35:31 UTC 2015 - werner@suse.de + +- Add upstream patch + 0001-core-don-t-change-removed-devices-to-state-tentative.patch + to fix the fix of the last backport (bsc#921898) + ------------------------------------------------------------------- Thu Mar 5 11:36:11 UTC 2015 - jengelh@inai.de diff --git a/systemd.spec b/systemd.spec index d0ca0a64..76876ece 100644 --- a/systemd.spec +++ b/systemd.spec @@ -1,7 +1,7 @@ # # spec file for package systemd # -# Copyright (c) 2015 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2015 SUSE LINUX Products GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed diff --git a/use-rndaddentropy-ioctl-to-load-random-seed.patch b/use-rndaddentropy-ioctl-to-load-random-seed.patch index 20cfbcbe..e6e8a1ce 100644 --- a/use-rndaddentropy-ioctl-to-load-random-seed.patch +++ b/use-rndaddentropy-ioctl-to-load-random-seed.patch @@ -5,13 +5,11 @@ write back the bytes and increase the entropy bit counter. Related to bnc#892096 --- - src/random-seed/random-seed.c | 65 +++++++++++++++++++++++++++++++++++++++--- - 1 file changed, 61 insertions(+), 4 deletions(-) + systemd-210/src/random-seed/random-seed.c | 73 +++++++++++++++++++++++++----- + 1 file changed, 62 insertions(+), 11 deletions(-) -Index: systemd-218/src/random-seed/random-seed.c -=================================================================== ---- systemd-218.orig/src/random-seed/random-seed.c -+++ systemd-218/src/random-seed/random-seed.c +--- systemd-210/src/random-seed/random-seed.c ++++ systemd-210/src/random-seed/random-seed.c 2015-04-14 11:38:08.617519434 +0000 @@ -22,7 +22,9 @@ #include #include @@ -22,31 +20,46 @@ Index: systemd-218/src/random-seed/random-seed.c #include #include "log.h" -@@ -32,8 +34,9 @@ +@@ -32,8 +34,8 @@ #define POOL_SIZE_MIN 512 int main(int argc, char *argv[]) { - _cleanup_close_ int seed_fd = -1, random_fd = -1; +- _cleanup_free_ void* buf = NULL; + _cleanup_close_ int seed_fd = -1, random_fd = -1, entropy_fd = -1; - _cleanup_free_ void* buf = NULL; -+ size_t entropy_count = 0; ++ _cleanup_free_ struct rand_pool_info *entropy = NULL; size_t buf_size = 0; ssize_t k; int r; +@@ -64,11 +66,12 @@ int main(int argc, char *argv[]) { + if (buf_size <= POOL_SIZE_MIN) + buf_size = POOL_SIZE_MIN; + +- buf = malloc(buf_size); +- if (!buf) { ++ entropy = (struct rand_pool_info*) malloc(sizeof(struct rand_pool_info) + buf_size); ++ if (!entropy) { + r = log_oom(); + goto finish; + } ++ entropy->buf_size = buf_size; + + r = mkdir_parents_label(RANDOM_SEED, 0755); + if (r < 0) { @@ -82,6 +85,23 @@ int main(int argc, char *argv[]) { if (streq(argv[1], "load")) { + entropy_fd = open(RANDOM_SEED_DIR "entropy_count", O_RDONLY|O_CLOEXEC|O_NOCTTY, 0600); + if (entropy_fd < 0) { -+ entropy_count = 0; ++ entropy->entropy_count = 0; + if (errno != ENOENT) { + log_error("Failed to open " RANDOM_SEED "/entropy_count: %m"); + r = -errno; + goto finish; + } + } else { -+ r = read(entropy_fd, &entropy_count, sizeof(entropy_count)); ++ r = read(entropy_fd, &entropy->entropy_count, sizeof(entropy->entropy_count)); + if (r < 0) { + log_error("Failed to read entropy count file: %m"); + r = -errno; @@ -57,56 +70,64 @@ Index: systemd-218/src/random-seed/random-seed.c seed_fd = open(RANDOM_SEED, O_RDWR|O_CLOEXEC|O_NOCTTY|O_CREAT, 0600); if (seed_fd < 0) { seed_fd = open(RANDOM_SEED, O_RDONLY|O_CLOEXEC|O_NOCTTY); -@@ -113,12 +133,34 @@ int main(int argc, char *argv[]) { +@@ -102,7 +122,7 @@ int main(int argc, char *argv[]) { + } + } + +- k = loop_read(seed_fd, buf, buf_size, false); ++ k = loop_read(seed_fd, entropy->buf, entropy->buf_size, false); + if (k <= 0) { + + if (r != 0) +@@ -113,16 +133,32 @@ int main(int argc, char *argv[]) { } else { lseek(seed_fd, 0, SEEK_SET); -- r = loop_write(random_fd, buf, (size_t) k, false); -- if (r < 0) -- log_error_errno(r, "Failed to write seed to /dev/urandom: %m"); -+ if (entropy_count && (size_t) k == buf_size) { -+ struct rand_pool_info entropy = { -+ .entropy_count = entropy_count, -+ .buf_size = buf_size, -+ }; -+ entropy.buf[0] = ((__u32*)buf)[0]; -+ r = ioctl(random_fd, RNDADDENTROPY, &entropy); +- k = loop_write(random_fd, buf, (size_t) k, false); +- if (k <= 0) { +- log_error("Failed to write seed to /dev/urandom: %s", r < 0 ? strerror(-r) : "short write"); ++ if (entropy->entropy_count && (size_t) k == entropy->buf_size) { ++ r = ioctl(random_fd, RNDADDENTROPY, entropy); + if (r < 0) { + log_error("Failed to write seed to /dev/urandom: %m"); + r = -errno; + } + } else { -+ k = loop_write(random_fd, buf, (size_t) k, false); ++ k = loop_write(random_fd, entropy->buf, (size_t) k, false); + if (k <= 0) { + log_error("Failed to write seed to /dev/urandom: %s", r < 0 ? strerror(-r) : "short write"); + +- r = k == 0 ? -EIO : (int) k; + r = k == 0 ? -EIO : (int) k; + } -+ } + } } } else if (streq(argv[1], "save")) { + + /* Read available entropy count, if possible */ + f = fopen("/proc/sys/kernel/random/entropy_avail", "re"); + if (f) { -+ if (fscanf(f, "%zu", &entropy_count) < 0) -+ entropy_count = 0; ++ if (fscanf(f, "%zu", &entropy->entropy_count) < 0) ++ entropy->entropy_count = 0; + fclose(f); + } - ++ seed_fd = open(RANDOM_SEED, O_WRONLY|O_CLOEXEC|O_NOCTTY|O_CREAT, 0600); if (seed_fd < 0) { -@@ -134,6 +176,21 @@ int main(int argc, char *argv[]) { + log_error("Failed to open " RANDOM_SEED ": %m"); +@@ -137,6 +173,21 @@ int main(int argc, char *argv[]) { goto finish; } -+ if (entropy_count) { ++ if (entropy->entropy_count) { + entropy_fd = open(RANDOM_SEED_DIR "entropy_count", O_WRONLY|O_CLOEXEC|O_NOCTTY|O_CREAT, 0600); + if (seed_fd < 0) { + log_error("Failed to open " RANDOM_SEED_DIR "entropy_count: %m"); + r = -errno; + goto finish; + } -+ r = write(entropy_fd, &entropy_count, sizeof(entropy_count)); ++ r = write(entropy_fd, &entropy->entropy_count, sizeof(entropy->entropy_count)); + if (r < 0) { + log_error("Failed to write entropy count file: %m"); + r = -errno; @@ -117,3 +138,18 @@ Index: systemd-218/src/random-seed/random-seed.c } else { log_error("Unknown verb %s.", argv[1]); r = -EINVAL; +@@ -149,12 +200,12 @@ int main(int argc, char *argv[]) { + fchmod(seed_fd, 0600); + fchown(seed_fd, 0, 0); + +- k = loop_read(random_fd, buf, buf_size, false); ++ k = loop_read(random_fd, entropy->buf, entropy->buf_size, false); + if (k <= 0) { + log_error("Failed to read new seed from /dev/urandom: %s", r < 0 ? strerror(-r) : "EOF"); + r = k == 0 ? -EIO : (int) k; + } else { +- r = loop_write(seed_fd, buf, (size_t) k, false); ++ r = loop_write(seed_fd, entropy->buf, (size_t) k, false); + if (r <= 0) { + log_error("Failed to write new random seed file: %s", r < 0 ? strerror(-r) : "short write"); + r = r == 0 ? -EIO : r; From dc87c28a2404ec29dec047c5b1d5af70fe0a0b9df2a6af25ef077249805458e1 Mon Sep 17 00:00:00 2001 From: "Dr. Werner Fink" Date: Tue, 21 Apr 2015 09:29:12 +0000 Subject: [PATCH 2/3] . OBS-URL: https://build.opensuse.org/package/show/Base:System/systemd?expand=0&rev=867 --- ...addentropy-ioctl-to-load-random-seed.patch | 66 +++++++++---------- 1 file changed, 31 insertions(+), 35 deletions(-) diff --git a/use-rndaddentropy-ioctl-to-load-random-seed.patch b/use-rndaddentropy-ioctl-to-load-random-seed.patch index e6e8a1ce..1b6412ce 100644 --- a/use-rndaddentropy-ioctl-to-load-random-seed.patch +++ b/use-rndaddentropy-ioctl-to-load-random-seed.patch @@ -5,11 +5,11 @@ write back the bytes and increase the entropy bit counter. Related to bnc#892096 --- - systemd-210/src/random-seed/random-seed.c | 73 +++++++++++++++++++++++++----- - 1 file changed, 62 insertions(+), 11 deletions(-) + systemd-219/src/random-seed/random-seed.c | 71 +++++++++++++++++++++++++----- + 1 file changed, 61 insertions(+), 10 deletions(-) ---- systemd-210/src/random-seed/random-seed.c -+++ systemd-210/src/random-seed/random-seed.c 2015-04-14 11:38:08.617519434 +0000 +--- systemd-219/src/random-seed/random-seed.c ++++ systemd-219/src/random-seed/random-seed.c 2015-04-21 09:26:07.589518787 +0000 @@ -22,7 +22,9 @@ #include #include @@ -31,7 +31,7 @@ Related to bnc#892096 size_t buf_size = 0; ssize_t k; int r; -@@ -64,11 +66,12 @@ int main(int argc, char *argv[]) { +@@ -65,11 +67,12 @@ int main(int argc, char *argv[]) { if (buf_size <= POOL_SIZE_MIN) buf_size = POOL_SIZE_MIN; @@ -46,7 +46,7 @@ Related to bnc#892096 r = mkdir_parents_label(RANDOM_SEED, 0755); if (r < 0) { -@@ -82,6 +85,23 @@ int main(int argc, char *argv[]) { +@@ -83,6 +86,23 @@ int main(int argc, char *argv[]) { if (streq(argv[1], "load")) { @@ -70,7 +70,7 @@ Related to bnc#892096 seed_fd = open(RANDOM_SEED, O_RDWR|O_CLOEXEC|O_NOCTTY|O_CREAT, 0600); if (seed_fd < 0) { seed_fd = open(RANDOM_SEED, O_RDONLY|O_CLOEXEC|O_NOCTTY); -@@ -102,7 +122,7 @@ int main(int argc, char *argv[]) { +@@ -104,7 +124,7 @@ int main(int argc, char *argv[]) { } } @@ -79,28 +79,24 @@ Related to bnc#892096 if (k <= 0) { if (r != 0) -@@ -113,16 +133,32 @@ int main(int argc, char *argv[]) { +@@ -115,13 +135,29 @@ int main(int argc, char *argv[]) { } else { lseek(seed_fd, 0, SEEK_SET); -- k = loop_write(random_fd, buf, (size_t) k, false); -- if (k <= 0) { -- log_error("Failed to write seed to /dev/urandom: %s", r < 0 ? strerror(-r) : "short write"); +- r = loop_write(random_fd, buf, (size_t) k, false); +- if (r < 0) +- log_error_errno(r, "Failed to write seed to /dev/urandom: %m"); + if (entropy->entropy_count && (size_t) k == entropy->buf_size) { + r = ioctl(random_fd, RNDADDENTROPY, entropy); + if (r < 0) { -+ log_error("Failed to write seed to /dev/urandom: %m"); ++ log_error_errno(errno, "Failed to write seed to /dev/urandom: %m"); + r = -errno; + } + } else { -+ k = loop_write(random_fd, entropy->buf, (size_t) k, false); -+ if (k <= 0) { -+ log_error("Failed to write seed to /dev/urandom: %s", r < 0 ? strerror(-r) : "short write"); - -- r = k == 0 ? -EIO : (int) k; -+ r = k == 0 ? -EIO : (int) k; -+ } - } ++ r = loop_write(random_fd, buf, (size_t) k, false); ++ if (r < 0) ++ log_error_errno(r, "Failed to write seed to /dev/urandom: %m"); ++ } } } else if (streq(argv[1], "save")) { @@ -115,8 +111,8 @@ Related to bnc#892096 + seed_fd = open(RANDOM_SEED, O_WRONLY|O_CLOEXEC|O_NOCTTY|O_CREAT, 0600); if (seed_fd < 0) { - log_error("Failed to open " RANDOM_SEED ": %m"); -@@ -137,6 +173,21 @@ int main(int argc, char *argv[]) { + log_error_errno(errno, "Failed to open " RANDOM_SEED ": %m"); +@@ -136,6 +172,21 @@ int main(int argc, char *argv[]) { goto finish; } @@ -139,17 +135,17 @@ Related to bnc#892096 log_error("Unknown verb %s.", argv[1]); r = -EINVAL; @@ -149,12 +200,12 @@ int main(int argc, char *argv[]) { - fchmod(seed_fd, 0600); - fchown(seed_fd, 0, 0); + fchmod(seed_fd, 0600); + fchown(seed_fd, 0, 0); -- k = loop_read(random_fd, buf, buf_size, false); -+ k = loop_read(random_fd, entropy->buf, entropy->buf_size, false); - if (k <= 0) { - log_error("Failed to read new seed from /dev/urandom: %s", r < 0 ? strerror(-r) : "EOF"); - r = k == 0 ? -EIO : (int) k; - } else { -- r = loop_write(seed_fd, buf, (size_t) k, false); -+ r = loop_write(seed_fd, entropy->buf, (size_t) k, false); - if (r <= 0) { - log_error("Failed to write new random seed file: %s", r < 0 ? strerror(-r) : "short write"); - r = r == 0 ? -EIO : r; +- k = loop_read(random_fd, buf, buf_size, false); ++ k = loop_read(random_fd, entropy->buf, entropy->buf_size, false); + if (k <= 0) { + log_error("Failed to read new seed from /dev/urandom: %s", r < 0 ? strerror(-r) : "EOF"); + r = k == 0 ? -EIO : (int) k; + } else { +- r = loop_write(seed_fd, buf, (size_t) k, false); ++ r = loop_write(seed_fd, entropy->buf, (size_t) k, false); + if (r < 0) + log_error_errno(r, "Failed to write new random seed file: %m"); + } From ba67084b43dfdc81ee3af1125eefe1ac5b7aa9897048374ffc92097745aa139c Mon Sep 17 00:00:00 2001 From: "Dr. Werner Fink" Date: Tue, 21 Apr 2015 09:45:51 +0000 Subject: [PATCH 3/3] . OBS-URL: https://build.opensuse.org/package/show/Base:System/systemd?expand=0&rev=868 --- use-rndaddentropy-ioctl-to-load-random-seed.patch | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/use-rndaddentropy-ioctl-to-load-random-seed.patch b/use-rndaddentropy-ioctl-to-load-random-seed.patch index 1b6412ce..a91b3701 100644 --- a/use-rndaddentropy-ioctl-to-load-random-seed.patch +++ b/use-rndaddentropy-ioctl-to-load-random-seed.patch @@ -9,7 +9,7 @@ Related to bnc#892096 1 file changed, 61 insertions(+), 10 deletions(-) --- systemd-219/src/random-seed/random-seed.c -+++ systemd-219/src/random-seed/random-seed.c 2015-04-21 09:26:07.589518787 +0000 ++++ systemd-219/src/random-seed/random-seed.c 2015-04-21 09:39:03.057518051 +0000 @@ -22,7 +22,9 @@ #include #include @@ -86,14 +86,14 @@ Related to bnc#892096 - r = loop_write(random_fd, buf, (size_t) k, false); - if (r < 0) - log_error_errno(r, "Failed to write seed to /dev/urandom: %m"); -+ if (entropy->entropy_count && (size_t) k == entropy->buf_size) { ++ if (entropy->entropy_count && ((size_t)k) == entropy->buf_size) { + r = ioctl(random_fd, RNDADDENTROPY, entropy); + if (r < 0) { + log_error_errno(errno, "Failed to write seed to /dev/urandom: %m"); + r = -errno; + } + } else { -+ r = loop_write(random_fd, buf, (size_t) k, false); ++ r = loop_write(random_fd, entropy->buf, (size_t) k, false); + if (r < 0) + log_error_errno(r, "Failed to write seed to /dev/urandom: %m"); + } @@ -104,7 +104,7 @@ Related to bnc#892096 + /* Read available entropy count, if possible */ + f = fopen("/proc/sys/kernel/random/entropy_avail", "re"); + if (f) { -+ if (fscanf(f, "%zu", &entropy->entropy_count) < 0) ++ if (fscanf(f, "%d", &entropy->entropy_count) < 0) + entropy->entropy_count = 0; + fclose(f); + }