e7c96ab7f3
- Add patch 0001-bnc888612-logind-polkit-acpi.patch from Frederic to solve bnc#888612 - AUDIT-0: Power button press at gdm login should not prompt for credentials - Add upstream bugfix patches 0001-journal-Do-not-count-on-the-compiler-initializing-fo.patch 0002-include-fcntl.h-rather-than-sys-fcntl.h.patch 0003-mount-order-options-before-other-arguments-to-mount.patch 0004-shared-wtmp-utmp-don-t-clear-store_wtmp-in-utmp_put_.patch 0005-shared-label.h-add-missing-stdio.h-include.patch 0006-shared-sparse-endian.h-add-missing-byteswap.h-includ.patch 0007-libudev-monitor-warn-if-we-fail-to-request-SO_PASSCR.patch 0008-shared-conf-parser-don-t-leak-memory-on-error-in-DEF.patch 1080-udevd-parse_argv-warn-if-argumens-are-invalid.patch 1081-udevd-check-return-of-various-functions.patch 1082-udevadm-hwdb-check-return-value-of-fseeko.patch 1083-udev-node-warn-if-chmod-chown-fails.patch 1084-udev-ctrl-log-if-setting-SO_PASSCRED-fails.patch 1085-udev-fix-typos.patch 1086-udevd-don-t-fail-if-run-udev-exists.patch - Add upstream bugfix patches 0001-core-fix-resource-leak-in-manager_environment_add.patch 0002-util-remove-a-unnecessary-check.patch 0003-udev-event-explicitly-don-t-read-from-invalid-fd.patch 0004-shared-conf-parser.patch 0005-logind-fix-typo.patch 0006-systemctl-fix-resource-leak-CID-1237747.patch 0007-libudev-monitor-warn-if-we-fail-to-request-SO_PASSCR.patch 0008-shared-conf-parser-don-t-leak-memory-on-error-in-DEF.patc OBS-URL: https://build.opensuse.org/request/show/250254 OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/systemd?expand=0&rev=207
56 lines
1.7 KiB
Diff
56 lines
1.7 KiB
Diff
Based on d457ff8319b1e7c522c146f75e272f1226f4720c Mon Sep 17 00:00:00 2001
|
|
From: Tom Gundersen <teg@jklm.no>
|
|
Date: Thu, 18 Sep 2014 19:07:02 +0200
|
|
Subject: [PATCH] udevd: check return of various functions
|
|
|
|
One reported by Coverity. Fixes CID #996252.
|
|
---
|
|
src/udev/udevd.c | 20 ++++++++++++++++----
|
|
1 file changed, 16 insertions(+), 4 deletions(-)
|
|
|
|
--- src/udev/udevd.c
|
|
+++ src/udev/udevd.c 2014-09-19 11:33:21.566236309 +0000
|
|
@@ -1044,7 +1044,7 @@ int main(int argc, char *argv[]) {
|
|
int fd_worker = -1;
|
|
struct epoll_event ep_ctrl, ep_inotify, ep_signal, ep_netlink, ep_worker;
|
|
struct udev_ctrl_connection *ctrl_conn = NULL;
|
|
- int rc = 1;
|
|
+ int rc = 1, r;
|
|
|
|
udev = udev_new();
|
|
if (udev == NULL)
|
|
@@ -1058,7 +1058,11 @@ int main(int argc, char *argv[]) {
|
|
log_set_max_level(udev_get_log_priority(udev));
|
|
|
|
log_debug("version %s", VERSION);
|
|
- label_init("/dev");
|
|
+ r = label_init("/dev");
|
|
+ if (r < 0) {
|
|
+ log_error("could not initialize labelling: %s", strerror(-r));
|
|
+ goto exit;
|
|
+ }
|
|
|
|
for (;;) {
|
|
int option, r;
|
|
@@ -1137,10 +1141,18 @@ int main(int argc, char *argv[]) {
|
|
}
|
|
|
|
/* set umask before creating any file/directory */
|
|
- chdir("/");
|
|
+ r = chdir("/");
|
|
+ if (r < 0) {
|
|
+ log_error("could not change dir to /: %m");
|
|
+ goto exit;
|
|
+ }
|
|
umask(022);
|
|
|
|
- mkdir("/run/udev", 0755);
|
|
+ r = mkdir("/run/udev", 0755);
|
|
+ if (r < 0) {
|
|
+ log_error("could not create /run/udev: %m");
|
|
+ goto exit;
|
|
+ }
|
|
|
|
dev_setup(NULL);
|
|
|