Accepting request 455359 from home:jengelh:branches:Virtualization:containers

factory review result

OBS-URL: https://build.opensuse.org/request/show/455359
OBS-URL: https://build.opensuse.org/package/show/Virtualization:containers/umoci?expand=0&rev=7

umoci.changes

@@ -1,3 +1,10 @@
+-------------------------------------------------------------------
+Tue Feb  7 22:25:56 UTC 2017 - jengelh@inai.de
+
+- Trim irrelevant parts from description.
+  Replace %__macros by their simpler commands.
+  fdupes should respect partition boundaries.
+
 -------------------------------------------------------------------
 Mon Feb  6 17:06:05 UTC 2017 - asarai@suse.com
 

umoci.spec

@@ -48,11 +48,8 @@ ExcludeArch:    s390x
 %description
 umoci modifies Open Container images.
 
-umoci intends to be a complete manipulation tool for OCI images. In particular,
+umoci is a manipulation tool for OCI images. In particular, it is an
-it should be seen as a more end-user-focused version of the oci-image-tools
+alternative to oci-image-tools provided by the OCI.
-provided by the OCI. The hope is that all of this tooling will eventually be
-merged with the upstream repository, so that it is always kept up-to-date by
-the Open Container Initiative community.
 
 %prep
 %setup -q
@@ -81,16 +78,16 @@ make doc
 
 %install
 # Install the binary.
-%{__install} -D -m 0755 %{name} "%{buildroot}/%{_bindir}/%{name}"
+install -D -m 0755 %{name} "%{buildroot}/%{_bindir}/%{name}"
 
 # Install all of the docs.
 %ifarch %{go_arches}
 for file in man/*.1; do
-	%{__install} -D -m 0644 $file "%{buildroot}/%{_mandir}/man1/$(basename $file)"
+	install -D -m 0644 $file "%{buildroot}/%{_mandir}/man1/$(basename $file)"
 done
 %endif
 
-%fdupes %{buildroot}
+%fdupes %{buildroot}/%{_prefix}
 
 %check
 export GOPATH=$HOME/go