OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/valgrind?expand=0&rev=14

massif-fixes.diff

@@ -0,0 +1,27 @@
+--- massif/ms_main.c
++++ massif/ms_main.c
+@@ -1669,15 +1669,18 @@ print_summary(ULong total_ST, ULong heap
+    if (VG_(clo_verbosity) > 1) {
+       tl_assert(n_xpts > 0);  // always have alloc_xpt
+       VG_(message)(Vg_DebugMsg, "    allocs: %u", n_allocs);
+-      VG_(message)(Vg_DebugMsg, "zeroallocs: %u (%d%%)", n_zero_allocs,
+-                                n_zero_allocs * 100 / n_allocs );
++      if ( n_allocs )
++         VG_(message)(Vg_DebugMsg, "zeroallocs: %u (%d%%)", n_zero_allocs,
++                                   n_zero_allocs * 100 / n_allocs );
+       VG_(message)(Vg_DebugMsg, "     frees: %u", n_frees);
+       VG_(message)(Vg_DebugMsg, "      XPts: %u (%d B)", n_xpts,
+                                                          n_xpts*sizeof(XPt));
+-      VG_(message)(Vg_DebugMsg, "  bot-XPts: %u (%d%%)", n_bot_xpts,
+-                                n_bot_xpts * 100 / n_xpts);
+-      VG_(message)(Vg_DebugMsg, "  top-XPts: %u (%d%%)", alloc_xpt->n_children,
+-                                alloc_xpt->n_children * 100 / n_xpts);
++      if ( n_xpts ) 
++         VG_(message)(Vg_DebugMsg, "  bot-XPts: %u (%d%%)", n_bot_xpts,
++                                   n_bot_xpts * 100 / n_xpts);
++      if ( n_xpts )
++         VG_(message)(Vg_DebugMsg, "  top-XPts: %u (%d%%)", alloc_xpt->n_children,
++                                   alloc_xpt->n_children * 100 / n_xpts);
+       VG_(message)(Vg_DebugMsg, "c-reallocs: %u", n_children_reallocs);
+       VG_(message)(Vg_DebugMsg, "snap-frees: %u", n_snapshot_frees);
+       VG_(message)(Vg_DebugMsg, "atmp censi: %u", n_attempted_censi);

valgrind.changes

@@ -1,3 +1,8 @@
+-------------------------------------------------------------------
+Fri Sep 14 11:09:27 CEST 2007 - dmueller@suse.de
+
+- fix divisions by zero in massif (#310234) 
+
 -------------------------------------------------------------------
 Wed Sep 12 15:26:43 CEST 2007 - dmueller@suse.de
 

valgrind.spec

@@ -20,13 +20,13 @@ BuildRequires:  gcc-32bit
 BuildRequires:  gcc-32bit glibc-32bit
 %endif
 %endif
-URL:            http://valgrind.org/
+Url:            http://valgrind.org/
 License:        GPL v2 only
 Group:          Development/Tools/Debuggers
-Summary:        Memory Management Debugger
+Summary:        Valgrind Suite of Tools for Debugging and Profiling
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 Version:        3.2.3
-Release:        52
+Release:        54
 Source0:        %{name}-%{version}.tar.bz2
 # svn  di svn://svn.valgrind.org/valgrind/tags/VALGRIND_3_2_1 svn://svn.valgrind.org/valgrind/branches/VALGRIND_3_2_BRANCH > 3_2_BRANCH.diff
 # svn  di svn://svn.valgrind.org/vex/tags/VEX_3_2_1 svn://svn.valgrind.org/vex/branches/VEX_3_2_BRANCH > VEX_3_2_BRANCH.diff
@@ -38,29 +38,31 @@ Patch7:         glibc-2.6.diff
 Patch8:         jit-runtime-support.diff
 Patch9:         glibc-2.6.1.diff
 Patch10:        amd64-nop-prefixes.diff
+Patch11:        massif-fixes.diff
 Provides:       callgrind
 Obsoletes:      callgrind
-ExclusiveArch: %ix86 x86_64 ppc ppc64
+ExclusiveArch:  %ix86 x86_64 ppc ppc64
 
 %description
 Valgrind checks all memory operations in an application, like read,
 write, malloc, new, free, and delete. Valgrind can find uses of
 uninitialized memory, access to already freed memory, overflows,
-illegal stack operations, memory leaks, and any illegal
+illegal heap operations, memory leaks, and any illegal
 new/malloc/free/delete commands. Another program in the package is
-"cachegrind," a profiler based on the valgrind engine.
+"cachegrind," a profiler based on the valgrind engine. It is plugin
+based and many different tools are available.
 
-To use valgrind you should compile your application with "-g -O0"
+To use valgrind you should launch the application like normal with
-compiler options. Afterwards you can use it with:
+debuginfo packages installed, for example:
+
+
+_memcheck --leak-check_
 
-valgrind --tool=memcheck --sloppy-malloc=yes --leak-check=yes
---db-attach=yes my_application, for example.
 
 More valgrind options can be listed via "valgrind --help". There is
 also complete documentation in the /usr/share/doc/packages/valgrind/
 directory. A debugged application runs slower and needs much more
-memory, but is usually still usable. Valgrind is still in development,
+memory, but is usually still usable.
-but it has been successfully used to optimize several KDE applications.
 
 
 
@@ -76,7 +78,7 @@ Authors:
     Robert Walsh
 
 %package devel
-Summary:        Memory Management Debugger
+Summary:        Valgrind Suite of Tools for Debugging and Profiling
 Group:          Development/Tools/Debuggers
 Requires:       %name = %version
 
@@ -84,21 +86,22 @@ Requires:       %name = %version
 Valgrind checks all memory operations in an application, like read,
 write, malloc, new, free, and delete. Valgrind can find uses of
 uninitialized memory, access to already freed memory, overflows,
-illegal stack operations, memory leaks, and any illegal
+illegal heap operations, memory leaks, and any illegal
 new/malloc/free/delete commands. Another program in the package is
-"cachegrind," a profiler based on the valgrind engine.
+"cachegrind," a profiler based on the valgrind engine. It is plugin
+based and many different tools are available.
 
-To use valgrind you should compile your application with "-g -O0"
+To use valgrind you should launch the application like normal with
-compiler options. Afterwards you can use it with:
+debuginfo packages installed, for example:
+
+
+_memcheck --leak-check_
 
-valgrind --tool=memcheck --sloppy-malloc=yes --leak-check=yes
---db-attach=yes my_application, for example.
 
 More valgrind options can be listed via "valgrind --help". There is
 also complete documentation in the /usr/share/doc/packages/valgrind/
 directory. A debugged application runs slower and needs much more
-memory, but is usually still usable. Valgrind is still in development,
+memory, but is usually still usable.
-but it has been successfully used to optimize several KDE applications.
 
 
 
@@ -126,6 +129,7 @@ cd ..
 %patch8
 %patch9
 %patch10
+%patch11
 
 %build
 export CFLAGS="$RPM_OPT_FLAGS"
@@ -155,6 +159,8 @@ mv $RPM_BUILD_ROOT/usr/share/doc/valgrind $RPM_BUILD_ROOT/usr/share/doc/packages
 %_libdir/valgrind/*/*.a
 
 %changelog
+* Fri Sep 14 2007 - dmueller@suse.de
+- fix divisions by zero in massif (#310234)
 * Wed Sep 12 2007 - dmueller@suse.de
 - fix build on ppc64 again
 - update suppressions