33 lines
1.6 KiB
Diff
33 lines
1.6 KiB
Diff
|
Subject: console: Ensure bool value used for set_sensitive call
|
||
|
|
From: Cole Robinson crobinso@redhat.com Wed Mar 29 12:07:02 2017 -0400
|
||
|
|
Date: Wed Mar 29 12:07:50 2017 -0400:
|
||
|
|
Git: 0610cd6acb5d59f492070759b01e8ee5ccd082a9
|
||
|
|
|
||
|
|
Seen in a bug log file:
|
||
|
|
|
||
|
|
[Tue, 28 Mar 2017 12:05:21 virt-manager 2465] DEBUG (cli:251) Uncaught exception:
|
||
|
|
Traceback (most recent call last):
|
||
|
|
File "/usr/share/virt-manager/virtManager/details.py", line 1303, in refresh_vm_state
|
||
|
|
self.console.details_update_widget_states()
|
||
|
|
File "/usr/share/virt-manager/virtManager/console.py", line 1025, in details_update_widget_states
|
||
|
|
return self._update_vm_widget_states()
|
||
|
|
File "/usr/share/virt-manager/virtManager/console.py", line 597, in _update_vm_widget_states
|
||
|
|
self._refresh_widget_states()
|
||
|
|
File "/usr/share/virt-manager/virtManager/console.py", line 663, in _refresh_widget_states
|
||
|
|
self.widget("details-menu-vm-screenshot").set_sensitive(is_viewer)
|
||
|
|
TypeError: Argument 1 does not allow None as a value
|
||
|
|
|
||
|
|
diff --git a/virtManager/console.py b/virtManager/console.py
|
||
|
|
index 0c051c7f..9bb0295a 100644
|
||
|
|
--- a/virtManager/console.py
|
||
|
|
+++ b/virtManager/console.py
|
||
|
|
@@ -658,7 +658,7 @@ class vmmConsolePages(vmmGObjectUI):
|
||
|
|
def _refresh_widget_states(self):
|
||
|
|
pagenum = self.widget("console-pages").get_current_page()
|
||
|
|
paused = self.vm.is_paused()
|
||
|
|
- is_viewer = (pagenum == _CONSOLE_PAGE_VIEWER and
|
||
|
|
+ is_viewer = bool(pagenum == _CONSOLE_PAGE_VIEWER and
|
||
|
|
self._viewer and self._viewer.console_is_open())
|
||
|
|
|
||
|
|
self.widget("details-menu-vm-screenshot").set_sensitive(is_viewer)
|