2015-05-04 22:15:01 +02:00
|
|
|
Reference: bnc#887868
|
2014-07-24 21:44:55 +02:00
|
|
|
Refresh pools status before fetch_pools.
|
|
|
|
|
|
|
|
Currently, when connecting to hypervisor, if there are pools active
|
|
|
|
but in fact target path already deleted (or for other reasons the
|
|
|
|
pool is not working), libvirtd not refresh status yet, fetch_pools
|
|
|
|
will fail, that will cause "connecting to hypervisor" process
|
|
|
|
reporting error and exit. The whole connection work failed.
|
|
|
|
|
|
|
|
With the patch, always refresh pool status before fetch pools. Let
|
|
|
|
the libvirtd pool status reflect the reality, avoid the non-synced
|
|
|
|
status affects the hypervisor connection.
|
|
|
|
|
|
|
|
Signed-off-by: Chunyan Liu <cyliu@suse.com>
|
|
|
|
|
- bsc#1140211 - VUL-1: CVE-2019-10183: virt-manager: unattended
option leaks password via command line argument
58c68764-unattended-Read-the-passwords-from-a-file.patch
51d28f04-unattended-Dont-log-user-admin-passwords.patch
- Upstream bug fix (bsc#1027942)
5312a961-virt-install-Revive-wait-0-as-alias-for-noautoconsole.patch
- Update to virt-manager 2.2.0 (fate#326786)
virt-manager-2.2.0.tar.bz2
* libvirt XML viewing and editing UI for new and existing domain, pools, volumes, networks
* virt-install: libosinfo –unattended support (Fabiano Fidêncio, Cole Robinson)
* Improve CPU model security defaults (Pavel Hrdina)
* virt-install: new –install option. Ex: virt-install –install fedora29
* virt-install: new –install kernel=,initrd=
* virt-install: –disk, –memory, –name defaults from libosinfo (Fabiano Fidêncio, Cole Robinson)
* virt-install: add device suboption aliases which consistently match libvirt XML naming
* virt-xml: new –start, –no-define options (Marc Hartmayer)
* virt-install: Add driver_queues argument to –controller (Vasudeva Kamath)
* RISC-V support (Andrea Bolognani)
* Device default improvements for non-x86 KVM (Andrea Bolognani)
* Redesigned ‘New Network’ wizard
* libguestfs inspection improvements (Pino Toscano)
* virt-install: Add support for xenbus controller (Jim Fehlig)
* cli: Add –disk wwn=,rawio= (Athina Plaskasoviti)
* cli: Add –memballoon autodeflate=,stats.period= (Athina Plaskasoviti)
* cli: Add –iothreads (Athina Plaskasoviti)
* cli: Add –numatune memory.placement (Athina Plaskasoviti)
* cli: Add –launchSecurity option (Erik Skultety)
* cli: Fill in –memorybacking options
* cli: –smartcard: support database= and certificate[0-9]*=
OBS-URL: https://build.opensuse.org/package/show/Virtualization/virt-manager?expand=0&rev=476
2019-07-03 20:19:42 +02:00
|
|
|
Index: virt-manager-2.2.0/virtinst/pollhelpers.py
|
2014-07-24 21:44:55 +02:00
|
|
|
===================================================================
|
- bsc#1140211 - VUL-1: CVE-2019-10183: virt-manager: unattended
option leaks password via command line argument
58c68764-unattended-Read-the-passwords-from-a-file.patch
51d28f04-unattended-Dont-log-user-admin-passwords.patch
- Upstream bug fix (bsc#1027942)
5312a961-virt-install-Revive-wait-0-as-alias-for-noautoconsole.patch
- Update to virt-manager 2.2.0 (fate#326786)
virt-manager-2.2.0.tar.bz2
* libvirt XML viewing and editing UI for new and existing domain, pools, volumes, networks
* virt-install: libosinfo –unattended support (Fabiano Fidêncio, Cole Robinson)
* Improve CPU model security defaults (Pavel Hrdina)
* virt-install: new –install option. Ex: virt-install –install fedora29
* virt-install: new –install kernel=,initrd=
* virt-install: –disk, –memory, –name defaults from libosinfo (Fabiano Fidêncio, Cole Robinson)
* virt-install: add device suboption aliases which consistently match libvirt XML naming
* virt-xml: new –start, –no-define options (Marc Hartmayer)
* virt-install: Add driver_queues argument to –controller (Vasudeva Kamath)
* RISC-V support (Andrea Bolognani)
* Device default improvements for non-x86 KVM (Andrea Bolognani)
* Redesigned ‘New Network’ wizard
* libguestfs inspection improvements (Pino Toscano)
* virt-install: Add support for xenbus controller (Jim Fehlig)
* cli: Add –disk wwn=,rawio= (Athina Plaskasoviti)
* cli: Add –memballoon autodeflate=,stats.period= (Athina Plaskasoviti)
* cli: Add –iothreads (Athina Plaskasoviti)
* cli: Add –numatune memory.placement (Athina Plaskasoviti)
* cli: Add –launchSecurity option (Erik Skultety)
* cli: Fill in –memorybacking options
* cli: –smartcard: support database= and certificate[0-9]*=
OBS-URL: https://build.opensuse.org/package/show/Virtualization/virt-manager?expand=0&rev=476
2019-07-03 20:19:42 +02:00
|
|
|
--- virt-manager-2.2.0.orig/virtinst/pollhelpers.py
|
|
|
|
+++ virt-manager-2.2.0/virtinst/pollhelpers.py
|
|
|
|
@@ -119,6 +119,19 @@ def fetch_pools(backend, origmap, build_
|
|
|
|
name = "pool"
|
2014-07-24 21:44:55 +02:00
|
|
|
|
- bsc#1140211 - VUL-1: CVE-2019-10183: virt-manager: unattended
option leaks password via command line argument
58c68764-unattended-Read-the-passwords-from-a-file.patch
51d28f04-unattended-Dont-log-user-admin-passwords.patch
- Upstream bug fix (bsc#1027942)
5312a961-virt-install-Revive-wait-0-as-alias-for-noautoconsole.patch
- Update to virt-manager 2.2.0 (fate#326786)
virt-manager-2.2.0.tar.bz2
* libvirt XML viewing and editing UI for new and existing domain, pools, volumes, networks
* virt-install: libosinfo –unattended support (Fabiano Fidêncio, Cole Robinson)
* Improve CPU model security defaults (Pavel Hrdina)
* virt-install: new –install option. Ex: virt-install –install fedora29
* virt-install: new –install kernel=,initrd=
* virt-install: –disk, –memory, –name defaults from libosinfo (Fabiano Fidêncio, Cole Robinson)
* virt-install: add device suboption aliases which consistently match libvirt XML naming
* virt-xml: new –start, –no-define options (Marc Hartmayer)
* virt-install: Add driver_queues argument to –controller (Vasudeva Kamath)
* RISC-V support (Andrea Bolognani)
* Device default improvements for non-x86 KVM (Andrea Bolognani)
* Redesigned ‘New Network’ wizard
* libguestfs inspection improvements (Pino Toscano)
* virt-install: Add support for xenbus controller (Jim Fehlig)
* cli: Add –disk wwn=,rawio= (Athina Plaskasoviti)
* cli: Add –memballoon autodeflate=,stats.period= (Athina Plaskasoviti)
* cli: Add –iothreads (Athina Plaskasoviti)
* cli: Add –numatune memory.placement (Athina Plaskasoviti)
* cli: Add –launchSecurity option (Erik Skultety)
* cli: Fill in –memorybacking options
* cli: –smartcard: support database= and certificate[0-9]*=
OBS-URL: https://build.opensuse.org/package/show/Virtualization/virt-manager?expand=0&rev=476
2019-07-03 20:19:42 +02:00
|
|
|
if backend.support.conn_listallstoragepools() and not FORCE_OLD_POLL:
|
2014-07-24 21:44:55 +02:00
|
|
|
+
|
|
|
|
+ # Refresh pools before poll_helper. For those
|
|
|
|
+ # 'active' but target path not exist (or other reasons
|
|
|
|
+ # causing the pool not working), but libvirtd not
|
|
|
|
+ # refresh the status, this will make it refreshed
|
|
|
|
+ # and mark that pool as 'inactive'.
|
|
|
|
+ objs = backend.listAllStoragePools()
|
|
|
|
+ for obj in objs:
|
|
|
|
+ try:
|
|
|
|
+ obj.refresh(0)
|
|
|
|
+ except Exception, e:
|
|
|
|
+ pass
|
|
|
|
+
|
|
|
|
return _new_poll_helper(origmap, name,
|
2014-10-29 18:03:15 +01:00
|
|
|
backend.listAllStoragePools, build_func)
|
|
|
|
else:
|