diff --git a/51d84c54-connection-Avoid-repeated-default-pool-creation-attempts.patch b/51d84c54-connection-Avoid-repeated-default-pool-creation-attempts.patch new file mode 100644 index 00000000..aae011fc --- /dev/null +++ b/51d84c54-connection-Avoid-repeated-default-pool-creation-attempts.patch @@ -0,0 +1,52 @@ +Subject: connection: Avoid repeated default pool creation attempts +From: Michael Weiser michael.weiser@gmx.de Fri Oct 25 21:27:18 2019 +0200 +Date: Tue Nov 12 12:28:34 2019 -0500: +Git: 51d84c54cb63350145f4ad3a2adba17313e1f227 + +During startup virtinst.StoragePool.build_default_pool() tries to +determine whether the default storage pool already exists. Because +events have not yet been processed, the list of existing storage pools +is still empty. Therefore it seems as if it does not exist yet and +build_default_pool() falls back to creating it which causes an error +message from libvirtd in the system log: + +libvirtd: operation failed: pool 'default' already exists with uuid. + +Move default pool creation after event processing to avoid these +redundant creation attempts. + +Signed-off-by: Michael Weiser + +diff --git a/virtManager/connection.py b/virtManager/connection.py +index f6dc5f5b..e526d495 100644 +--- a/virtManager/connection.py ++++ b/virtManager/connection.py +@@ -990,13 +990,6 @@ class vmmConnection(vmmGObject): + log.debug("%s capabilities:\n%s", + self.get_uri(), self.caps.get_xml()) + +- # Try to create the default storage pool +- # We want this before events setup to save some needless polling +- try: +- virtinst.StoragePool.build_default_pool(self.get_backend()) +- except Exception as e: +- log.debug("Building default pool failed: %s", str(e)) +- + self._add_conn_events() + + try: +@@ -1025,6 +1018,14 @@ class vmmConnection(vmmGObject): + self._init_object_event = None + self._init_object_count = None + ++ # Try to create the default storage pool ++ # We need this after events setup so we can determine if the default ++ # pool already exists ++ try: ++ virtinst.StoragePool.build_default_pool(self.get_backend()) ++ except Exception as e: ++ log.debug("Building default pool failed: %s", str(e)) ++ + def _open_thread(self): + ConnectError = None + try: diff --git a/ae19d6d6-fix-resizing-of-spice-clients-with-guest-resizing-enabled.patch b/ae19d6d6-fix-resizing-of-spice-clients-with-guest-resizing-enabled.patch new file mode 100644 index 00000000..9fb07ca1 --- /dev/null +++ b/ae19d6d6-fix-resizing-of-spice-clients-with-guest-resizing-enabled.patch @@ -0,0 +1,23 @@ +Subject: fix resizing of spice clients with guest resizing enabled +From: Florian Ludwig f.ludwig@greyrook.com Wed Oct 9 11:18:53 2019 +0200 +Date: Tue Nov 12 11:46:35 2019 -0500: +Git: ae19d6d6ec0b48085ce1c765fb2264e27fb51c63 + +Fixes 1414718 + +diff --git a/virtManager/details/console.py b/virtManager/details/console.py +index 8ef8631a..193e79eb 100644 +--- a/virtManager/details/console.py ++++ b/virtManager/details/console.py +@@ -374,7 +374,10 @@ class vmmConsolePages(vmmGObjectUI): + if is_resizeguest: + # With resize guest, we don't want to maintain aspect ratio, + # since the guest can resize to arbitrary resolutions. +- self._viewer.console_set_size_request(req.width, req.height) ++ viewer_alloc = Gdk.Rectangle() ++ viewer_alloc.width = req.width ++ viewer_alloc.height = req.height ++ self._viewer.console_size_allocate(viewer_alloc) + return + + if not is_scale: diff --git a/d934d6f2-domcaps-Fix-check-for-uncached-security-features.patch b/d934d6f2-domcaps-Fix-check-for-uncached-security-features.patch new file mode 100644 index 00000000..9a3b177e --- /dev/null +++ b/d934d6f2-domcaps-Fix-check-for-uncached-security-features.patch @@ -0,0 +1,24 @@ +Subject: domcaps: Fix check for uncached security features +From: Cole Robinson crobinso@redhat.com Tue Nov 12 14:15:56 2019 -0500 +Date: Tue Nov 12 14:17:21 2019 -0500: +Git: d934d6f266e1731a5b881bbb9ae4cd60acd7887e + +We need to check against None, which is the initial value, otherwise +a host with none of the security features present will repeatedly poll +libvirt baseline APIs + +Signed-off-by: Cole Robinson + +diff --git a/virtinst/domcapabilities.py b/virtinst/domcapabilities.py +index ea0ffd1f..34991ed7 100644 +--- a/virtinst/domcapabilities.py ++++ b/virtinst/domcapabilities.py +@@ -296,7 +296,7 @@ class DomainCapabilities(XMLBuilder): + 'virt-ssbd', + 'md-clear'] + +- if self._features: ++ if self._features is not None: + return self._features + + self._features = [] diff --git a/virt-manager.changes b/virt-manager.changes index 043f42bc..46fa02bc 100644 --- a/virt-manager.changes +++ b/virt-manager.changes @@ -4,6 +4,9 @@ Tue Nov 12 10:17:56 MST 2019 - carnold@suse.com - Upstream bug fixes (bsc#1027942) 1547e16d-domcapabilities-Get-video-devices.patch 2e20b128-domcapabilities-Add-supports_video_bochs.patch + ae19d6d6-fix-resizing-of-spice-clients-with-guest-resizing-enabled.patch + 51d84c54-connection-Avoid-repeated-default-pool-creation-attempts.patch + d934d6f2-domcaps-Fix-check-for-uncached-security-features.patch ------------------------------------------------------------------- Mon Oct 28 07:35:25 MDT 2019 - carnold@suse.com diff --git a/virt-manager.spec b/virt-manager.spec index c9bfecb1..8febb39b 100644 --- a/virt-manager.spec +++ b/virt-manager.spec @@ -43,6 +43,9 @@ Patch8: 1547e16d-domcapabilities-Get-video-devices.patch Patch9: 2e20b128-domcapabilities-Add-supports_video_bochs.patch Patch10: d9736db9-addhardware-Add-bochs-display-to-the-video-list.patch Patch11: 8f4c53ea-video-Prefer-bochs-when-its-supported..patch +Patch12: ae19d6d6-fix-resizing-of-spice-clients-with-guest-resizing-enabled.patch +Patch13: 51d84c54-connection-Avoid-repeated-default-pool-creation-attempts.patch +Patch14: d934d6f2-domcaps-Fix-check-for-uncached-security-features.patch # SUSE Only Patch70: virtman-desktop.patch Patch71: virtman-kvm.patch @@ -186,6 +189,9 @@ machine). %patch9 -p1 %patch10 -p1 %patch11 -p1 +%patch12 -p1 +%patch13 -p1 +%patch14 -p1 # SUSE Only %patch70 -p1 %patch71 -p1