diff --git a/15a9502b-Fix-showing-the-firmware-type-in-case-of-firmware-auto-selection.patch b/15a9502b-Fix-showing-the-firmware-type-in-case-of-firmware-auto-selection.patch new file mode 100644 index 00000000..27b35428 --- /dev/null +++ b/15a9502b-Fix-showing-the-firmware-type-in-case-of-firmware-auto-selection.patch @@ -0,0 +1,34 @@ +Subject: details: Fix showing the firmware type in case of firmware auto selection +From: Lin Ma lma@suse.com Wed Jan 15 10:34:12 2020 +0800 +Date: Wed Jan 15 10:21:46 2020 -0500: +Git: 15a9502b7b7a263c4d66ff2b3f31c209f58fe0b4 + +For a shutoff VM, If user select uefi firmware auto selection, e.g. + +... + + +Its firmware information is set to 'BIOS' in details, This is incorrect. +This fixes it. + +Reviewed-by: Cole Robinson +Signed-off-by: Lin Ma + +Index: virt-manager-2.2.1/virtManager/details/details.py +=================================================================== +--- virt-manager-2.2.1.orig/virtManager/details/details.py ++++ virt-manager-2.2.1/virtManager/details/details.py +@@ -2017,8 +2017,11 @@ class vmmDetails(vmmGObjectUI): + + # Firmware + domcaps = self.vm.get_domain_capabilities() +- firmware = domcaps.label_for_firmware_path( +- self.vm.get_xmlobj().os.loader) ++ if self.vm.get_xmlobj().is_uefi(): ++ firmware = 'UEFI' ++ else: ++ firmware = domcaps.label_for_firmware_path( ++ self.vm.get_xmlobj().os.loader) + if self.widget("overview-firmware").is_visible(): + uiutil.set_list_selection( + self.widget("overview-firmware"), firmware) diff --git a/virt-manager.changes b/virt-manager.changes index 7a15be28..7f97196e 100644 --- a/virt-manager.changes +++ b/virt-manager.changes @@ -1,3 +1,9 @@ +------------------------------------------------------------------- +Mon Mar 9 13:46:48 MDT 2020 - carnold@suse.com + +- Upstream bug fix (bsc#1027942) + 15a9502b-Fix-showing-the-firmware-type-in-case-of-firmware-auto-selection.patch + ------------------------------------------------------------------- Mon Dec 2 14:03:00 MST 2019 - carnold@suse.com diff --git a/virt-manager.spec b/virt-manager.spec index 7d2390e6..00dfee48 100644 --- a/virt-manager.spec +++ b/virt-manager.spec @@ -1,7 +1,7 @@ # # spec file for package virt-manager # -# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2020 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -47,6 +47,7 @@ Patch12: ae19d6d6-fix-resizing-of-spice-clients-with-guest-resizing-enabl Patch13: 51d84c54-connection-Avoid-repeated-default-pool-creation-attempts.patch Patch14: d934d6f2-domcaps-Fix-check-for-uncached-security-features.patch Patch15: 29f9f5f2-virt-xml-fix-defined_xml_is_unchanged.patch +Patch16: 15a9502b-Fix-showing-the-firmware-type-in-case-of-firmware-auto-selection.patch # SUSE Only Patch70: virtman-desktop.patch Patch71: virtman-kvm.patch @@ -193,6 +194,7 @@ machine). %patch13 -p1 %patch14 -p1 %patch15 -p1 +%patch16 -p1 # SUSE Only %patch70 -p1 %patch71 -p1