From da54199b5ffe8b415b46fbabd3759f563a1ec2e3 Mon Sep 17 00:00:00 2001
From: Charles Arnold <carnold@suse.com>
Date: Mon, 11 Dec 2017 22:06:47 +0000
Subject: [PATCH] - bsc#1071825 - AttributeError: 'NoneType' object has no
 attribute   'change_run_text'  
 virtman-register-delete-event-for-details-dialog.patch

OBS-URL: https://build.opensuse.org/package/show/Virtualization/virt-manager?expand=0&rev=388
---
 virt-manager.changes                          |  7 ++++++
 virt-manager.spec                             |  2 ++
 ...ster-delete-event-for-details-dialog.patch | 22 +++++++++++++++++++
 3 files changed, 31 insertions(+)
 create mode 100644 virtman-register-delete-event-for-details-dialog.patch

diff --git a/virt-manager.changes b/virt-manager.changes
index e60769f4..be68abaa 100644
--- a/virt-manager.changes
+++ b/virt-manager.changes
@@ -1,3 +1,10 @@
+-------------------------------------------------------------------
+Mon Dec 11 14:50:59 MST 2017 - carnold@suse.com
+
+- bsc#1071825 - AttributeError: 'NoneType' object has no attribute
+  'change_run_text'
+  virtman-register-delete-event-for-details-dialog.patch
+
 -------------------------------------------------------------------
 Thu Dec  7 12:41:25 UTC 2017 - cbosdonnat@suse.com
 
diff --git a/virt-manager.spec b/virt-manager.spec
index 2b923aae..a43d8eeb 100644
--- a/virt-manager.spec
+++ b/virt-manager.spec
@@ -126,6 +126,7 @@ Patch206:       0001-virtinst-python3-terminal-width-should-be-int.patch
 Patch207:       0002-virtinst-python3-avoid-comparison-of-None-and-int.patch
 Patch208:       0003-virtinst-python3-avoid-using-long-type.patch
 Patch209:       0004-virtinst-python3-use-binary-mode-for-kernel.patch
+Patch210:       virtman-register-delete-event-for-details-dialog.patch
 
 BuildArch:      noarch
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
@@ -297,6 +298,7 @@ machine).
 %patch207 -p1
 %patch208 -p1
 %patch209 -p1
+%patch210 -p1
 
 %build
 %if %{qemu_user}
diff --git a/virtman-register-delete-event-for-details-dialog.patch b/virtman-register-delete-event-for-details-dialog.patch
new file mode 100644
index 00000000..25ff168d
--- /dev/null
+++ b/virtman-register-delete-event-for-details-dialog.patch
@@ -0,0 +1,22 @@
+References: bsc#1071825
+Running under python3 the delete-event as defined in details.ui and connected
+in details.py does not get called when the top right (x) button on the dialog
+is clicked. It appears that even though this code is unchanged and works on python2,
+it is not recognized as a top level dialog on python3 and therefore we explicitly
+need to set the connection event. Not getting the event to cleanup leaves us in a
+bad state for when the details dialog is reopened.
+
+Index: virt-manager-1.4.3/virtManager/details.py
+===================================================================
+--- virt-manager-1.4.3.orig/virtManager/details.py
++++ virt-manager-1.4.3/virtManager/details.py
+@@ -596,6 +596,9 @@ class vmmDetails(vmmGObjectUI):
+                 self.console.details_auth_login),
+         })
+ 
++        # Make sure the delete event is properly registered for the details dialog
++        self.topwin.connect("delete-event", self._window_delete_event)
++
+         # Deliberately keep all this after signal connection
+         self.vm.connect("state-changed", self.refresh_vm_state)
+         self.vm.connect("resources-sampled", self.refresh_resources)