Subject: cloner: Sync and system uuid From: Cole Robinson crobinso@redhat.com Sun Aug 21 16:21:10 2022 -0400 Date: Sun Aug 21 16:21:10 2022 -0400: Git: b0d0516736320315a70f74aff3759fb35dd35d9d Otherwise libvirt errors like: ERROR UUID mismatch between and https://bugzilla.redhat.com/show_bug.cgi?id=2038040 Signed-off-by: Cole Robinson diff --git a/tests/data/cli/compare/virt-clone-auto-unmanaged.xml b/tests/data/cli/compare/virt-clone-auto-unmanaged.xml index 21a9a639..f2043be2 100644 --- a/tests/data/cli/compare/virt-clone-auto-unmanaged.xml +++ b/tests/data/cli/compare/virt-clone-auto-unmanaged.xml @@ -1,6 +1,11 @@ origtest-clone 00000000-1111-2222-3333-444444444444 + + + 00000000-1111-2222-3333-444444444444 + + 8388608 2097152 2 diff --git a/tests/data/cli/compare/virt-clone-unmanaged-preserve.xml b/tests/data/cli/compare/virt-clone-unmanaged-preserve.xml index 3bdbbbe3..c003ed3e 100644 --- a/tests/data/cli/compare/virt-clone-unmanaged-preserve.xml +++ b/tests/data/cli/compare/virt-clone-unmanaged-preserve.xml @@ -1,6 +1,11 @@ clonetest 00000000-1111-2222-3333-444444444444 + + + 00000000-1111-2222-3333-444444444444 + + 8388608 2097152 2 diff --git a/tests/data/cli/virtclone/clone-disk.xml b/tests/data/cli/virtclone/clone-disk.xml index da1eb0a6..2f6e916d 100644 --- a/tests/data/cli/virtclone/clone-disk.xml +++ b/tests/data/cli/virtclone/clone-disk.xml @@ -1,6 +1,11 @@ origtest db69fa1f-eef0-e567-3c20-3ef16f10376b + + + db69fa1f-eef0-e567-3c20-3ef16f10376b + + 8388608 2097152 2 diff --git a/virtinst/cloner.py b/virtinst/cloner.py index 34a702f9..9334513c 100644 --- a/virtinst/cloner.py +++ b/virtinst/cloner.py @@ -352,8 +352,7 @@ class Cloner(object): """ self._new_guest.id = None self._new_guest.title = None - self._new_guest.uuid = None - self._new_guest.uuid = Guest.generate_uuid(self.conn) + self.set_clone_uuid(Guest.generate_uuid(self.conn)) for dev in self._new_guest.devices.graphics: if dev.port and dev.port != -1: @@ -408,6 +407,9 @@ class Cloner(object): Override the new VMs generated UUId """ self._new_guest.uuid = uuid + for sysinfo in self._new_guest.sysinfo: + if sysinfo.system_uuid: + sysinfo.system_uuid = uuid def set_replace(self, val): """