Subject: addhardware: generate target only if not customizing
From: Martin Kletzander mkletzan@redhat.com Tue Feb 18 11:38:56 2014 +0100
Date: Tue Feb 18 16:09:12 2014 +0100:
Git: bc5d84b0407257b1e257e7cabaf619430a7e8f83

Commit 078e1a4d0503d98884b5b61df83021941bf32e8d changed the fact that
disk target was generated only when adding new disk, not when current
disk is being customized, so fix that back.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>

diff --git a/virtManager/addhardware.py b/virtManager/addhardware.py
index ecb5fc8..b1f6251 100644
--- a/virtManager/addhardware.py
+++ b/virtManager/addhardware.py
@@ -1471,20 +1471,22 @@ class vmmAddHardware(vmmGObjectUI):
             return disk
 
         try:
+            used = []
             disk.bus = bus
             if cache:
                 disk.driver_cache = cache
 
             # Generate target
             if not self.is_customize_dialog:
-                used = []
                 disks = (self.vm.get_disk_devices() +
                          self.vm.get_disk_devices(inactive=True))
                 for d in disks:
                     used.append(d.target)
 
             prefer_ctrl = self._set_disk_controller(disk, controller_model, disks)
-            disk.generate_target(used, prefer_ctrl)
+
+            if not self.is_customize_dialog:
+                disk.generate_target(used, prefer_ctrl)
 
         except Exception, e:
             return self.err.val_err(_("Storage parameter error."), e)