287c87ccd9
'virtio1.0-input' 1d2cd306-Fix-incorrect-usage-of-virtio-input.patch - bsc#1005848 - KVM: guest can not be started on top of SLES12SP1 KVM host ppc64 5a11cf07-virt-manager-generates-invalid-guest-XML.patch - Upstream bug fixes 617b9271-dont-return-virtio1.0-net-as-valid-device-name.patch 7962672c-fix-error-checking-extra_args.patch b4858842-fix-bad-version-check-regression.patch f07a3021-fix-wait-to-behave-like-noautoconsole.patch - bsc#1005861 - virt-manager create new machine dialog box too small to display system type virtinst-expand-combobox.patch - fate#314135: Support PVSCSI on XEN and VirtioSCSI on KVM - - fate#313076: HBA passthrough for kvm OBS-URL: https://build.opensuse.org/package/show/Virtualization/virt-manager?expand=0&rev=338
26 lines
1007 B
Diff
26 lines
1007 B
Diff
Subject: virt-install: Fix error checking extra_args
|
|
From: Cole Robinson crobinso@redhat.com Wed Nov 2 10:27:14 2016 -0400
|
|
Date: Wed Nov 2 10:27:14 2016 -0400:
|
|
Git: 7962672c713cf6d35e770f0d00068dee707b6ec9
|
|
|
|
Later bits in the code that want to warn based on extra_args content
|
|
don't handle the None case. Be consistent and convert it to a list
|
|
everywhere.
|
|
|
|
Mentioned at https://bugzilla.redhat.com/show_bug.cgi?id=1376547#c9
|
|
|
|
Index: virt-manager-1.4.0/virt-install
|
|
===================================================================
|
|
--- virt-manager-1.4.0.orig/virt-install
|
|
+++ virt-manager-1.4.0/virt-install
|
|
@@ -595,7 +595,8 @@ def build_guest_instance(conn, options):
|
|
convert_old_os_options(options)
|
|
|
|
# non-xml install options
|
|
- guest.installer.extraargs = options.extra_args or []
|
|
+ options.extra_args = options.extra_args or []
|
|
+ guest.installer.extraargs = options.extra_args
|
|
guest.installer.initrd_injections = options.initrd_inject
|
|
guest.autostart = options.autostart
|
|
|