2d558399a0
57db4185-virt-clone-fix-force-copy-of-empty-cdrom-or-floppy-disk.patch 26a433fc-virtManager-clone-check-which-storage-pools-supports-volume-cloning.patch 4f66c423-cloner-Handle-nonsparse-for-qcow2-images.patch a02fc0d0-virtManager-clone-build-default-clone-path-if-we-know-how.patch 1856c1fa-support-Fix-minimum-version-check.patch 74bbc3db-urldetect-Check-also-for-treeinfo.patch 708af01c-osdict-Add-supports_virtioinput.patch f23b01be-guest-Add-VirtIO-input-devices-to-s390x-guests-with-graphics.patch 7afbb90b-virt-xml-Handle-VM-names-that-look-like-id-uuid.patch a0ca387a-cli-Fix-pool-default-when-path-belongs-to-another-pool.patch OBS-URL: https://build.opensuse.org/package/show/Virtualization/virt-manager?expand=0&rev=465
44 lines
1.7 KiB
Diff
44 lines
1.7 KiB
Diff
Subject: guest: Add VirtIO input devices to s390x guests with graphics
|
|
From: Andrea Bolognani abologna@redhat.com Wed Mar 20 16:52:35 2019 +0100
|
|
Date: Thu Mar 21 15:31:20 2019 +0100:
|
|
Git: f23b01be53aa8b5b8d91aadbfb0c06268fa5c7b9
|
|
|
|
We're not including any input devices in the generated XML
|
|
for s390x guests, and the results is that it's not possible
|
|
to interact with them short of using the serial console or
|
|
connecting through ssh, which is fine but probably not what
|
|
is expected when graphics are present.
|
|
|
|
USB input devices are not a good fit for s390x guests: USB
|
|
requires PCI, and PCI is not widely available or used on
|
|
s390x; VirtIO devices, on the other hand, are a perfect
|
|
match since s390x guests use basically no emulated devices
|
|
and rely on VirtIO for most functionality.
|
|
|
|
https://bugzilla.redhat.com/show_bug.cgi?id=1683609
|
|
|
|
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
|
|
|
|
Index: virt-manager-2.1.0/virtinst/guest.py
|
|
===================================================================
|
|
--- virt-manager-2.1.0.orig/virtinst/guest.py
|
|
+++ virt-manager-2.1.0/virtinst/guest.py
|
|
@@ -588,6 +588,17 @@ class Guest(XMLBuilder):
|
|
dev.bus = "usb"
|
|
self.add_device(dev)
|
|
|
|
+ # s390x guests need VirtIO input devices
|
|
+ if self.os.is_s390x() and self.osinfo.supports_virtioinput():
|
|
+ dev = DeviceInput(self.conn)
|
|
+ dev.type = "tablet"
|
|
+ dev.bus = "virtio"
|
|
+ self.add_device(dev)
|
|
+ dev = DeviceInput(self.conn)
|
|
+ dev.type = "keyboard"
|
|
+ dev.bus = "virtio"
|
|
+ self.add_device(dev)
|
|
+
|
|
def _add_default_console_device(self):
|
|
if self.skip_default_console:
|
|
return
|