2677655bda
001-adf30349-cli-refactor-get_prop.patch 002-60c7e778-xmlapi-add-set_prop.patch 003-5bad22e8-tests-Use-get-set_prop.patch 004-ee5f3eab-support-Add-SUPPORT_CONN_DEVICE_BOOT_ORDER.patch 005-7768eb17-cli-Add-check-if-device-boot-order-is-supported.patch 006-ecc0861c-tests-xmlparse-refactor-method-for-generating-out-file-path.patch 007-c9d070da-guest-Add-reorder_boot_order-method.patch 008-1b535940-tests-Add-test-case-for-reorder_boot_order-method.patch 009-b83a0a61-cli-Use-reorder_boot_order-for-setting-the-boot-order.patch 010-c896d19d-tests-cli-Add-boot.order-tests.patch 011-29f9f2ac-virt-xml-Add-no-define-argument.patch 012-c2bff509-tests-cli-Add-test-case-for-no-define-argument.patch 013-90b1a3ab-virt-xml-Add-support-for-starting-the-domain.patch 014-908b8e8d-tests-virt-xml-Add-test-cases-for-start-option.patch OBS-URL: https://build.opensuse.org/package/show/Virtualization/virt-manager?expand=0&rev=468
32 lines
1.3 KiB
Diff
32 lines
1.3 KiB
Diff
Subject: cli: Fix pool=default when path belongs to another pool (bz 1692489)
|
|
From: Cole Robinson crobinso@redhat.com Tue Mar 26 10:44:58 2019 -0400
|
|
Date: Tue Mar 26 11:15:46 2019 -0400:
|
|
Git: a0ca387aad0fde19683aa8b5b5636add6455b8b4
|
|
|
|
Using 'virt-install --disk size=X' implicitly uses pool=default. If
|
|
a pool named 'default' exists we use that; if not, and a pool using
|
|
the default path exists under a different name, we attempt to use
|
|
that as well, and if that doesn't exist, we create pool=default
|
|
|
|
The second case is broken, so if there's no pool=default and eg.
|
|
pool=FOO points to /var/lib/libvirt/images, we still attempt to
|
|
look up pool=default which understandably fails
|
|
|
|
https://bugzilla.redhat.com/show_bug.cgi?id=1692489
|
|
|
|
Index: virt-manager-2.1.0/virtinst/cli.py
|
|
===================================================================
|
|
--- virt-manager-2.1.0.orig/virtinst/cli.py
|
|
+++ virt-manager-2.1.0/virtinst/cli.py
|
|
@@ -2271,7 +2271,9 @@ class ParserDisk(VirtCLIParser):
|
|
poolobj = None
|
|
if poolname:
|
|
if poolname == "default":
|
|
- StoragePool.build_default_pool(self.guest.conn)
|
|
+ poolxml = StoragePool.build_default_pool(self.guest.conn)
|
|
+ if poolxml:
|
|
+ poolname = poolxml.name
|
|
poolobj = self.guest.conn.storagePoolLookupByName(poolname)
|
|
|
|
if volname:
|