2677655bda
001-adf30349-cli-refactor-get_prop.patch 002-60c7e778-xmlapi-add-set_prop.patch 003-5bad22e8-tests-Use-get-set_prop.patch 004-ee5f3eab-support-Add-SUPPORT_CONN_DEVICE_BOOT_ORDER.patch 005-7768eb17-cli-Add-check-if-device-boot-order-is-supported.patch 006-ecc0861c-tests-xmlparse-refactor-method-for-generating-out-file-path.patch 007-c9d070da-guest-Add-reorder_boot_order-method.patch 008-1b535940-tests-Add-test-case-for-reorder_boot_order-method.patch 009-b83a0a61-cli-Use-reorder_boot_order-for-setting-the-boot-order.patch 010-c896d19d-tests-cli-Add-boot.order-tests.patch 011-29f9f2ac-virt-xml-Add-no-define-argument.patch 012-c2bff509-tests-cli-Add-test-case-for-no-define-argument.patch 013-90b1a3ab-virt-xml-Add-support-for-starting-the-domain.patch 014-908b8e8d-tests-virt-xml-Add-test-cases-for-start-option.patch OBS-URL: https://build.opensuse.org/package/show/Virtualization/virt-manager?expand=0&rev=468
44 lines
1.7 KiB
Diff
44 lines
1.7 KiB
Diff
Subject: guest: Add VirtIO input devices to s390x guests with graphics
|
|
From: Andrea Bolognani abologna@redhat.com Wed Mar 20 16:52:35 2019 +0100
|
|
Date: Thu Mar 21 15:31:20 2019 +0100:
|
|
Git: f23b01be53aa8b5b8d91aadbfb0c06268fa5c7b9
|
|
|
|
We're not including any input devices in the generated XML
|
|
for s390x guests, and the results is that it's not possible
|
|
to interact with them short of using the serial console or
|
|
connecting through ssh, which is fine but probably not what
|
|
is expected when graphics are present.
|
|
|
|
USB input devices are not a good fit for s390x guests: USB
|
|
requires PCI, and PCI is not widely available or used on
|
|
s390x; VirtIO devices, on the other hand, are a perfect
|
|
match since s390x guests use basically no emulated devices
|
|
and rely on VirtIO for most functionality.
|
|
|
|
https://bugzilla.redhat.com/show_bug.cgi?id=1683609
|
|
|
|
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
|
|
|
|
Index: virt-manager-2.1.0/virtinst/guest.py
|
|
===================================================================
|
|
--- virt-manager-2.1.0.orig/virtinst/guest.py
|
|
+++ virt-manager-2.1.0/virtinst/guest.py
|
|
@@ -622,6 +622,17 @@ class Guest(XMLBuilder):
|
|
dev.bus = "usb"
|
|
self.add_device(dev)
|
|
|
|
+ # s390x guests need VirtIO input devices
|
|
+ if self.os.is_s390x() and self.osinfo.supports_virtioinput():
|
|
+ dev = DeviceInput(self.conn)
|
|
+ dev.type = "tablet"
|
|
+ dev.bus = "virtio"
|
|
+ self.add_device(dev)
|
|
+ dev = DeviceInput(self.conn)
|
|
+ dev.type = "keyboard"
|
|
+ dev.bus = "virtio"
|
|
+ self.add_device(dev)
|
|
+
|
|
def _add_default_console_device(self):
|
|
if self.skip_default_console:
|
|
return
|