virt-manager/virtinst-nfs-install-sanitize.patch
Charles Arnold 544164a095 - Update to virt-manager 1.4.1
virt-manager-1.4.1.tar.bz2
  * storage/nodedev event API support (Jovanka Gulicoska)
  * UI options for enabling spice GL (Marc-André Lureau)
  * Add default virtio-rng /dev/urandom for supported guest OS
  * Cloning and rename support for UEFI VMs (Pavel Hrdina)
  * libguestfs inspection UI improvements (Pino Toscano)
  * virt-install: Add –qemu-commandline
  * virt-install: Add –network vhostuser (Chen Hanxiao)
  * virt-install: Add –sysinfo (Charles Arnold)
- Dropped the following patches contained in new tarball
  0425975f-use-virDomainMigrate3-API.patch
  0910c8dc-black-display-if-graphic-mode-vnc-and-listen-type-none.patch
  1d2cd306-Fix-incorrect-usage-of-virtio-input.patch
  2df8dc39-detect-whether-IP-address-comes-from-DHCP-server.patch
  559e813b-xmlbuilder-02.patch
  561f5cd3-drop-xenmigr-scheme-from-Xen-migration-URI.patch
  5a11cf07-virt-manager-generates-invalid-guest-XML.patch
  617b9271-dont-return-virtio1.0-net-as-valid-device-name.patch
  63784f4d-document-new-sysinfo-option.patch
  6daff68a-fix-italian-lang-file.patch
  7962672c-fix-error-checking-extra_args.patch
  835ddc5f-xmlbuilder-04.patch
  a3206f89-Add-the-sysinfo-option.patch
  a931a1a6-xmlbuilder-03.patch
  b08647c2-xmlbuilder-05.patch
  b31c0b44-Add-classes-for-defining-SMBios-information.patch
  b4858842-fix-bad-version-check-regression.patch
  b8dccf6a-fix-connection-to-remote-spice-with-password.patch
  c5ce0ab5-connection-fix-transport-detection.patch

OBS-URL: https://build.opensuse.org/package/show/Virtualization/virt-manager?expand=0&rev=341
2017-03-09 19:10:48 +00:00

70 lines
2.7 KiB
Diff

Reference: bnc#888251
A fix for accessing nfs mounted media. A comment in the code states,
"Convert RFC compliant NFS nfs://server/path/to/distro
to what mount/anaconda expect nfs:server:/path/to/distro
and carry the latter form around internally"
We need the RFC version to work correctly whereas redhat's anaconda
needs their own modified version.
Index: virt-manager-1.4.1/virtinst/util.py
===================================================================
--- virt-manager-1.4.1.orig/virtinst/util.py
+++ virt-manager-1.4.1/virtinst/util.py
@@ -444,3 +444,22 @@ def getInstallRepos(enabled_sources_only
return (index_dom0, zypper_output)
+def sanitize_url(url):
+ """
+ Do nothing for http or ftp, but make sure nfs is in the expected format
+ """
+ if url.startswith("nfs://"):
+ # Convert RFC compliant NFS nfs://server/path/to/distro
+ # to what mount/anaconda expect nfs:server:/path/to/distro
+ # and carry the latter form around internally
+ url = "nfs:" + url[6:]
+
+ # If we need to add the : after the server
+ index = url.find("/", 4)
+ if index == -1:
+ raise ValueError(_("Invalid NFS format: No path specified."))
+ if url[index - 1] != ":":
+ url = url[:index] + ":" + url[index:]
+
+ return url
+
Index: virt-manager-1.4.1/virtinst/distroinstaller.py
===================================================================
--- virt-manager-1.4.1.orig/virtinst/distroinstaller.py
+++ virt-manager-1.4.1/virtinst/distroinstaller.py
@@ -44,6 +44,8 @@ def _sanitize_url(url):
"""
Do nothing for http or ftp, but make sure nfs is in the expected format
"""
+ # This sanitize will be done later
+ return url
if url.startswith("nfs://"):
# Convert RFC compliant NFS nfs://server/path/to/distro
# to what mount/anaconda expect nfs:server:/path/to/distro
Index: virt-manager-1.4.1/virtinst/urlfetcher.py
===================================================================
--- virt-manager-1.4.1.orig/virtinst/urlfetcher.py
+++ virt-manager-1.4.1/virtinst/urlfetcher.py
@@ -34,6 +34,7 @@ import urlparse
import requests
from .osdict import OSDB
+from virtinst import util
#########################################################################
@@ -301,7 +302,8 @@ class _MountedURLFetcher(_LocalURLFetche
logging.debug("Preparing mount at " + self._srcdir)
if self.location.startswith("nfs:"):
- cmd = [mountcmd, "-o", "ro", self.location[4:], self._srcdir]
+ url = util.sanitize_url(self.location)
+ cmd = [mountcmd, "-o", "ro", url[4:], self._srcdir]
else:
if stat.S_ISBLK(os.stat(self.location)[stat.ST_MODE]):
mountopt = "ro"