From 29b83096338a1bf87a9b1eb373aa1a00065662cba5af806cfbce74b9454b7554 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Klaus=20K=C3=A4mpf?= Date: Wed, 29 Jun 2016 07:52:52 +0000 Subject: [PATCH] Accepting request 405378 from home:jengelh:branches:Emulators - Resolve rpmlint warnings OBS-URL: https://build.opensuse.org/request/show/405378 OBS-URL: https://build.opensuse.org/package/show/Emulators/wine?expand=0&rev=361 --- wine.changes | 8 ++++++++ wine.spec | 32 ++++++++++++++++++-------------- 2 files changed, 26 insertions(+), 14 deletions(-) diff --git a/wine.changes b/wine.changes index baeb640..3260050 100644 --- a/wine.changes +++ b/wine.changes @@ -1,3 +1,11 @@ +------------------------------------------------------------------- +Tue Jun 28 19:42:07 UTC 2016 - jengelh@inai.de + +- Resolve rpmlint warnings: summary-not-capitalized, + spurious-executable-perm, devel-package-with-non-devel-group. +- Rework description not to talk of the program as an emulator. + Use path-invariant download URLs. + ------------------------------------------------------------------- Fri Jun 24 13:42:30 UTC 2016 - meissner@suse.com diff --git a/wine.spec b/wine.spec index 143a5e8..f6e3dfe 100644 --- a/wine.spec +++ b/wine.spec @@ -60,9 +60,9 @@ Summary: An MS Windows Emulator License: LGPL-2.1+ Group: System/Emulators/PC Url: http://www.winehq.org/ -Source0: http://downloads.sourceforge.net/project/wine/Source/wine-%{realver}.tar.bz2 +Source0: http://downloads.sourceforge.net/wine/wine-%{realver}.tar.bz2 Source41: wine.keyring -Source42: http://downloads.sourceforge.net/project/wine/Source//%{name}-%{realver}.tar.bz2.sign +Source42: http://downloads.sourceforge.net/wine/%{name}-%{realver}.tar.bz2.sign Source1: https://raw.githubusercontent.com/Winetricks/winetricks/master/src/winetricks Source11: https://raw.githubusercontent.com/Winetricks/winetricks/master/src/winetricks.1 Source2: http://kegel.com/wine/wisotool @@ -93,12 +93,16 @@ BuildRoot: %{_tmppath}/%{name}-%{version}-build ExclusiveArch: %{ix86} x86_64 ppc %arm %description -An MS Windows emulator, consisting of both runtime and source -compatibility functions. You can run your MS executables with it and -write your Windows programs under Linux and link against the WINE -libraries. +Wine is a compatibility layer capable of running Windows +applications. Instead of simulating internal Windows logic like a +virtual machine or emulator, Wine translates Windows API calls into +POSIX calls on-the-fly, eliminating the performance and memory +penalties of other methods and allowing you to cleanly integrate +Windows applications into your desktop. -It is not necessary to have a Windows installation to run WINE. +You can run your Windows executables with it and write your Windows +programs under Linux and link against the WINE libraries. It is not +necessary to have a Windows installation to run WINE. Refer to %{_datadir}/doc/packages/wine/README.SUSE. There is more documentation available in that directory. Read 'man wine' for further @@ -109,8 +113,8 @@ running 'winecfg'. %package devel -Summary: files for wine development -Group: System/Emulators/PC +Summary: Files for Wine development +Group: Development/Libraries/C and C++ %description devel This RPM contains the header files and development tools for the WINE @@ -118,7 +122,7 @@ libraries. %prep %setup -q -n wine-%{realver} -#%patch0 -p1 +#%%patch0 -p1 # cp %{S:3} . # @@ -126,7 +130,7 @@ cp %{S:3} . %build cat VERSION %ifarch %ix86 -# e.g. Steam and other copy protections hate removed %ebp. +# e.g. Steam and other copy protections hate EBP being used for something else. export RPM_OPT_FLAGS=`echo $RPM_OPT_FLAGS|sed -e 's/-fomit-frame-pointer//'` %endif @@ -177,9 +181,9 @@ mv %{buildroot}/%{_mandir}/fr.UTF-8 %{buildroot}/%{_mandir}/fr %ifnarch x86_64 mv %{buildroot}/%{_mandir}/pl.UTF-8 %{buildroot}/%{_mandir}/pl %endif -install -c %{SOURCE11} %{buildroot}/%{_mandir}/man1/ +install -pm0644 -c %{SOURCE11} %{buildroot}/%{_mandir}/man1/ -tar xjf %{SOURCE5} +tar -xjf %{SOURCE5} # Copied from Ubuntu Wine out of debian.diff # https://launchpad.net/~ubuntu-wine/+archive/ppa/+packages # taken on 1.2rc2 time. @@ -227,7 +231,7 @@ chmod 755 %winedir/my-find-requires.sh %define __find_requires %winedir/my-find-requires.sh # breaks btrfs installation, see bnc#723402 -# %fdupes -s %{buildroot} +# %%fdupes -s %{buildroot} %post -p /sbin/ldconfig %postun -p /sbin/ldconfig