24 lines
852 B
Diff
24 lines
852 B
Diff
|
# Commit c7d5d5d8ea1ecbd6ef8b47dace4dec825f0f6e48
|
||
|
|
# Date 2015-09-16 11:20:27 +0200
|
||
|
|
# Author Jan Beulich <jbeulich@suse.com>
|
||
|
|
# Committer Jan Beulich <jbeulich@suse.com>
|
||
|
|
x86/MSI: fail if no hardware support
|
||
|
|
|
||
|
|
This is to guard against buggy callers (luckily Dom0 only) invoking
|
||
|
|
the respective hypercall for a device not being MSI-capable.
|
||
|
|
|
||
|
|
Signed-off-by: Jan Beulich <jbeulich@suse.com>
|
||
|
|
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
|
||
|
|
|
||
|
|
--- a/xen/arch/x86/msi.c
|
||
|
|
+++ b/xen/arch/x86/msi.c
|
||
|
|
@@ -566,6 +566,8 @@ static int msi_capability_init(struct pc
|
||
|
|
|
||
|
|
ASSERT(spin_is_locked(&pcidevs_lock));
|
||
|
|
pos = pci_find_cap_offset(seg, bus, slot, func, PCI_CAP_ID_MSI);
|
||
|
|
+ if ( !pos )
|
||
|
|
+ return -ENODEV;
|
||
|
|
control = pci_conf_read16(seg, bus, slot, func, msi_control_reg(pos));
|
||
|
|
maxvec = multi_msi_capable(control);
|
||
|
|
if ( nvec > maxvec )
|