42 lines
1.3 KiB
Diff
42 lines
1.3 KiB
Diff
|
# Commit 546ba2f17008387cf9821df46e6dac04f0883a9b
|
||
|
|
# Date 2013-09-10 17:16:02 +0200
|
||
|
|
# Author Matthew Daley <mattjd@gmail.com>
|
||
|
|
# Committer Jan Beulich <jbeulich@suse.com>
|
||
|
|
sched/arinc653: check for guest data transfer failures
|
||
|
|
|
||
|
|
Coverity-ID: 1055121
|
||
|
|
Coverity-ID: 1055122
|
||
|
|
Coverity-ID: 1055123
|
||
|
|
Coverity-ID: 1055124
|
||
|
|
Signed-off-by: Matthew Daley <mattjd@gmail.com>
|
||
|
|
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
|
||
|
|
Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
|
||
|
|
Acked-by: Keir Fraser <keir@xen.org>
|
||
|
|
|
||
|
|
--- a/xen/common/sched_arinc653.c
|
||
|
|
+++ b/xen/common/sched_arinc653.c
|
||
|
|
@@ -635,12 +635,21 @@ a653sched_adjust_global(const struct sch
|
||
|
|
switch ( sc->cmd )
|
||
|
|
{
|
||
|
|
case XEN_SYSCTL_SCHEDOP_putinfo:
|
||
|
|
- copy_from_guest(&local_sched, sc->u.sched_arinc653.schedule, 1);
|
||
|
|
+ if ( copy_from_guest(&local_sched, sc->u.sched_arinc653.schedule, 1) )
|
||
|
|
+ {
|
||
|
|
+ rc = -EFAULT;
|
||
|
|
+ break;
|
||
|
|
+ }
|
||
|
|
+
|
||
|
|
rc = arinc653_sched_set(ops, &local_sched);
|
||
|
|
break;
|
||
|
|
case XEN_SYSCTL_SCHEDOP_getinfo:
|
||
|
|
rc = arinc653_sched_get(ops, &local_sched);
|
||
|
|
- copy_to_guest(sc->u.sched_arinc653.schedule, &local_sched, 1);
|
||
|
|
+ if ( rc )
|
||
|
|
+ break;
|
||
|
|
+
|
||
|
|
+ if ( copy_to_guest(sc->u.sched_arinc653.schedule, &local_sched, 1) )
|
||
|
|
+ rc = -EFAULT;
|
||
|
|
break;
|
||
|
|
}
|
||
|
|
|