2015-08-27 00:28:15 +02:00
|
|
|
References: bsc#907514 bsc#910258 bsc#918984 bsc#923967
|
|
|
|
|
|
|
|
# Commit 484d7c852e4ff79c945406ed28b5db63a5a0b7f3
|
|
|
|
# Date 2015-07-23 10:14:13 +0200
|
|
|
|
# Author Jan Beulich <jbeulich@suse.com>
|
|
|
|
# Committer Jan Beulich <jbeulich@suse.com>
|
2015-07-10 17:21:29 +02:00
|
|
|
x86/MSI-X: track host and guest mask-all requests separately
|
2015-06-30 16:23:29 +02:00
|
|
|
|
2015-07-10 17:21:29 +02:00
|
|
|
Host uses of the bits will be added subsequently, and must not be
|
|
|
|
overridden by guests (including Dom0, namely when acting on behalf of
|
|
|
|
a guest).
|
2015-06-30 16:23:29 +02:00
|
|
|
|
|
|
|
Signed-off-by: Jan Beulich <jbeulich@suse.com>
|
2015-07-10 17:21:29 +02:00
|
|
|
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
|
2015-06-30 16:23:29 +02:00
|
|
|
|
2015-11-04 21:30:31 +01:00
|
|
|
Index: xen-4.5.2-testing/xen/arch/x86/msi.c
|
|
|
|
===================================================================
|
|
|
|
--- xen-4.5.2-testing.orig/xen/arch/x86/msi.c
|
|
|
|
+++ xen-4.5.2-testing/xen/arch/x86/msi.c
|
|
|
|
@@ -845,6 +845,12 @@ static int msix_capability_init(struct p
|
2015-06-30 16:23:29 +02:00
|
|
|
|
|
|
|
if ( !msix->used_entries )
|
|
|
|
{
|
2015-07-10 17:21:29 +02:00
|
|
|
+ msix->host_maskall = 0;
|
|
|
|
+ if ( !msix->guest_maskall )
|
|
|
|
+ control &= ~PCI_MSIX_FLAGS_MASKALL;
|
|
|
|
+ else
|
|
|
|
+ control |= PCI_MSIX_FLAGS_MASKALL;
|
2015-06-30 16:23:29 +02:00
|
|
|
+
|
|
|
|
if ( rangeset_add_range(mmio_ro_ranges, msix->table.first,
|
|
|
|
msix->table.last) )
|
|
|
|
WARN();
|
2015-11-04 21:30:31 +01:00
|
|
|
@@ -1113,6 +1119,34 @@ void pci_cleanup_msi(struct pci_dev *pde
|
2015-07-10 17:21:29 +02:00
|
|
|
int pci_msi_conf_write_intercept(struct pci_dev *pdev, unsigned int reg,
|
|
|
|
unsigned int size, uint32_t *data)
|
|
|
|
{
|
|
|
|
+ u16 seg = pdev->seg;
|
|
|
|
+ u8 bus = pdev->bus;
|
|
|
|
+ u8 slot = PCI_SLOT(pdev->devfn);
|
|
|
|
+ u8 func = PCI_FUNC(pdev->devfn);
|
|
|
|
+ struct msi_desc *entry;
|
|
|
|
+ unsigned int pos;
|
|
|
|
+
|
|
|
|
+ if ( pdev->msix )
|
2015-06-30 16:23:29 +02:00
|
|
|
+ {
|
2015-07-10 17:21:29 +02:00
|
|
|
+ entry = find_msi_entry(pdev, -1, PCI_CAP_ID_MSIX);
|
|
|
|
+ pos = entry ? entry->msi_attrib.pos
|
|
|
|
+ : pci_find_cap_offset(seg, bus, slot, func,
|
|
|
|
+ PCI_CAP_ID_MSIX);
|
|
|
|
+ ASSERT(pos);
|
2015-06-30 16:23:29 +02:00
|
|
|
+
|
2015-07-10 17:21:29 +02:00
|
|
|
+ if ( reg < pos || reg >= msix_pba_offset_reg(pos) + 4 )
|
|
|
|
+ return 0;
|
2015-06-30 16:23:29 +02:00
|
|
|
+
|
2015-07-10 17:21:29 +02:00
|
|
|
+ if ( reg != msix_control_reg(pos) || size != 2 )
|
|
|
|
+ return -EACCES;
|
2015-06-30 16:23:29 +02:00
|
|
|
+
|
2015-07-10 17:21:29 +02:00
|
|
|
+ pdev->msix->guest_maskall = !!(*data & PCI_MSIX_FLAGS_MASKALL);
|
|
|
|
+ if ( pdev->msix->host_maskall )
|
|
|
|
+ *data |= PCI_MSIX_FLAGS_MASKALL;
|
2015-06-30 16:23:29 +02:00
|
|
|
+
|
2015-07-10 17:21:29 +02:00
|
|
|
+ return 1;
|
2015-06-30 16:23:29 +02:00
|
|
|
+ }
|
|
|
|
+
|
2015-07-10 17:21:29 +02:00
|
|
|
return 0;
|
|
|
|
}
|
2015-06-30 16:23:29 +02:00
|
|
|
|
2015-11-04 21:30:31 +01:00
|
|
|
Index: xen-4.5.2-testing/xen/include/asm-x86/msi.h
|
|
|
|
===================================================================
|
|
|
|
--- xen-4.5.2-testing.orig/xen/include/asm-x86/msi.h
|
|
|
|
+++ xen-4.5.2-testing/xen/include/asm-x86/msi.h
|
2015-07-10 17:21:29 +02:00
|
|
|
@@ -228,6 +228,7 @@ struct arch_msix {
|
2015-06-30 16:23:29 +02:00
|
|
|
int table_refcnt[MAX_MSIX_TABLE_PAGES];
|
|
|
|
int table_idx[MAX_MSIX_TABLE_PAGES];
|
|
|
|
spinlock_t table_lock;
|
|
|
|
+ bool_t host_maskall, guest_maskall;
|
|
|
|
domid_t warned;
|
|
|
|
};
|
|
|
|
|