36 lines
1.3 KiB
Diff
36 lines
1.3 KiB
Diff
|
changeset: 23906:7bf85c3fd9f0
|
||
|
user: Olaf Hering <olaf@aepfle.de>
|
||
|
date: Thu Oct 06 12:33:17 2011 +0100
|
||
|
files: xen/arch/x86/mm/p2m.c
|
||
|
description:
|
||
|
xenpaging: remove confusing comment from p2m_mem_paging_populate
|
||
|
|
||
|
Currently there is no way to avoid the double check of the p2mt
|
||
|
because p2m_mem_paging_populate() is called from many places without
|
||
|
the p2m_lock held. Upcoming changes will move the function into
|
||
|
gfn_to_mfn(), so its interface could be changed and the extra
|
||
|
p2m_lock/get_entry can be removed.
|
||
|
|
||
|
Signed-off-by: Olaf Hering <olaf@aepfle.de>
|
||
|
Acked-by: Tim Deegan <tim@xen.org>
|
||
|
Committed-by: Tim Deegan <tim@xen.org>
|
||
|
|
||
|
|
||
|
---
|
||
|
xen/arch/x86/mm/p2m.c | 2 --
|
||
|
1 file changed, 2 deletions(-)
|
||
|
|
||
|
Index: xen-4.1.2-testing/xen/arch/x86/mm/p2m.c
|
||
|
===================================================================
|
||
|
--- xen-4.1.2-testing.orig/xen/arch/x86/mm/p2m.c
|
||
|
+++ xen-4.1.2-testing/xen/arch/x86/mm/p2m.c
|
||
|
@@ -2961,8 +2961,6 @@ void p2m_mem_paging_populate(struct p2m_
|
||
|
req.type = MEM_EVENT_TYPE_PAGING;
|
||
|
|
||
|
/* Fix p2m mapping */
|
||
|
- /* XXX: It seems inefficient to have this here, as it's only needed
|
||
|
- * in one case (ept guest accessing paging out page) */
|
||
|
p2m_lock(p2m);
|
||
|
p2m->get_entry(p2m, gfn, &p2mt, &a, p2m_query);
|
||
|
if ( p2mt == p2m_ram_paged )
|