2010-01-16 01:12:54 +01:00
Index: xen-4.0.0-testing/tools/ioemu-remote/hw/xen_blktap.c
2009-08-01 11:53:46 +02:00
===================================================================
2010-01-16 01:12:54 +01:00
--- xen-4.0.0-testing.orig/tools/ioemu-remote/hw/xen_blktap.c
+++ xen-4.0.0-testing/tools/ioemu-remote/hw/xen_blktap.c
@@ -225,6 +225,7 @@ static int open_disk(struct td_state *s,
2009-06-12 20:43:24 +02:00
BlockDriver* drv;
char* devname;
static int devnumber = 0;
+ int flags = readonly ? BDRV_O_RDONLY : BDRV_O_RDWR;
int i;
DPRINTF("Opening %s as blktap%d\n", path, devnumber);
2010-01-16 01:12:54 +01:00
@@ -247,7 +248,7 @@ static int open_disk(struct td_state *s,
2009-06-12 20:43:24 +02:00
DPRINTF("%s driver specified\n", drv ? drv->format_name : "No");
/* Open the image */
- if (bdrv_open2(bs, path, 0, drv) != 0) {
+ if (bdrv_open2(bs, path, flags, drv) != 0) {
fprintf(stderr, "Could not open image file %s\n", path);
return -ENOMEM;
}
2010-01-16 01:12:54 +01:00
Index: xen-4.0.0-testing/tools/ioemu-remote/xenstore.c
2009-08-01 11:53:46 +02:00
===================================================================
2010-01-16 01:12:54 +01:00
--- xen-4.0.0-testing.orig/tools/ioemu-remote/xenstore.c
+++ xen-4.0.0-testing/tools/ioemu-remote/xenstore.c
@@ -133,7 +133,8 @@ static void insert_media(void *opaque)
else
format = &bdrv_raw;
- bdrv_open2(bs, media_filename[i], 0, format);
2009-06-12 20:43:24 +02:00
+ /* Temporary BDRV_O_RDWR */
2010-01-16 01:12:54 +01:00
+ bdrv_open2(bs, media_filename[i], BDRV_O_RDWR, format);
#ifdef CONFIG_STUBDOM
{
char *buf, *backend, *params_path, *params;
@@ -397,9 +398,9 @@ void xenstore_parse_domain_config(int hv
2009-06-12 20:43:24 +02:00
{
char **e_danger = NULL;
char *buf = NULL;
- char *fpath = NULL, *bpath = NULL, *btype = NULL,
+ char *fpath = NULL, *bpath = NULL, *btype = NULL, *mode = NULL,
*dev = NULL, *params = NULL, *drv = NULL;
2010-01-16 01:12:54 +01:00
- int i, j, ret, is_tap;
+ int i, j, ret, is_tap, flags;
2009-06-12 20:43:24 +02:00
unsigned int len, num, hd_index, pci_devid = 0;
BlockDriverState *bs;
BlockDriver *format;
2010-01-16 01:12:54 +01:00
@@ -461,7 +462,8 @@ void xenstore_parse_domain_config(int hv
2009-06-12 20:43:24 +02:00
}
for (i = 0; i < num; i++) {
- format = NULL; /* don't know what the format is yet */
2010-01-16 01:12:54 +01:00
+ flags = 0;
2009-06-12 20:43:24 +02:00
+ format = NULL; /* don't know what the format is yet */
/* read the backend path */
xenstore_get_backend_path(&bpath, "vbd", danger_path, hvm_domid, e_danger[i]);
if (bpath == NULL)
2010-01-16 01:12:54 +01:00
@@ -560,6 +562,17 @@ void xenstore_parse_domain_config(int hv
}
2009-06-12 20:43:24 +02:00
}
+ /* read the mode of the device */
+ if (pasprintf(&buf, "%s/mode", bpath) == -1)
+ continue;
+ free(mode);
+ mode = xs_read(xsh, XBT_NULL, buf, &len);
+
+ if (!strcmp(mode, "r") || !strcmp(mode, "ro"))
+ flags |= BDRV_O_RDONLY;
+ if (!strcmp(mode, "w") || !strcmp(mode, "rw"))
+ flags |= BDRV_O_RDWR;
+
#if 0
/* Phantom VBDs are disabled because the use of paths
* from guest-controlled areas in xenstore is unsafe.
2010-01-16 01:12:54 +01:00
@@ -612,7 +625,7 @@ void xenstore_parse_domain_config(int hv
2009-06-12 20:43:24 +02:00
#ifdef CONFIG_STUBDOM
if (pasprintf(&danger_buf, "%s/device/vbd/%s", danger_path, e_danger[i]) == -1)
continue;
- if (bdrv_open2(bs, danger_buf, BDRV_O_CACHE_WB /* snapshot and write-back */, &bdrv_raw) == 0) {
+ if (bdrv_open2(bs, danger_buf, flags|BDRV_O_CACHE_WB /* snapshot and write-back */, &bdrv_raw) == 0) {
pstrcpy(bs->filename, sizeof(bs->filename), params);
2010-01-16 01:12:54 +01:00
}
#else
@@ -641,7 +654,7 @@ void xenstore_parse_domain_config(int hv
2009-06-12 20:43:24 +02:00
}
}
pstrcpy(bs->filename, sizeof(bs->filename), params);
2010-01-16 01:12:54 +01:00
- if (bdrv_open2(bs, params, BDRV_O_CACHE_WB /* snapshot and write-back */, format) < 0)
+ if (bdrv_open2(bs, params, flags|BDRV_O_CACHE_WB /* snapshot and write-back */, format) < 0)
2009-06-12 20:43:24 +02:00
fprintf(stderr, "qemu: could not open vbd '%s' or hard disk image '%s' (drv '%s' format '%s')\n", buf, params, drv ? drv : "?", format ? format->format_name : "0");
2010-01-16 01:12:54 +01:00
}