# HG changeset patch # User Keir Fraser # Date 1276604463 -3600 # Node ID b0f7f710f512aba0fca814467e4f5fe7b906ada3 # Parent 972b7e305138759d4ef42b75d5fe5c6fd2d2e30c x86: return value of domain_pirq_to_irq() is signed That value can, for forcibly unbound PIRQs, validly be negative, and for the respective check to catch those cases (and prevent using these negative values as array index), the respective variables must be of signed type. Signed-off-by: Jan Beulich --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -879,7 +879,7 @@ static void __do_IRQ_guest(int irq) struct irq_desc *domain_spin_lock_irq_desc( struct domain *d, int pirq, unsigned long *pflags) { - unsigned int irq; + int irq; unsigned long flags; struct irq_desc *desc; @@ -1046,7 +1046,7 @@ extern int ioapic_ack_new; static int pirq_acktype(struct domain *d, int pirq) { struct irq_desc *desc; - unsigned int irq; + int irq; irq = domain_pirq_to_irq(d, pirq); if ( irq <= 0 )