8292994238
logging upon guest changing callback method (XSA-169) 5677f350-x86-make-debug-output-consistent-in-hvm_set_callback_via.patch - bsc#959387 - VUL-0: CVE-2015-8568 CVE-2015-8567: xen: qemu: net: vmxnet3: host memory leakage CVE-2015-8568-qemuu-net-vmxnet3-avoid-memory-leakage-in-activate_device.patch - bsc#957988 - VUL-0: CVE-2015-8550: xen: paravirtualized drivers incautious about shared memory contents (XSA-155) xsa155-xen-0001-xen-Add-RING_COPY_REQUEST.patch xsa155-xen-0002-blktap2-Use-RING_COPY_REQUEST.patch xsa155-xen-0003-libvchan-Read-prod-cons-only-once.patch xsa155-qemuu-qdisk-double-access.patch xsa155-qemut-qdisk-double-access.patch xsa155-qemuu-xenfb.patch xsa155-qemut-xenfb.patch - bsc#959006 - VUL-0: CVE-2015-8558: xen: qemu: usb: infinite loop in ehci_advance_state results in DoS CVE-2015-8558-qemuu-usb-infinite-loop-in-ehci_advance_state-results-in-DoS.patch - bsc#958918 - VUL-0: CVE-2015-7549: xen: qemu pci: null pointer dereference issue CVE-2015-7549-qemuu-pci-null-pointer-dereference-issue.patch - bsc#958493 - VUL-0: CVE-2015-8504: xen: qemu: ui: vnc: avoid floating point exception CVE-2015-8504-qemuu-vnc-avoid-floating-point-exception.patch CVE-2015-8504-qemut-vnc-avoid-floating-point-exception.patch - bsc#958007 - VUL-0: CVE-2015-8554: xen: qemu-dm buffer overrun in MSI-X handling (XSA-164) xsa164.patch OBS-URL: https://build.opensuse.org/package/show/Virtualization/xen?expand=0&rev=393
90 lines
3.0 KiB
Diff
90 lines
3.0 KiB
Diff
References: bsc#959386 CVE-2015-8568
|
|
|
|
From 3ef66b01874fcc2fe3bfc73d2b61ee3a5b29fdb6 Mon Sep 17 00:00:00 2001
|
|
From: Prasad J Pandit <address@hidden>
|
|
Date: Tue, 15 Dec 2015 12:17:28 +0530
|
|
Subject: [PATCH] net: vmxnet3: avoid memory leakage in activate_device
|
|
|
|
Vmxnet3 device emulator does not check if the device is active
|
|
before activating it, also it did not free the transmit & receive
|
|
buffers while deactivating the device, thus resulting in memory
|
|
leakage on the host. This patch fixes both these issues to avoid
|
|
host memory leakage.
|
|
|
|
Reported-by: Qinghao Tang <address@hidden>
|
|
Signed-off-by: Prasad J Pandit <address@hidden>
|
|
---
|
|
hw/net/vmxnet3.c | 24 ++++++++++++++++--------
|
|
1 file changed, 16 insertions(+), 8 deletions(-)
|
|
|
|
Index: xen-4.6.0-testing/tools/qemu-xen-dir-remote/hw/net/vmxnet3.c
|
|
===================================================================
|
|
--- xen-4.6.0-testing.orig/tools/qemu-xen-dir-remote/hw/net/vmxnet3.c
|
|
+++ xen-4.6.0-testing/tools/qemu-xen-dir-remote/hw/net/vmxnet3.c
|
|
@@ -1135,8 +1135,13 @@ static void vmxnet3_reset_mac(VMXNET3Sta
|
|
|
|
static void vmxnet3_deactivate_device(VMXNET3State *s)
|
|
{
|
|
- VMW_CBPRN("Deactivating vmxnet3...");
|
|
- s->device_active = false;
|
|
+ if (s->device_active) {
|
|
+ VMW_CBPRN("Deactivating vmxnet3...");
|
|
+ vmxnet_tx_pkt_reset(s->tx_pkt);
|
|
+ vmxnet_tx_pkt_uninit(s->tx_pkt);
|
|
+ vmxnet_rx_pkt_uninit(s->rx_pkt);
|
|
+ s->device_active = false;
|
|
+ }
|
|
}
|
|
|
|
static void vmxnet3_reset(VMXNET3State *s)
|
|
@@ -1145,7 +1150,6 @@ static void vmxnet3_reset(VMXNET3State *
|
|
|
|
vmxnet3_deactivate_device(s);
|
|
vmxnet3_reset_interrupt_states(s);
|
|
- vmxnet_tx_pkt_reset(s->tx_pkt);
|
|
s->drv_shmem = 0;
|
|
s->tx_sop = true;
|
|
s->skip_current_tx_pkt = false;
|
|
@@ -1368,6 +1372,12 @@ static void vmxnet3_activate_device(VMXN
|
|
return;
|
|
}
|
|
|
|
+ /* Verify if device is active */
|
|
+ if (s->device_active) {
|
|
+ VMW_CFPRN("Vmxnet3 device is active");
|
|
+ return;
|
|
+ }
|
|
+
|
|
vmxnet3_adjust_by_guest_type(s);
|
|
vmxnet3_update_features(s);
|
|
vmxnet3_update_pm_state(s);
|
|
@@ -1564,7 +1574,7 @@ static void vmxnet3_handle_command(VMXNE
|
|
break;
|
|
|
|
case VMXNET3_CMD_QUIESCE_DEV:
|
|
- VMW_CBPRN("Set: VMXNET3_CMD_QUIESCE_DEV - pause the device");
|
|
+ VMW_CBPRN("Set: VMXNET3_CMD_QUIESCE_DEV - deactivate the device");
|
|
vmxnet3_deactivate_device(s);
|
|
break;
|
|
|
|
@@ -1669,7 +1679,7 @@ vmxnet3_io_bar1_write(void *opaque,
|
|
* shared address only after we get the high part
|
|
*/
|
|
if (val == 0) {
|
|
- s->device_active = false;
|
|
+ vmxnet3_deactivate_device(s);
|
|
}
|
|
s->temp_shared_guest_driver_memory = val;
|
|
s->drv_shmem = 0;
|
|
@@ -1956,9 +1966,7 @@ static bool vmxnet3_peer_has_vnet_hdr(VM
|
|
static void vmxnet3_net_uninit(VMXNET3State *s)
|
|
{
|
|
g_free(s->mcast_list);
|
|
- vmxnet_tx_pkt_reset(s->tx_pkt);
|
|
- vmxnet_tx_pkt_uninit(s->tx_pkt);
|
|
- vmxnet_rx_pkt_uninit(s->rx_pkt);
|
|
+ vmxnet3_deactivate_device(s);
|
|
qemu_del_nic(s->nic);
|
|
}
|
|
|