8724a18868
config handling stack overflow 55a62eb0-xl-correct-handling-of-extra_config-in-main_cpupoolcreate.patch - bsc#907514 - Bus fatal error & sles12 sudden reboot has been observed - bsc#910258 - SLES12 Xen host crashes with FATAL NMI after shutdown of guest with VT-d NIC - bsc#918984 - Bus fatal error & sles11-SP4 sudden reboot has been observed - bsc#923967 - Partner-L3: Bus fatal error & sles11-SP3 sudden reboot has been observed 552d293b-x86-vMSI-X-honor-all-mask-requests.patch 552d2966-x86-vMSI-X-add-valid-bits-for-read-acceleration.patch 5576f143-x86-adjust-PV-I-O-emulation-functions-types.patch 55795a52-x86-vMSI-X-support-qword-MMIO-access.patch 5583d9c5-x86-MSI-X-cleanup.patch 5583da09-x86-MSI-track-host-and-guest-masking-separately.patch 55b0a218-x86-PCI-CFG-write-intercept.patch 55b0a255-x86-MSI-X-maskall.patch 55b0a283-x86-MSI-X-teardown.patch 55b0a2ab-x86-MSI-X-enable.patch 55b0a2db-x86-MSI-track-guest-masking.patch - Upstream patches from Jan 552d0f49-x86-traps-identify-the-vcpu-in-context-when-dumping-regs.patch 559bc633-x86-cpupool-clear-proper-cpu_valid-bit-on-CPU-teardown.patch 559bc64e-credit1-properly-deal-with-CPUs-not-in-any-pool.patch 559bc87f-x86-hvmloader-avoid-data-corruption-with-xenstore-rw.patch 55a66a1e-make-rangeset_report_ranges-report-all-ranges.patch 55a77e4f-dmar-device-scope-mem-leak-fix.patch OBS-URL: https://build.opensuse.org/package/show/Virtualization/xen?expand=0&rev=373
38 lines
1.2 KiB
Diff
38 lines
1.2 KiB
Diff
Subject: xl: correct handling of extra_config in main_cpupoolcreate
|
|
From: Wei Liu wei.liu2@citrix.com Tue Jul 14 17:41:10 2015 +0100
|
|
Date: Wed Jul 15 10:58:08 2015 +0100:
|
|
Git: 705c9e12426cba82804cb578fc70785281655d94
|
|
|
|
Don't dereference extra_config if it's NULL. Don't leak extra_config in
|
|
the end.
|
|
|
|
Also fixed a typo in error string while I was there.
|
|
|
|
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
|
|
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
|
|
|
|
Index: xen-4.5.1-testing/tools/libxl/xl_cmdimpl.c
|
|
===================================================================
|
|
--- xen-4.5.1-testing.orig/tools/libxl/xl_cmdimpl.c
|
|
+++ xen-4.5.1-testing/tools/libxl/xl_cmdimpl.c
|
|
@@ -7085,9 +7085,9 @@ int main_cpupoolcreate(int argc, char **
|
|
else
|
|
config_src="command line";
|
|
|
|
- if (strlen(extra_config)) {
|
|
+ if (extra_config && strlen(extra_config)) {
|
|
if (config_len > INT_MAX - (strlen(extra_config) + 2)) {
|
|
- fprintf(stderr, "Failed to attach extra configration\n");
|
|
+ fprintf(stderr, "Failed to attach extra configuration\n");
|
|
goto out;
|
|
}
|
|
config_data = xrealloc(config_data,
|
|
@@ -7211,6 +7211,7 @@ out_cfg:
|
|
out:
|
|
free(name);
|
|
free(config_data);
|
|
+ free(extra_config);
|
|
return rc;
|
|
}
|
|
|