8724a18868
config handling stack overflow 55a62eb0-xl-correct-handling-of-extra_config-in-main_cpupoolcreate.patch - bsc#907514 - Bus fatal error & sles12 sudden reboot has been observed - bsc#910258 - SLES12 Xen host crashes with FATAL NMI after shutdown of guest with VT-d NIC - bsc#918984 - Bus fatal error & sles11-SP4 sudden reboot has been observed - bsc#923967 - Partner-L3: Bus fatal error & sles11-SP3 sudden reboot has been observed 552d293b-x86-vMSI-X-honor-all-mask-requests.patch 552d2966-x86-vMSI-X-add-valid-bits-for-read-acceleration.patch 5576f143-x86-adjust-PV-I-O-emulation-functions-types.patch 55795a52-x86-vMSI-X-support-qword-MMIO-access.patch 5583d9c5-x86-MSI-X-cleanup.patch 5583da09-x86-MSI-track-host-and-guest-masking-separately.patch 55b0a218-x86-PCI-CFG-write-intercept.patch 55b0a255-x86-MSI-X-maskall.patch 55b0a283-x86-MSI-X-teardown.patch 55b0a2ab-x86-MSI-X-enable.patch 55b0a2db-x86-MSI-track-guest-masking.patch - Upstream patches from Jan 552d0f49-x86-traps-identify-the-vcpu-in-context-when-dumping-regs.patch 559bc633-x86-cpupool-clear-proper-cpu_valid-bit-on-CPU-teardown.patch 559bc64e-credit1-properly-deal-with-CPUs-not-in-any-pool.patch 559bc87f-x86-hvmloader-avoid-data-corruption-with-xenstore-rw.patch 55a66a1e-make-rangeset_report_ranges-report-all-ranges.patch 55a77e4f-dmar-device-scope-mem-leak-fix.patch OBS-URL: https://build.opensuse.org/package/show/Virtualization/xen?expand=0&rev=373
87 lines
3.0 KiB
Diff
87 lines
3.0 KiB
Diff
# Commit 5a9899ddc42040e139233a6b1f0f65f3b65eda6d
|
|
# Date 2015-06-15 13:23:34 +0200
|
|
# Author David Vrabel <david.vrabel@citrix.com>
|
|
# Committer Jan Beulich <jbeulich@suse.com>
|
|
gnttab: introduce maptrack lock
|
|
|
|
Split grant table lock into two separate locks. One to protect
|
|
maptrack free list (maptrack_lock) and one for everything else (lock).
|
|
|
|
Based on a patch originally by Matt Wilson <msw@amazon.com>.
|
|
|
|
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
|
|
Reviewed-by: Jan Beulich <jbeulich@suse.com>
|
|
|
|
--- a/docs/misc/grant-tables.txt
|
|
+++ b/docs/misc/grant-tables.txt
|
|
@@ -87,6 +87,7 @@ is complete.
|
|
inconsistent grant table state such as current
|
|
version, partially initialized active table pages,
|
|
etc.
|
|
+ grant_table->maptrack_lock : spinlock used to protect the maptrack free list
|
|
active_grant_entry->lock : spinlock used to serialize modifications to
|
|
active entries
|
|
|
|
@@ -94,6 +95,9 @@ is complete.
|
|
that access members of struct grant_table must acquire the lock
|
|
around critical sections.
|
|
|
|
+ The maptrack free list is protected by its own spinlock. The maptrack
|
|
+ lock may be locked while holding the grant table lock.
|
|
+
|
|
Active entries are obtained by calling active_entry_acquire(gt, ref).
|
|
This function returns a pointer to the active entry after locking its
|
|
spinlock. The caller must hold the grant table lock for the gt in
|
|
--- a/xen/common/grant_table.c
|
|
+++ b/xen/common/grant_table.c
|
|
@@ -288,10 +288,10 @@ static inline void
|
|
put_maptrack_handle(
|
|
struct grant_table *t, int handle)
|
|
{
|
|
- spin_lock(&t->lock);
|
|
+ spin_lock(&t->maptrack_lock);
|
|
maptrack_entry(t, handle).ref = t->maptrack_head;
|
|
t->maptrack_head = handle;
|
|
- spin_unlock(&t->lock);
|
|
+ spin_unlock(&t->maptrack_lock);
|
|
}
|
|
|
|
static inline int
|
|
@@ -303,7 +303,7 @@ get_maptrack_handle(
|
|
struct grant_mapping *new_mt;
|
|
unsigned int new_mt_limit, nr_frames;
|
|
|
|
- spin_lock(&lgt->lock);
|
|
+ spin_lock(&lgt->maptrack_lock);
|
|
|
|
while ( unlikely((handle = __get_maptrack_handle(lgt)) == -1) )
|
|
{
|
|
@@ -332,7 +332,7 @@ get_maptrack_handle(
|
|
nr_frames + 1);
|
|
}
|
|
|
|
- spin_unlock(&lgt->lock);
|
|
+ spin_unlock(&lgt->maptrack_lock);
|
|
|
|
return handle;
|
|
}
|
|
@@ -2874,6 +2874,7 @@ grant_table_create(
|
|
|
|
/* Simple stuff. */
|
|
spin_lock_init(&t->lock);
|
|
+ spin_lock_init(&t->maptrack_lock);
|
|
t->nr_grant_frames = INITIAL_NR_GRANT_FRAMES;
|
|
|
|
/* Active grant table. */
|
|
--- a/xen/include/xen/grant_table.h
|
|
+++ b/xen/include/xen/grant_table.h
|
|
@@ -82,6 +82,8 @@ struct grant_table {
|
|
struct grant_mapping **maptrack;
|
|
unsigned int maptrack_head;
|
|
unsigned int maptrack_limit;
|
|
+ /* Lock protecting the maptrack page list, head, and limit */
|
|
+ spinlock_t maptrack_lock;
|
|
/* Lock protecting updates to active and shared grant tables. */
|
|
spinlock_t lock;
|
|
/* The defined versions are 1 and 2. Set to 0 if we don't know
|