5c0f7d38a6
reverse-24757-use-grant-references.patch - fate#313222 - xenstore-chmod should support 256 permissions 26189-xenstore-chmod.patch - bnc#789945 - VUL-0: CVE-2012-5510: xen: Grant table version switch list corruption vulnerability (XSA-26) CVE-2012-5510-xsa26.patch - bnc#789944 - VUL-0: CVE-2012-5511: xen: Several HVM operations do not validate the range of their inputs (XSA-27) CVE-2012-5511-xsa27.patch - bnc#789951 - VUL-0: CVE-2012-5513: xen: XENMEM_exchange may overwrite hypervisor memory (XSA-29) CVE-2012-5513-xsa29.patch - bnc#789948 - VUL-0: CVE-2012-5514: xen: Missing unlock in guest_physmap_mark_populate_on_demand() (XSA-30) CVE-2012-5514-xsa30.patch - bnc#789950 - VUL-0: CVE-2012-5515: xen: Several memory hypercall operations allow invalid extent order values (XSA-31) CVE-2012-5515-xsa31.patch - bnc#789952 - VUL-0: CVE-2012-5525: xen: Several hypercalls do not validate input GFNs (XSA-32) CVE-2012-5525-xsa32.patch - Upstream patches from Jan 26129-ACPI-BGRT-invalidate.patch 26132-tmem-save-NULL-check.patch 26134-x86-shadow-invlpg-check.patch 26139-cpumap-masking.patch 26148-vcpu-timer-overflow.patch (Replaces CVE-2012-4535-xsa20.patch) OBS-URL: https://build.opensuse.org/package/show/Virtualization/xen?expand=0&rev=219
40 lines
1.5 KiB
Diff
40 lines
1.5 KiB
Diff
# HG changeset patch
|
|
# User Matthew Daley <mattjd@gmail.com>
|
|
# Date 1352802490 -3600
|
|
# Node ID 56400658f0962099988678487e525d12f869a96a
|
|
# Parent a3cde70320ada4a5424c37f65b8fe3753fc95205
|
|
fix xenctl_cpumap_to_cpumask() buffer size check
|
|
|
|
xenctl_cpumap_to_cpumask incorrectly uses sizeof when checking whether
|
|
bits should be masked off from the input cpumap bitmap or not.
|
|
|
|
Fix by using the correct cpumask buffer size in place of sizeof.
|
|
|
|
Signed-off-by: Matthew Daley <mattjd@gmail.com>
|
|
|
|
Compare against copy_bytes instead, and use equality rather than less-
|
|
or-equal.
|
|
|
|
Further, this issue (introduced with c/s 23991:a7ccbc79fc17) is not
|
|
security relevant (i.e. the bug could not cause memory corruption):
|
|
_xmalloc() never returns chunks of data smaller than the size of a
|
|
pointer, i.e. even if sizeof(void*) > guest_bytes > copy_bytes, the
|
|
piece of memory erroneously written to would still be inside the
|
|
allocation done at the top of the function.
|
|
|
|
Signed-off-by: Jan Beulich <jbeulich@suse.com>
|
|
Acked-by: Keir Fraser <keir@xen.org>
|
|
Committed-by: Jan Beulich <jbeulich@suse.com>
|
|
|
|
--- a/xen/common/domctl.c
|
|
+++ b/xen/common/domctl.c
|
|
@@ -78,7 +78,7 @@ int xenctl_cpumap_to_cpumask(
|
|
{
|
|
if ( copy_from_guest(bytemap, xenctl_cpumap->bitmap, copy_bytes) )
|
|
err = -EFAULT;
|
|
- if ( (xenctl_cpumap->nr_cpus & 7) && (guest_bytes <= sizeof(bytemap)) )
|
|
+ if ( (xenctl_cpumap->nr_cpus & 7) && (guest_bytes == copy_bytes) )
|
|
bytemap[guest_bytes-1] &= ~(0xff << (xenctl_cpumap->nr_cpus & 7));
|
|
}
|
|
|