pool/xfsprogs
3
0
Fork 3
Code Issues Pull Requests Projects Releases Wiki Activity

Switch to %autosetup in order to build with older rpm build #9

Merged
scm-staging-bot merged 1 commits from frispete/xfsprogs:factory into factory 2024-04-09 16:46:10 +02:00
Conversation 5 Commits 1 Files Changed 2 +6 -2
frispete commented 2024-04-03 11:46:54 +02:00
Contributor
Copy Link
No description provided.
frispete added 1 commit 2024-04-03 11:46:55 +02:00
ailiopoulos commented 2024-04-08 10:38:10 +02:00
Collaborator
Copy Link

looks ok in general, but could you write a few words on the exact problem you are encountering with an older rpm build is (and which rpm version would that be).

The setup/patch macros predate autosetup, so the change description makes no sense to me without further details.

looks ok in general, but could you write a few words on the exact problem you are encountering with an older rpm build is (and which rpm version would that be). The setup/patch macros predate autosetup, so the change description makes no sense to me without further details.
frispete commented 2024-04-08 11:02:25 +02:00
Author
Contributor
Copy Link

Hi Anthony,

yes, of course, I'm packaging some stuff here, eg. for 15.4: https://build.opensuse.org/project/monitor/home:frispete:15.4, and the %patch0 -p1, that you changed two months ago to %patch 0 -p1 (note the additional space) in order to get rid of some rpm deprecation warning, fails completely with rpmbuild of that distribution.

Hi Anthony, yes, of course, I'm packaging some stuff here, eg. for 15.4: https://build.opensuse.org/project/monitor/home:frispete:15.4, and the `%patch0 -p1`, that you changed two months ago to `%patch 0 -p1` (note the additional space) in order to get rid of some rpm deprecation warning, fails completely with rpmbuild of that distribution.
ailiopoulos commented 2024-04-08 11:11:58 +02:00
Collaborator
Copy Link

Thanks now it's clear, yes I can reproduce the issue in 15.4. Seems like this is an rpmbuild bug and it works with "%patch -P 0".

But in any case, I don't see the harm in switching to auto, I think I had already done this for 15.6.

So, go ahead with the proposed change.

Thanks now it's clear, yes I can reproduce the issue in 15.4. Seems like this is an rpmbuild bug and it works with "%patch -P 0". But in any case, I don't see the harm in switching to auto, I think I had already done this for 15.6. So, go ahead with the proposed change.
ailiopoulos requested review from ailiopoulos 2024-04-08 13:21:06 +02:00
ailiopoulos refused to review 2024-04-08 13:21:25 +02:00
ailiopoulos requested review from ailiopoulos 2024-04-08 13:22:08 +02:00
ailiopoulos commented 2024-04-08 13:22:31 +02:00
Collaborator
Copy Link

looks good

looks good
ailiopoulos approved these changes 2024-04-08 13:32:35 +02:00
ailiopoulos left a comment
Collaborator
Copy Link

looks good

looks good
scm-staging-bot commented 2024-04-08 13:32:42 +02:00
First-time contributor
Copy Link

Created submit request sr#1166161

Created submit request [sr#1166161](https://build.opensuse.org/request/show/1166161)
scm-staging-bot merged commit 85d024b269 into factory 2024-04-09 16:46:10 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
ailiopoulos
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: pool/xfsprogs#9
No description provided.
Delete Branch "frispete/xfsprogs:factory"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?