Pull request for optional update for python-matplotlib #305
Dismiss Review
Assignees
abergmann
adrianSuSE
andriinikitin
atartamo
autobuild-owner
autobuild-review
autogits_obs_staging_bot
autogits_workflow_pr_bot
bfilho
bigironman
darix
dmach
eroca
factory_bot
gitea-actions-autobuild
gsonnu
jdsn
legaldb
lkocman-factory
maintenance-release-review
maxlin_factory
mbozicevic
mimi_vx
mschnitzer
msmeissn
mstrigl
oertel
opensuse-review
packagehub-review
pluskalm
qam-openqa-review
rfrohl
smithfarm
szarate
Clear assignees
abergmann
adrianSuSE
andriinikitin
atartamo
autobuild-owner
autobuild-review
autogits_obs_staging_bot
autogits_workflow_pr_bot
bfilho
bigironman
darix
dmach
eroca
factory_bot
gitea-actions-autobuild
gsonnu
jdsn
legaldb
lkocman-factory
maintenance-release-review
maxlin_factory
mbozicevic
mimi_vx
mschnitzer
msmeissn
mstrigl
oertel
opensuse-review
packagehub-review
pluskalm
qam-openqa-review
rfrohl
smithfarm
szarate
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: products/PackageHub#305
Reference in New Issue
Block a user
Delete Branch "msmeissn/PackageHub:add-mathplotlib"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
PR: pool/python-matplotlib!2
Review by opensuse-review represents a group of reviewers: alarrosa, anag, atartamo, bigironman, darix, dimstar, dmach, eroca, jdsn, jengelh, mcalabkova, mstrigl, nkrapp, oertel, RBrownSUSE, simotek, smithfarm .
Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment:
@opensuse-review: approve.To request changes on behalf of the group, create the following comment:
@opensuse-review: declinefollowed with lines justifying the decision.Future edits of the comments are ignored, a new comment is required to change the review state.
Review by maintenance-release-review represents a group of reviewers: abergmann, amattiazzo, bfilho, cmatos, crazybyte, emanuelecappello, gsonnu, maintenance-robot, mauriziogalli, mbozicevic, mimi_vx, mschnitzer, pluskalm, rfrohl, slemke .
Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment:
@maintenance-release-review: approve.To request changes on behalf of the group, create the following comment:
@maintenance-release-review: declinefollowed with lines justifying the decision.Future edits of the comments are ignored, a new comment is required to change the review state.
Submitter is member of this review group, hence they are excluded from being one of the reviewers here
Build is started in https://build.opensuse.org/project/show/openSUSE:Backports:SLE-16.0:PullRequest:305 .
Review by qam-openqa-review represents a group of reviewers: mimi_vx, mschnitzer, openqa-maintenance, rfrohl, foursixnine-openqa, szarate .
Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment:
@qam-openqa-review: approve.To request changes on behalf of the group, create the following comment:
@qam-openqa-review: declinefollowed with lines justifying the decision.Future edits of the comments are ignored, a new comment is required to change the review state.
Submitter is member of this review group, hence they are excluded from being one of the reviewers here
Build failed
@opensuse-review : decline
need at least an empty PR for the added package
oertel requested changes on behalf of opensuse-review. See #305 (comment)
Review by opensuse-review represents a group of reviewers: alarrosa, anag, atartamo, bigironman, darix, dimstar, dmach, eroca, jdsn, jengelh, mcalabkova, mstrigl, nkrapp, oertel, RBrownSUSE, simotek, smithfarm .
Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment:
@opensuse-review: approve.To request changes on behalf of the group, create the following comment:
@opensuse-review: declinefollowed with lines justifying the decision.Future edits of the comments are ignored, a new comment is required to change the review state.
Created the empty PR for review purposes and linked in the description above.
Build failed
@opensuse-review : decline
commit-id missing in submodule ref
oertel requested changes on behalf of opensuse-review. See #305 (comment)
@oertel the webui shows a correct submodule addition?
@msmeissn it does not, it should be marked as submodule, but instead it says "Normal file":
Example of good submodule addition: https://src.opensuse.org/products/PackageHub/pulls/278/files
Review by qam-openqa-review represents a group of reviewers: mimi_vx, mschnitzer, openqa-maintenance, rfrohl, foursixnine-openqa, szarate .
Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment:
@qam-openqa-review: approve.To request changes on behalf of the group, create the following comment:
@qam-openqa-review: declinefollowed with lines justifying the decision.Future edits of the comments are ignored, a new comment is required to change the review state.
Submitter is member of this review group, hence they are excluded from being one of the reviewers here
Build is started in https://build.opensuse.org/project/show/openSUSE:Backports:SLE-16.0:PullRequest:305 .
Build failed
Review by opensuse-review represents a group of reviewers: alarrosa, anag, atartamo, bigironman, darix, dimstar, dmach, eroca, jdsn, jengelh, mcalabkova, mstrigl, nkrapp, oertel, RBrownSUSE, simotek, smithfarm .
Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment:
@opensuse-review: approve.To request changes on behalf of the group, create the following comment:
@opensuse-review: declinefollowed with lines justifying the decision.Future edits of the comments are ignored, a new comment is required to change the review state.
Review by maintenance-release-review represents a group of reviewers: abergmann, amattiazzo, bfilho, cmatos, crazybyte, emanuelecappello, gsonnu, maintenance-robot, mauriziogalli, mbozicevic, mimi_vx, mschnitzer, pluskalm, rfrohl, slemke .
Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment:
@maintenance-release-review: approve.To request changes on behalf of the group, create the following comment:
@maintenance-release-review: declinefollowed with lines justifying the decision.Future edits of the comments are ignored, a new comment is required to change the review state.
Submitter is member of this review group, hence they are excluded from being one of the reviewers here
Review by qam-openqa-review represents a group of reviewers: mimi_vx, mschnitzer, openqa-maintenance, rfrohl, foursixnine-openqa, szarate .
Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment:
@qam-openqa-review: approve.To request changes on behalf of the group, create the following comment:
@qam-openqa-review: declinefollowed with lines justifying the decision.Future edits of the comments are ignored, a new comment is required to change the review state.
Submitter is member of this review group, hence they are excluded from being one of the reviewers here
Build is started in https://build.opensuse.org/project/show/openSUSE:Backports:SLE-16.0:PullRequest:305 .
8ddff1a721to1d57d91effBuild is started in https://build.opensuse.org/project/show/openSUSE:Backports:SLE-16.0:PullRequest:305 .
Review by opensuse-review represents a group of reviewers: alarrosa, anag, atartamo, bigironman, darix, dimstar, dmach, eroca, jdsn, jengelh, mcalabkova, mstrigl, nkrapp, oertel, RBrownSUSE, simotek, smithfarm .
Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment:
@opensuse-review: approve.To request changes on behalf of the group, create the following comment:
@opensuse-review: declinefollowed with lines justifying the decision.Future edits of the comments are ignored, a new comment is required to change the review state.
Review by maintenance-release-review represents a group of reviewers: abergmann, amattiazzo, bfilho, cmatos, crazybyte, emanuelecappello, gsonnu, maintenance-robot, mauriziogalli, mbozicevic, mimi_vx, mschnitzer, pluskalm, rfrohl, slemke .
Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment:
@maintenance-release-review: approve.To request changes on behalf of the group, create the following comment:
@maintenance-release-review: declinefollowed with lines justifying the decision.Future edits of the comments are ignored, a new comment is required to change the review state.
Submitter is member of this review group, hence they are excluded from being one of the reviewers here
Review by qam-openqa-review represents a group of reviewers: mimi_vx, mschnitzer, openqa-maintenance, rfrohl, foursixnine-openqa, szarate .
Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment:
@qam-openqa-review: approve.To request changes on behalf of the group, create the following comment:
@qam-openqa-review: declinefollowed with lines justifying the decision.Future edits of the comments are ignored, a new comment is required to change the review state.
Submitter is member of this review group, hence they are excluded from being one of the reviewers here
Build is started in https://build.opensuse.org/project/show/openSUSE:Backports:SLE-16.0:PullRequest:305 .
Build successful
openQA tests triggered: https://openqa.opensuse.org/tests/overview?build=%3Aproducts_PackageHub%3A305%3Apython-matplotlib&distri=opensuse&version=16.0
openQA tests failed: https://openqa.opensuse.org/tests/overview?build=%3Aproducts_PackageHub%3A305%3Apython-matplotlib&distri=opensuse&version=16.0
@qam-openqa-review: decline
openqa-maintenance requested changes on behalf of qam-openqa-review. See #305 (comment)
waiting for maint review
@opensuse-review : approve
LGTM
merge ok
oertel approved a review on behalf of opensuse-review
Hi, I don't understand what is going on with the openQA. Could someone please tell me what is wrong at the package level?
Might have been a early setup issue, I will ask Santi to re-run openQA to verify.
Review by qam-openqa-review represents a group of reviewers: mimi_vx, mschnitzer, openqa-maintenance, rfrohl, foursixnine-openqa, szarate .
Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment:
@qam-openqa-review: approve.To request changes on behalf of the group, create the following comment:
@qam-openqa-review: declinefollowed with lines justifying the decision.Future edits of the comments are ignored, a new comment is required to change the review state.
Submitter is member of this review group, hence they are excluded from being one of the reviewers here
AFAIK the release is lower as the SLES version, thats why it was not triggering.
But the qt package is new, so that should work and go out
also tests fail currently:
obs rbl openSUSE:Backports:SLE-16.0:PullRequest:305 python-matplotlib:test standard x86_64
[ 311s] SKIPPED [1] ../../../../../../usr/lib64/python3.13/site-packages/matplotlib/tests/test_usetex.py:106: chemformula is not available
[ 311s] FAILED test_colors.py::test_norm_callback - AssertionError: assert 3 == 1
[ 311s] + where 3 = .call_count
[ 311s] ===== 1 failed, 9094 passed, 223 skipped, 32 xfailed in 154.46s (0:02:34) ======
openSUSE:Factory/python-matplotlib correct-reset-mock.patch might be needed
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.