products/PackageHub
SHA256
31
1
Fork 13
Code Issues Pull Requests 21 Actions Activity

Dummy change to test merge permissions #143

Manually merged
products merged 1 commits from eroca/test-git-pr-workflow-merge AGit into leap-16.0 2025-09-26 15:59:18 +02:00
Conversation 18 Commits 1 Files Changed 1 +1 -1
eroca commented 2025-09-26 13:12:38 +02:00
Owner
Copy Link

Dummy change to test merge permissions

Dummy change to test merge permissions
eroca added 1 commit 2025-09-26 13:12:38 +02:00
Dummy change to test merge permissions 3fdbe74a8d
autogits_workflow_pr_bot requested review from autogits_obs_staging_bot 2025-09-26 13:12:39 +02:00
autogits_workflow_pr_bot requested review from lkocman-factory 2025-09-26 13:12:39 +02:00
autogits_workflow_pr_bot requested review from maxlin_factory 2025-09-26 13:12:40 +02:00
eroca commented 2025-09-26 13:13:44 +02:00
Author
Owner
Copy Link

@maxlin_factory please do a review and then, separately, comment "merge ok" please.

@maxlin_factory please do a review and then, separately, comment "merge ok" please.
autogits_obs_staging_bot approved these changes 2025-09-26 13:15:32 +02:00
autogits_obs_staging_bot left a comment
Member
Copy Link

No package changes, not rebuilding project by default, accepting change

No package changes, not rebuilding project by default, accepting change
maxlin_factory commented 2025-09-26 13:23:05 +02:00
Member
Copy Link

merge ok

merge ok
maxlin_factory approved these changes 2025-09-26 13:23:34 +02:00
eroca closed this pull request 2025-09-26 13:51:09 +02:00
eroca reopened this pull request 2025-09-26 13:51:11 +02:00
autogits_workflow_pr_bot requested review from autobuild-review 2025-09-26 13:51:13 +02:00
autobuild-review commented 2025-09-26 13:55:34 +02:00
Member
Copy Link

Review by autobuild-review represents a group of reviewers: atartamo, dmach, jdsn, mstrigl, darix, smithfarm, oertel, bigironman .

Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment: @autobuild-review: approve.
To request changes on behalf of the group, create the following comment: @autobuild-review: decline followed with lines justifying the decision.
Future edits of the comments are ignored, a new comment is required to change the review state.

Review by autobuild-review represents a group of reviewers: atartamo, dmach, jdsn, mstrigl, darix, smithfarm, oertel, bigironman . Do **not** use standard review interface to review on behalf of the group. To accept the review on behalf of the group, create the following comment: `@autobuild-review: approve`. To request changes on behalf of the group, create the following comment: `@autobuild-review: decline` followed with lines justifying the decision. Future edits of the comments are ignored, a new comment is required to change the review state.
eroca commented 2025-09-26 13:55:44 +02:00
Author
Owner
Copy Link

@autobuild-review: approve

@autobuild-review: approve
bigironman commented 2025-09-26 14:52:49 +02:00
Owner
Copy Link

@autobuild-review: approve

@autobuild-review: approve
autobuild-review approved these changes 2025-09-26 14:56:22 +02:00
autobuild-review left a comment
Member
Copy Link

bigironman approved a review on behalf of autobuild-review

bigironman approved a review on behalf of autobuild-review
smithfarm commented 2025-09-26 15:09:33 +02:00
Owner
Copy Link

I thought we wanted Max and Lubos to be able to review and merge PRs in products/PackageHub ...
this seems to be going against that

I thought we wanted Max and Lubos to be able to review and merge PRs in `products/PackageHub` ... this seems to be going against that
eroca commented 2025-09-26 15:12:37 +02:00
Author
Owner
Copy Link

I'm not so sure. Docs at https://src.opensuse.org/adamm/autogits/src/branch/main/workflow-pr say:

ManualMergeProject: (true, false) only merge if "merge ok" by project maintainers or reviewers

This PR is for testing that.

I'm not so sure. Docs at https://src.opensuse.org/adamm/autogits/src/branch/main/workflow-pr say: > ManualMergeProject: (true, false) only merge if "merge ok" by project maintainers or reviewers This PR is for testing that.
eroca removed review request for lkocman-factory 2025-09-26 15:15:15 +02:00
eroca closed this pull request 2025-09-26 15:15:24 +02:00
eroca reopened this pull request 2025-09-26 15:15:27 +02:00
autogits_workflow_pr_bot requested review from lkocman-factory 2025-09-26 15:15:28 +02:00
maxlin_factory commented 2025-09-26 15:18:39 +02:00
Member
Copy Link

ok, so a manual merging on gitea is still worked for me as it doesn't matter to _maintainership.json but the permission setting on this project. the thing does not work anymore is the auto-merging by workflow bot if I sent 'merge ok' command, I think workflow_pr bot don't see me list in the _maintainership.json then ignores my command, I give it a try on #139 the usual process does not WORK now.

ok, so a manual merging on gitea is still worked for me as it doesn't matter to _maintainership.json but the permission setting on this project. the thing does not work anymore is the auto-merging by workflow bot if I sent 'merge ok' command, I think workflow_pr bot don't see me list in the _maintainership.json then ignores my command, I give it a try on https://src.opensuse.org/products/PackageHub/pulls/139 the usual process does not WORK now.
maxlin_factory commented 2025-09-26 15:23:45 +02:00
Member
Copy Link

can we add us back to project maintainer list in case we might need some urgent last minute change prior to Leap 16.0 GM?

can we add us back to project maintainer list in case we might need some urgent last minute change prior to Leap 16.0 GM?
👍 1
eroca closed this pull request 2025-09-26 15:43:59 +02:00
eroca reopened this pull request 2025-09-26 15:44:02 +02:00
autogits_workflow_pr_bot requested review from packagehub-review 2025-09-26 15:44:04 +02:00
packagehub-review commented 2025-09-26 15:44:50 +02:00
Member
Copy Link

Review by packagehub-review represents a group of reviewers: bigironman, lkocman-factory, maxlin_factory, smithfarm .

Do not use standard review interface to review on behalf of the group.
To accept the review on behalf of the group, create the following comment: @packagehub-review: approve.
To request changes on behalf of the group, create the following comment: @packagehub-review: decline followed with lines justifying the decision.
Future edits of the comments are ignored, a new comment is required to change the review state.

Review by packagehub-review represents a group of reviewers: bigironman, lkocman-factory, maxlin_factory, smithfarm . Do **not** use standard review interface to review on behalf of the group. To accept the review on behalf of the group, create the following comment: `@packagehub-review: approve`. To request changes on behalf of the group, create the following comment: `@packagehub-review: decline` followed with lines justifying the decision. Future edits of the comments are ignored, a new comment is required to change the review state.
packagehub-review requested review from bigironman 2025-09-26 15:45:42 +02:00
packagehub-review requested review from maxlin_factory 2025-09-26 15:45:42 +02:00
packagehub-review requested review from smithfarm 2025-09-26 15:45:42 +02:00
smithfarm commented 2025-09-26 15:45:55 +02:00
Owner
Copy Link

I'm not so sure. Docs at https://src.opensuse.org/adamm/autogits/src/branch/main/workflow-pr say:

ManualMergeProject: (true, false) only merge if "merge ok" by project maintainers or reviewers

This PR is for testing that.

OK, so you're saying since Max and Lubos are in reviewers (but not maintainers), they should be able to do "merge ok".
Apparently that's not the case, but I'll bet it will work for them if you re-add them to _maintainership.json

> I'm not so sure. Docs at https://src.opensuse.org/adamm/autogits/src/branch/main/workflow-pr say: > > ManualMergeProject: (true, false) only merge if "merge ok" by project maintainers or reviewers > > This PR is for testing that. > OK, so you're saying since Max and Lubos are in reviewers (but not maintainers), they should be able to do "merge ok". Apparently that's not the case, but I'll bet it will work for them if you re-add them to `_maintainership.json`
eroca closed this pull request 2025-09-26 15:47:38 +02:00
eroca reopened this pull request 2025-09-26 15:47:40 +02:00
maxlin_factory commented 2025-09-26 15:50:08 +02:00
Member
Copy Link

@packagehub-review: approve

@packagehub-review: approve
maxlin_factory commented 2025-09-26 15:50:35 +02:00
Member
Copy Link

merge ok

merge ok
packagehub-review approved these changes 2025-09-26 15:51:50 +02:00
packagehub-review left a comment
Member
Copy Link

maxlin_factory approved a review on behalf of packagehub-review

maxlin_factory approved a review on behalf of packagehub-review
packagehub-review removed review request for bigironman 2025-09-26 15:51:50 +02:00
packagehub-review removed review request for lkocman-factory 2025-09-26 15:51:50 +02:00
packagehub-review removed review request for maxlin_factory 2025-09-26 15:51:50 +02:00
packagehub-review removed review request for smithfarm 2025-09-26 15:51:50 +02:00
eroca closed this pull request 2025-09-26 15:58:29 +02:00
eroca reopened this pull request 2025-09-26 15:58:31 +02:00
autogits_workflow_pr_bot referenced this issue from a commit 2025-09-26 15:59:16 +02:00
Merging
products manually merged commit ca34b0abcf into leap-16.0 2025-09-26 15:59:18 +02:00
eroca commented 2025-09-26 16:00:19 +02:00
Author
Owner
Copy Link

@smithfarm you are right - added packagehub-reviewer to the file, it worked.

I think the docu could be clearer there.

@smithfarm you are right - added packagehub-reviewer to the file, it worked. I think the docu could be clearer there.
Sign in to join this conversation.
Reviewers
No Reviewers
autogits_obs_staging_bot
maxlin_factory
autobuild-review
packagehub-review
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
abergmann adrianSuSE atartamo autobuild-owner autobuild-review autogits_obs_staging_bot autogits_workflow_pr_bot bfilho bigironman darix dmach eroca factory_bot gitea-actions-autobuild gsonnu jdsn legaldb lkocman-factory maintenance-release-review maxlin_factory mbozicevic mimi_vx mschnitzer msmeissn mstrigl oertel opensuse-review packagehub-review pluskalm qam-openqa-review rfrohl smithfarm szarate
No Assignees
7 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: products/PackageHub#143
Delete Branch "eroca/test-git-pr-workflow-merge"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?