Accepting request 690091 from home:jayvdb:branches:devel:languages:python

- Activate and fix test suite, removing bcond 'tests'
- Add Requires sgmllib3k to fix exception in Python 3 when
  using the loose parser:
  UnboundLocalError: local variable 'feedparser' referenced before assignment
  and less clear but similarly broken result with the strict
  parser.
- Add catch-gzip-error.patch to fix fetch crash in Python 3
- Add non-ascii-entity-hiding.patch to workaround failure
  to properly parse non-ASCII based encodings on Python 3.5+
- Add py37.patch to fix parsing crash on Python 3.7

OBS-URL: https://build.opensuse.org/request/show/690091
OBS-URL: https://build.opensuse.org/package/show/devel:languages:python/python-feedparser?expand=0&rev=40

python-feedparser.spec

@@ -1,7 +1,7 @@
 #
 # spec file for package python-feedparser
 #
-# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -17,8 +17,6 @@
 
 
 %{?!python_module:%define python_module() python-%{**} python3-%{**}}
-# Tests require a network connection
-%bcond_without tests
 Name:           python-feedparser
 Version:        5.2.1
 Release:        0
@@ -27,12 +25,26 @@ License:        BSD-2-Clause
 Group:          Development/Libraries/Python
 URL:            https://github.com/kurtmckee/feedparser
 Source:         https://files.pythonhosted.org/packages/source/f/feedparser/feedparser-%{version}.tar.bz2
+Patch0:         py37.patch
+Patch1:         non-ascii-entity-hiding.patch
+# Similar to https://github.com/kurtmckee/feedparser/commit/b3d9463.patch
+# However the "gets overwritten as xml.sax.SAXException later" is not
+# happening in version 5.2.1.
+Patch2:         catch-gzip-error.patch
 BuildRequires:  %{python_module setuptools}
 BuildRequires:  %{python_module xml}
 BuildRequires:  fdupes
 BuildRequires:  python-rpm-macros
-BuildRequires:  python3-2to3
+BuildRequires:  python3-sgmllib3k
+# Tests fail in Python 2 and 3 when chardet is installed
+#BuildRequires:  python3-chardet
 Requires:       python-xml
+# chardet is an optional dependency, but some tests fail when it is present
+Recommends:     python-chardet
+%ifpython3
+# If sgmllib is not available, the parser can fail with undefined local variable
+Requires:       python3-sgmllib3k
+%endif
 BuildArch:      noarch
 %python_subpackages
 
@@ -42,8 +54,18 @@ A universal feed parser module for Python that handles RSS 0.9x, RSS 1.0, RSS
 
 %prep
 %setup -q -n feedparser-%{version}
+%autopatch -p1
+
 find . -type f -exec chmod 0644 {} \;  # 5.2.1 had executable bit set on almost all files
 
+# In version 5.2.1, it contains only test data, so move it out of install
+mv feedparser/tests .
+
+# Move the test module out of the runtime install, into top level directory
+# so it can find the test data, and manually run 2to3.
+python3 -m lib2to3 -w -n -o . --add-suffix=-%{python3_bin_suffix} --no-diffs feedparser/feedparsertest.py
+mv feedparser/feedparsertest.py feedparsertest.py-%{python2_bin_suffix}
+
 %build
 %python_build
 
@@ -51,13 +73,13 @@ find . -type f -exec chmod 0644 {} \;  # 5.2.1 had executable bit set on almost
 %python_install
 %python_expand %fdupes %{buildroot}%{$python_sitelib}
 
-%if %{with tests}
 %check
-# Tests only work on Python 2.x
-pushd feedparser
-python2 feedparsertest.py
-popd
-%endif
+%{python_expand export PYTHONPATH=%{buildroot}%{$python_sitelib}:${PWD}
+cp feedparsertest.py-%{$python_bin_suffix} feedparsertest.py
+$python -c 'import feedparser; assert feedparser._XML_AVAILABLE == 1; assert feedparser._SGML_AVAILABLE == 1'
+$python -c 'import feedparsertest; assert feedparsertest._UTF32_AVAILABLE == 1'
+$python feedparsertest.py
+}
 
 %files %{python_files}
 %license LICENSE