14
0
2022-10-01 17:21:08 +00:00
committed by Git OBS Bridge
parent f948ebdd79
commit 2a2fe3ae00
2 changed files with 0 additions and 62 deletions

View File

@@ -1,47 +0,0 @@
From 0c67a3c6407fbf4483ccfc94a7a0d78cf3379296 Mon Sep 17 00:00:00 2001
From: Miro Hrončok <miro@hroncok.cz>
Date: Sep 29 2021 10:05:27 +0000
Subject: Remove incorrect double-patch of objects in test cases.
The specific test cases relying on the patches, already are decorated
to patch the specific attributes needed. We don't need a general patch
of the attributes in the test case setup.
Signed-off-by: Ben Finney <ben+python@benfinney.id.au>
---
---
ChangeLog | 4 ++++
test/test_pidfile.py | 6 ------
2 files changed, 4 insertions(+), 6 deletions(-)
--- a/ChangeLog
+++ b/ChangeLog
@@ -14,6 +14,10 @@ Version 2.3.0
:Released: 2021-02-21
:Maintainer: Ben Finney <ben+python@benfinney.id.au>
+* Remove incorrect double-patch of objects in test cases.
+
+ Closes: Pagure #62. Thanks to Miro Hrončok for the report.
+
Removed:
* Remove support for Python versions older than Python 3.
--- a/test/test_pidfile.py
+++ b/test/test_pidfile.py
@@ -391,12 +391,6 @@ class TimeoutPIDLockFile_TestCase(scaffo
pidlockfile_scenarios = make_pidlockfile_scenarios()
self.pidlockfile_scenario = pidlockfile_scenarios['simple']
- for func_name in ['__init__', 'acquire']:
- func_patcher = unittest.mock.patch.object(
- lockfile.pidlockfile.PIDLockFile, func_name)
- func_patcher.start()
- self.addCleanup(func_patcher.stop)
-
self.scenario = {
'pidfile_path': self.pidlockfile_scenario['pidfile_path'],
'acquire_timeout': self.getUniqueInteger(),

View File

@@ -1,15 +0,0 @@
---
test/test_metadata.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/test/test_metadata.py
+++ b/test/test_metadata.py
@@ -44,7 +44,7 @@ class HasAttribute(testtools.matchers.Ma
def match(self, instance):
""" Assert the object `instance` has an attribute named `name`. """
result = None
- if not testtools.helpers.safe_hasattr(instance, self.attribute_name):
+ if not hasattr(instance, self.attribute_name):
result = AttributeNotFoundMismatch(instance, self.attribute_name)
return result