From 0c67a3c6407fbf4483ccfc94a7a0d78cf3379296 Mon Sep 17 00:00:00 2001 From: Miro Hrončok Date: Sep 29 2021 10:05:27 +0000 Subject: Remove incorrect double-patch of objects in test cases. The specific test cases relying on the patches, already are decorated to patch the specific attributes needed. We don't need a general patch of the attributes in the test case setup. Signed-off-by: Ben Finney --- --- ChangeLog | 4 ++++ test/test_pidfile.py | 6 ------ 2 files changed, 4 insertions(+), 6 deletions(-) --- a/ChangeLog +++ b/ChangeLog @@ -14,6 +14,10 @@ Version 2.3.0 :Released: 2021-02-21 :Maintainer: Ben Finney +* Remove incorrect double-patch of objects in test cases. + + Closes: Pagure #62. Thanks to Miro Hrončok for the report. + Removed: * Remove support for Python versions older than Python 3. --- a/test/test_pidfile.py +++ b/test/test_pidfile.py @@ -391,12 +391,6 @@ class TimeoutPIDLockFile_TestCase(scaffo pidlockfile_scenarios = make_pidlockfile_scenarios() self.pidlockfile_scenario = pidlockfile_scenarios['simple'] - for func_name in ['__init__', 'acquire']: - func_patcher = unittest.mock.patch.object( - lockfile.pidlockfile.PIDLockFile, func_name) - func_patcher.start() - self.addCleanup(func_patcher.stop) - self.scenario = { 'pidfile_path': self.pidlockfile_scenario['pidfile_path'], 'acquire_timeout': self.getUniqueInteger(),