2019-11-01 15:24:05 +01:00
|
|
|
# HG changeset patch
|
2020-03-12 20:14:24 +01:00
|
|
|
# Parent 883d2c7fec80b9714ccfefa461a02f5b09e3ee09
|
2019-11-01 15:24:05 +01:00
|
|
|
Problem description: Tab-titles that are too long to fit into a tab get faded out.
|
2020-03-12 20:14:24 +01:00
|
|
|
On big endian this is broken and instead of fading out, the
|
2019-11-01 15:24:05 +01:00
|
|
|
tab gets white and the font transparent, leading to an unreadable
|
|
|
|
tab-title
|
|
|
|
Solution: This is not a real solution, but a hack. The real solution would have been
|
|
|
|
to byte-swap the correct buffer, but I could not find it.
|
|
|
|
So the next best thing is to deactivate the fading-effect. Now all tab-titles
|
2020-03-12 20:14:24 +01:00
|
|
|
are readable, albeit not as pretty to look at as they could be.
|
2019-11-01 15:24:05 +01:00
|
|
|
Side-effects: I have not yet found an unwanted side-effect.
|
|
|
|
|
2020-03-12 20:14:24 +01:00
|
|
|
diff --git a/gfx/2d/DrawTargetSkia.cpp b/gfx/2d/DrawTargetSkia.cpp
|
|
|
|
--- a/gfx/2d/DrawTargetSkia.cpp
|
|
|
|
+++ b/gfx/2d/DrawTargetSkia.cpp
|
|
|
|
@@ -1856,16 +1856,24 @@ void DrawTargetSkia::PushLayerWithBlend(
|
|
|
|
}
|
|
|
|
|
|
|
|
SkCanvas::SaveLayerRec saveRec(
|
|
|
|
aBounds.IsEmpty() ? nullptr : &bounds, &paint, nullptr, clipImage.get(),
|
|
|
|
&clipMatrix,
|
2019-11-01 15:24:05 +01:00
|
|
|
SkCanvas::kPreserveLCDText_SaveLayerFlag |
|
|
|
|
(aCopyBackground ? SkCanvas::kInitWithPrevious_SaveLayerFlag : 0));
|
|
|
|
|
2020-02-26 09:14:44 +01:00
|
|
|
+#if MOZ_BIG_ENDIAN()
|
2019-11-01 15:24:05 +01:00
|
|
|
+ // Pushing a layer where an aMask is defined produces wrong output.
|
|
|
|
+ // We _should_ endian swap the data, but I couldn't find a workable way to do so
|
|
|
|
+ // Therefore I deactivate those layers in the meantime.
|
|
|
|
+ // The result is: Tab-titles that are longer than the available space should be faded out.
|
|
|
|
+ // The fading doesn't work, so we deactivate the fading-effect here.
|
|
|
|
+ if (!aMask)
|
|
|
|
+#endif
|
|
|
|
mCanvas->saveLayer(saveRec);
|
|
|
|
|
|
|
|
SetPermitSubpixelAA(aOpaque);
|
2020-03-12 20:14:24 +01:00
|
|
|
|
|
|
|
#ifdef MOZ_WIDGET_COCOA
|
|
|
|
CGContextRelease(mCG);
|
|
|
|
mCG = nullptr;
|
|
|
|
#endif
|