Accepting request 280342 from games

OBS-URL: https://build.opensuse.org/request/show/280342
OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/SDL2_mixer?expand=0&rev=3

SDL2_mixer.changes

@@ -1,3 +1,9 @@
+-------------------------------------------------------------------
+Thu Jan  8 09:33:53 UTC 2015 - jengelh@inai.de
+
+- Improve package summary and description. Drop --with-pic which
+  is enabled implicitly anyway, remove redundant Requires.
+
 -------------------------------------------------------------------
 Wed Aug 28 18:34:49 UTC 2013 - jengelh@inai.de
 

SDL2_mixer.spec

@@ -1,7 +1,7 @@
 #
 # spec file for package SDL2_mixer
 #
-# Copyright (c) 2013 SUSE LINUX Products GmbH, Nuernberg, Germany.
+# Copyright (c) 2015 SUSE LINUX Products GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -20,7 +20,7 @@ Name:           SDL2_mixer
 %define lname	libSDL2_mixer-2_0-0
 Version:        2.0.0
 Release:        0
-Summary:        Sample Mixer Library for SDL2
+Summary:        SDL2 sound mixer library
 License:        Zlib
 Group:          Development/Libraries/C and C++
 Url:            http://libsdl.org/projects/SDL_mixer/
@@ -28,14 +28,13 @@ Url:            http://libsdl.org/projects/SDL_mixer/
 #Hg-Clone:	http://hg.libsdl.org/SDL_mixer/
 Source:         http://libsdl.org/projects/SDL_mixer/release/%name-%version.tar.gz
 Source1:        baselibs.conf
-BuildRequires:  flac-devel
-BuildRequires:  fluidsynth-devel
-BuildRequires:  libSDL2-devel
-BuildRequires:  libmikmod-devel
-BuildRequires:  libogg-devel
-BuildRequires:  libvorbis-devel
-BuildRequires:  pkgconfig
+BuildRequires:  pkg-config
+BuildRequires:  pkgconfig(flac)
+BuildRequires:  pkgconfig(fluidsynth)
+BuildRequires:  pkgconfig(libmikmod)
 BuildRequires:  pkgconfig(libmodplug) >= 0.8.8
+BuildRequires:  pkgconfig(sdl2)
+BuildRequires:  pkgconfig(vorbis)
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 
 %description
@@ -44,9 +43,9 @@ audio, plus a single channel of music, mixed by the popular MikMod MOD,
 Timidity MIDI, and SMPEG MP3 libraries.
 
 %package -n %lname
-Summary:        Sample Mixer Library for SDL2
+Summary:        Simple DirectMedia Layer 2 – Sound mixer library
 Group:          System/Libraries
-Provides:       SDL2_mixer = %{version}
+Provides:       SDL2_mixer = %version-%release
 
 %description -n %lname
 A multichannel audio mixer. It supports four channels of 16-bit stereo
@@ -54,11 +53,10 @@ audio, plus a single channel of music, mixed by the popular MikMod MOD,
 Timidity MIDI, and SMPEG MP3 libraries.
 
 %package -n libSDL2_mixer-devel
-Summary:        Sample Mixer Library for SDL2 - files mandatory for development
+Summary:        Development files for the SDL2 sound mixer library
 Group:          Development/Libraries/C and C++
 Requires:       %lname = %version
-Requires:       libSDL2-devel
-Provides:       SDL2_mixer-devel = %{version}
+Provides:       SDL2_mixer-devel = %version-%release
 
 %description -n libSDL2_mixer-devel
 A multi-channel audio mixer. It supports 4 channels of 16-bit stereo
@@ -77,29 +75,27 @@ rm -rf external
 	--disable-music-ogg-shared \
 	--disable-music-flac-shared \
 	--enable-music-mp3-smpeg-shared \
-	--disable-static \
-	--with-pic
+	--disable-static
 make %{?_smp_mflags}
 
 %install
-make install install-bin DESTDIR=%{buildroot}
-rm -f %{buildroot}%{_libdir}/*.la
+%make_install install-bin
+rm -f "%buildroot/%_libdir"/*.la
 # We have these debug tools in SDL_mixer-devel already
 rm -f "%buildroot/%_bindir"/play*
 
 %post   -n %lname -p /sbin/ldconfig
-
 %postun -n %lname -p /sbin/ldconfig
 
 %files -n %lname
 %defattr(-,root,root)
 %doc CHANGES.txt COPYING.txt README.txt
-%{_libdir}/libSDL2_mixer-2*.so.*
+%_libdir/libSDL2_mixer-2*.so.*
 
 %files -n libSDL2_mixer-devel
 %defattr(-,root,root)
-%{_includedir}/SDL2/
-%{_libdir}/libSDL2_mixer.so
-%{_libdir}/pkgconfig/SDL2_mixer.pc
+%_includedir/SDL2/
+%_libdir/libSDL2_mixer.so
+%_libdir/pkgconfig/SDL2_mixer.pc
 
 %changelog