--- apache-sshd-2.12.0/sshd-common/src/main/java/org/apache/sshd/client/auth/password/PasswordIdentityProvider.java 2024-01-19 22:39:38.007238345 +0100 +++ apache-sshd-2.12.0/sshd-common/src/main/java/org/apache/sshd/client/auth/password/PasswordIdentityProvider.java 2024-01-19 22:39:58.550160515 +0100 @@ -36,7 +36,7 @@ public interface PasswordIdentityProvider { /** - * An "empty" implementation of {@link PasswordIdentityProvider} that returns an empty group of passwords + * An "empty" implementation of {@link PasswordIdentityProvider} that returns an empty group of passwords */ PasswordIdentityProvider EMPTY_PASSWORDS_PROVIDER = new PasswordIdentityProvider() { @Override --- apache-sshd-2.12.0/sshd-common/src/main/java/org/apache/sshd/common/config/keys/KeyUtils.java 2024-01-19 22:39:38.013904878 +0100 +++ apache-sshd-2.12.0/sshd-common/src/main/java/org/apache/sshd/common/config/keys/KeyUtils.java 2024-01-19 22:39:58.556827049 +0100 @@ -766,7 +766,7 @@ * @param expected The expected fingerprint if {@code null} or empty then returns a failure with the default * fingerprint. * @param key the {@link PublicKey} - if {@code null} then returns null. - * @return SimpleImmutableEntry - key is success indicator, value is actual fingerprint, + * @return SimpleImmutableEntry<Boolean, String> - key is success indicator, value is actual fingerprint, * {@code null} if no key. * @see #getDefaultFingerPrintFactory() * @see #checkFingerPrint(String, Factory, PublicKey) @@ -780,7 +780,7 @@ * fingerprint. * @param f The {@link Factory} to be used to generate the default {@link Digest} for the key * @param key the {@link PublicKey} - if {@code null} then returns null. - * @return SimpleImmutableEntry - key is success indicator, value is actual fingerprint, + * @return SimpleImmutableEntry<Boolean, String> - key is success indicator, value is actual fingerprint, * {@code null} if no key. */ public static SimpleImmutableEntry checkFingerPrint( @@ -793,7 +793,7 @@ * fingerprint. * @param d The {@link Digest} to be used to generate the default fingerprint for the key * @param key the {@link PublicKey} - if {@code null} then returns null. - * @return SimpleImmutableEntry - key is success indicator, value is actual fingerprint, + * @return SimpleImmutableEntry<Boolean, String> - key is success indicator, value is actual fingerprint, * {@code null} if no key. */ public static SimpleImmutableEntry checkFingerPrint(String expected, Digest d, PublicKey key) { --- apache-sshd-2.12.0/sshd-common/src/main/java/org/apache/sshd/common/config/keys/loader/openssh/OpenSSHKeyPairResourceParser.java 2024-01-19 22:39:38.010571611 +0100 +++ apache-sshd-2.12.0/sshd-common/src/main/java/org/apache/sshd/common/config/keys/loader/openssh/OpenSSHKeyPairResourceParser.java 2024-01-19 22:39:58.556827049 +0100 @@ -63,9 +63,7 @@ import org.apache.sshd.common.util.security.SecurityUtils; /** - * Basic support for OpenSSH - * key file(s) + * Basic support for OpenSSH key file(s) * * @author Apache MINA SSHD Project */ --- apache-sshd-2.12.0/sshd-common/src/main/java/org/apache/sshd/common/util/buffer/keys/BufferPublicKeyParser.java 2024-01-19 22:39:38.020571412 +0100 +++ apache-sshd-2.12.0/sshd-common/src/main/java/org/apache/sshd/common/util/buffer/keys/BufferPublicKeyParser.java 2024-01-19 22:39:58.563493582 +0100 @@ -64,13 +64,13 @@ SkED25519BufferPublicKeyParser.INSTANCE)); /** - * @param keyType The key type - e.g., "ssh-rsa", "ssh-dss" + * @param keyType The key type - e.g., "ssh-rsa", "ssh-dss" * @return {@code true} if this key type is supported by the parser */ boolean isKeyTypeSupported(String keyType); /** - * @param keyType The key type - e.g., "ssh-rsa", "ssh-dss" + * @param keyType The key type - e.g., "ssh-rsa", "ssh-dss" * @param buffer The {@link Buffer} containing the encoded raw public key * @return The decoded {@link PublicKey} * @throws GeneralSecurityException If failed to generate the key --- apache-sshd-2.12.0/sshd-common/src/main/java/org/apache/sshd/common/util/GenericUtils.java 2024-01-19 22:39:38.023904678 +0100 +++ apache-sshd-2.12.0/sshd-common/src/main/java/org/apache/sshd/common/util/GenericUtils.java 2024-01-19 22:39:58.570160116 +0100 @@ -112,10 +112,11 @@ * @param with String to replace with * @param max maximum number of values to replace, or -1 if no maximum * @return the text with any replacements processed - * @author Arnout J. Kuiper ajkuiper@wxs.nl - * @author Magesh Umasankar - * @author Bruce Atherton - * @author Antoine Levy-Lambert + * + * author Arnout J. Kuiper ajkuiper@wxs.nl + * author Magesh Umasankar + * author Bruce Atherton + * author Antoine Levy-Lambert */ @SuppressWarnings("PMD.AssignmentInOperand") public static String replace(String text, String repl, String with, int max) { --- apache-sshd-2.12.0/sshd-common/src/main/java/org/apache/sshd/common/util/io/der/DERWriter.java 2024-01-19 22:39:38.020571412 +0100 +++ apache-sshd-2.12.0/sshd-common/src/main/java/org/apache/sshd/common/util/io/der/DERWriter.java 2024-01-19 22:39:58.573493382 +0100 @@ -76,7 +76,7 @@ } /** - * The integer is always considered to be positive, so if the first byte is < 0, we pad with a zero to make it + * The integer is always considered to be positive, so if the first byte is < 0, we pad with a zero to make it * positive * * @param bytes {@link BigInteger} bytes @@ -87,7 +87,7 @@ } /** - * The integer is always considered to be positive, so if the first byte is < 0, we pad with a zero to make it + * The integer is always considered to be positive, so if the first byte is < 0, we pad with a zero to make it * positive * * @param bytes {@link BigInteger} bytes --- apache-sshd-2.12.0/sshd-common/src/main/java/org/apache/sshd/common/util/OsUtils.java 2024-01-19 22:39:38.027237945 +0100 +++ apache-sshd-2.12.0/sshd-common/src/main/java/org/apache/sshd/common/util/OsUtils.java 2024-01-19 22:39:58.580159916 +0100 @@ -334,7 +334,7 @@ } /** - * Remove {@code Windows} domain and/or group prefix as well as "(User);" suffix + * Remove {@code Windows} domain and/or group prefix as well as "(User);" suffix * * @param user The original username - ignored if {@code null}/empty * @return The canonical user - unchanged if {@code Unix} O/S --- apache-sshd-2.12.0/sshd-common/src/main/java/org/apache/sshd/common/util/security/SecurityUtils.java 2024-01-19 22:39:38.023904678 +0100 +++ apache-sshd-2.12.0/sshd-common/src/main/java/org/apache/sshd/common/util/security/SecurityUtils.java 2024-01-19 22:39:58.580159916 +0100 @@ -120,7 +120,7 @@ /** * The min. key size value used for testing whether Diffie-Hellman Group Exchange is supported or not. According to * RFC 4419 section 3: "Servers and clients SHOULD support - * groups with a modulus length of k bits, where 1024 <= k <= 8192". + * groups with a modulus length of k bits, where 1024 <= k <= 8192". * * Note: this has been amended by RFC 8270 */ --- apache-sshd-2.12.0/sshd-core/src/main/java/org/apache/sshd/client/session/ClientProxyConnector.java 2024-01-19 22:39:38.050570811 +0100 +++ apache-sshd-2.12.0/sshd-core/src/main/java/org/apache/sshd/client/session/ClientProxyConnector.java 2024-01-19 22:39:58.580159916 +0100 @@ -23,8 +23,8 @@ /** * Provides a way to implement proxied connections where some metadata about the client is sent before the actual - * SSH protocol is executed - e.g., the PROXY - * protocol. The implementor should use the {@code IoSession#write(Buffer)} method to send any packets with the + * SSH protocol is executed - e.g., the PROXY protocol. + * The implementor should use the {@code IoSession#write(Buffer)} method to send any packets with the * meta-data. * * @author Apache MINA SSHD Project --- apache-sshd-2.12.0/sshd-core/src/main/java/org/apache/sshd/common/BaseBuilder.java 2024-01-19 22:39:38.057237344 +0100 +++ apache-sshd-2.12.0/sshd-core/src/main/java/org/apache/sshd/common/BaseBuilder.java 2024-01-19 22:39:58.586826449 +0100 @@ -67,7 +67,7 @@ /** * The default {@link BuiltinCiphers} setup in order of preference as specified by - * ssh_config(5) + * ssh_config(5) */ public static final List DEFAULT_CIPHERS_PREFERENCE = Collections.unmodifiableList( Arrays.asList( @@ -83,7 +83,7 @@ /** * The default {@link BuiltinDHFactories} setup in order of preference as specified by - * ssh_config(5) + * ssh_config(5) */ public static final List DEFAULT_KEX_PREFERENCE = Collections.unmodifiableList( Arrays.asList( @@ -104,7 +104,7 @@ /** * The default {@link BuiltinMacs} setup in order of preference as specified by - * ssh_config(5) + * ssh_config(5) */ public static final List DEFAULT_MAC_PREFERENCE = Collections.unmodifiableList( Arrays.asList( --- apache-sshd-2.12.0/sshd-core/src/main/java/org/apache/sshd/common/session/Session.java 2024-01-19 22:39:38.057237344 +0100 +++ apache-sshd-2.12.0/sshd-core/src/main/java/org/apache/sshd/common/session/Session.java 2024-01-19 22:39:58.590159716 +0100 @@ -224,11 +224,11 @@ * {@link Buffer} to the given {@link ReplyHandler}, which may execute in a different thread. * *
- *
want-reply == true && replyHandler != null
+ *
want-reply == true && replyHandler != null
*
The returned future is fulfilled with {@code null} when the request was sent, or with an exception if the * request could not be sent. The {@code replyHandler} is invoked once the reply is received, with the SSH reply * code and the data received.
- *
want-reply == true && replyHandler == null
+ *
want-reply == true && replyHandler == null
*
The returned future is fulfilled with an exception if the request could not be sent, or a failure reply was * received. If a success reply was received, the future is fulfilled with the received data buffer.
*
want-reply == false
--- apache-sshd-2.12.0/sshd-core/src/main/java/org/apache/sshd/server/session/ServerProxyAcceptor.java 2024-01-19 22:39:38.060570610 +0100 +++ apache-sshd-2.12.0/sshd-core/src/main/java/org/apache/sshd/server/session/ServerProxyAcceptor.java 2024-01-19 22:39:58.593492983 +0100 @@ -23,8 +23,7 @@ /** * Provides a way to implement proxied connections where some metadata about the client is sent before the actual - * SSH protocol is executed - e.g., the PROXY - * protocol. + * SSH protocol is executed - e.g., the PROXY protocol. * * @author Apache MINA SSHD Project */