Accepting request 390308 from home:AndreasStieger:branches:devel:tools:building

cmake 3.5.2

OBS-URL: https://build.opensuse.org/request/show/390308
OBS-URL: https://build.opensuse.org/package/show/devel:tools:building/cmake?expand=0&rev=246

cmake-gui.spec

@@ -17,7 +17,7 @@
 
 
 Name:           cmake-gui
-Version:        3.5.1
+Version:        3.5.2
 Release:        0
 Summary:        CMake graphical user interface
 License:        BSD-3-Clause
@@ -39,19 +39,21 @@ BuildRequires:  gcc-c++
 BuildRequires:  libarchive-devel >= 3.0.2
 BuildRequires:  libexpat-devel
 BuildRequires:  openssl-devel
-BuildRequires:  python-sphinx
-BuildRequires:  update-desktop-files
-BuildRequires:  zlib-devel
 # this is commented as it would create dependancy cycle between jsoncpp and cmake
 #if 0%{?suse_version} > 1320
 #BuildRequires:  pkgconfig(jsoncpp)
 #endif
+BuildRequires:  pkg-config
+BuildRequires:  python-sphinx
+BuildRequires:  update-desktop-files
+BuildRequires:  zlib-devel
 BuildRequires:  pkgconfig(bzip2)
 BuildRequires:  pkgconfig(liblzma)
 Requires:       cmake
 Recommends:     cmake-man
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 %if 0%{?suse_version} >= 1320
+BuildRequires:  pkg-config
 BuildRequires:  pkgconfig(Qt5Widgets)
 %else
 BuildRequires:  libqt4-devel
@@ -81,6 +83,7 @@ echo "`grep cmake-%{version}.tar.gz %{SOURCE5} | grep -Eo '^[0-9a-f]+'`  %{SOURC
 EXTRA_FLAGS="--qt-gui"
 export CXXFLAGS="%{optflags}"
 export CFLAGS="$CXXFLAGS"
+# FIXME: you should use the %%configure macro
 ./configure \
     --prefix=%{_prefix} \
     --datadir=/share/cmake \
@@ -102,7 +105,7 @@ export CFLAGS="$CXXFLAGS"
 make VERBOSE=1 %{?_smp_mflags}
 
 %install
-make DESTDIR=%{buildroot} install %{?_smp_mflags}
+make %{?_smp_mflags} DESTDIR=%{buildroot} install
 mkdir -p %{buildroot}%{_libdir}/cmake
 %suse_update_desktop_file CMake Development IDE Tools Qt
 # delete files that belong to the 'cmake' package