9f2ff0f90b
- update to 4.4.2: * Please note that that ISC DHCP is now licensed under the Mozilla Public License, MPL 2.0. In general, the areas of focus for ISC DHCP 4.4 were: 1. Dynamic DNS additions 2. dhclient improvements 3. Support for dynamic shared libraries * Added the interface name to socket initialization failure log messages. Prior to this the log messages stated only the error reason without stating the target interface. * Corrected buffer pointer logic in dhcrelay functions that manipulate agent relay options. Thanks to Thomas Imbert of MSRC Vulnerabilities & Mitigations for reporting the issue. * Corrected unresolved symbol errors building relay_unittests when configured to build using libtool. * A new configuration parameter, ping-cltt-secs (v4 operation only), has been added to allow the user to specify the number of seconds that must elapse since CLTT before a ping check is conducted. Prior to this, the value was hard coded at 60 seconds. Please see the server man pages for a more detailed discussion. * A new configuration parameter, ping-timeout-ms (v4 operation only), has been added that allows the user to specify the amount of time the server waits for a ping-check response in milliseconds rather than in seconds (via ping-timeout). When greater than zero, the value of ping-timeout-ms will override the value of ping-timeout. Thanks to Jay Doran from Bluecat Networks for suggesting this feature. * An experimental tool called, Keama (KEA Migration Assistant), which helps translate ISC DHCP configurations to Kea configurations, is now included in the distribution. * Corrected a misuse of the BIND9 DDNS API which caused DDNS updates to be OBS-URL: https://build.opensuse.org/request/show/866365 OBS-URL: https://build.opensuse.org/package/show/network:dhcp/dhcp?expand=0&rev=224
48 lines
1.4 KiB
Diff
48 lines
1.4 KiB
Diff
From 937561ef8c09e3281caba3c859e80ce2fcf23ce4 Mon Sep 17 00:00:00 2001
|
|
From: Marius Tomaschewski <mt@suse.de>
|
|
Date: Mon, 14 Sep 2015 18:53:34 +0200
|
|
Subject: [PATCH] client: fail on script pre-init error (bsc#912098)
|
|
References: bsc#912098
|
|
|
|
Index: dhcp-4.4.2/client/dhclient.c
|
|
===================================================================
|
|
--- dhcp-4.4.2.orig/client/dhclient.c
|
|
+++ dhcp-4.4.2/client/dhclient.c
|
|
@@ -882,7 +882,8 @@ main(int argc, char **argv) {
|
|
* in case somebody cares.
|
|
*/
|
|
script_init(NULL, "NBI", NULL);
|
|
- script_go(NULL);
|
|
+ if (script_go(NULL))
|
|
+ log_fatal("dhclient-script was unable to pre-init");
|
|
|
|
/*
|
|
* If we haven't been asked to persist, waiting for new
|
|
@@ -894,6 +895,8 @@ main(int argc, char **argv) {
|
|
finish(0);
|
|
}
|
|
} else if (!release_mode && !exit_mode) {
|
|
+ unsigned int failed = 0;
|
|
+
|
|
/* Call the script with the list of interfaces. */
|
|
for (ip = interfaces; ip; ip = ip->next) {
|
|
/*
|
|
@@ -915,7 +918,16 @@ main(int argc, char **argv) {
|
|
"alias_",
|
|
ip->client->alias);
|
|
}
|
|
- script_go(ip->client);
|
|
+ if (script_go(ip->client)) {
|
|
+ log_info("%s: unable to pre-init requested interface %s",
|
|
+ path_dhclient_script, ip->name);
|
|
+ ip->flags &= ~(INTERFACE_REQUESTED|INTERFACE_AUTOMATIC);
|
|
+ failed++;
|
|
+ }
|
|
+ }
|
|
+ if (failed) {
|
|
+ log_fatal("%s: unable to pre-init requested interfaces -- see log messages",
|
|
+ path_dhclient_script);
|
|
}
|
|
}
|
|
|