Marius Tomaschewski
d059c507b7
and enabled Restart=on-abort (fate#315133).
- Update to ISC dhcp-4.2.6 release. See RELNOTES file for the
complete list of changes -- digest of fixes not in dhcp-4.2.5:
- Tidy up receive packet processing.
Thanks to Brad Plank of GTA for reporting the issue and
suggesting a possible patch. [ISC-Bugs #34447]
- Fix the socket handling for DHCPv6 clients to allow multiple
instances of a client on a single machine to work properly.
Previously only one client would receive the packets.
Thanks to Jiri Popelka at Red Hat for the bug report and a
potential patch. [ISC-Bugs #34784]
- Added support for gentle shutdown after signal is received.
[ISC-Bugs #32692] [ISC-Bugs 34945]
- Enhance the DHCPv6 server logging to include the addresses
that are assigned to the clients. This can be enabled by
defining LOG_V6_ADDRESSES in site.h. [ISC-Bugs #26377]
- Fix an operation in the DDNS code to be a bitwise instead
of logical or. [ISC-Bugs #35138]
- Merged patches for dhcp-4.2.6 version to apply without fuzzy,
prepended patch number prefixes to match spec file patch nr,
added patch markup tags / bug numbers to the spec file.
- Applied contrib-lease-path pach to contrib.tar.gz
[- contrib-lease-path.diff]
- Changed to require automake and use its config.sub and guess
files instead of maintaining a patch.
[- config-guess-sub-update.patch]
- Enabled to log DHCPv6 addresses assigned by server to clients
[+ 0016-server-log-DHCPv6-addresses-assigned-to-clients.patch]
- Cleaned up documentation, rpmlint adjustments.
OBS-URL: https://build.opensuse.org/package/show/network:dhcp/dhcp?expand=0&rev=121
109 lines
3.5 KiB
Diff
109 lines
3.5 KiB
Diff
From bd50ec560d7bec064190e4d430c066e170732c0e Mon Sep 17 00:00:00 2001
|
|
From: Marius Tomaschewski <mt@suse.de>
|
|
Date: Tue, 27 Nov 2012 17:44:06 +0100
|
|
Subject: [PATCH] Fixed linux interface discovery using getifaddrs
|
|
|
|
Unlike dhcp 3.x, dhcp 4.x scans interfaces from /proc/net/dev,
|
|
which provides only true interface names. When the address set
|
|
on the interface has a label assigned (linux 2.0 alias interface
|
|
compatibility), then the SIOCGIFADDR requires the label / alias
|
|
name as argument instead of the interface name to return this
|
|
address. When this is the only address assigned to an interface,
|
|
dhcp-server is unable to find any address and fails to start.
|
|
|
|
Changed to use getifaddrs() function, which retrieves all IP
|
|
addresses on linux systems and is available since GLIBC 2.3.
|
|
---
|
|
common/discover.c | 51 ++++++++++++++++++++++++++++++++++++++++++++-------
|
|
1 file changed, 44 insertions(+), 7 deletions(-)
|
|
|
|
diff --git a/common/discover.c b/common/discover.c
|
|
index 6a0540b..1dcaa02 100644
|
|
--- a/common/discover.c
|
|
+++ b/common/discover.c
|
|
@@ -370,7 +370,7 @@ end_iface_scan(struct iface_conf_list *ifaces) {
|
|
ifaces->sock = -1;
|
|
}
|
|
|
|
-#elif __linux /* !HAVE_SIOCGLIFCONF */
|
|
+#elif __linux && !(defined(__GNUC_PREREQ) && __GNUC_PREREQ(2,3)) /* !HAVE_SIOCGLIFCONF */
|
|
/*
|
|
* Linux support
|
|
* -------------
|
|
@@ -379,6 +379,14 @@ end_iface_scan(struct iface_conf_list *ifaces) {
|
|
* about interfaces, along with selected ioctl() calls.
|
|
*
|
|
* Linux low level access is documented in the netdevice man page.
|
|
+ *
|
|
+ * Note: Use getifaddrs instead
|
|
+ * Unfortunately this discover discards all interfaces where the
|
|
+ * only address has a label assigned (linux 2.0 alias interface
|
|
+ * compatibility) as the SIOCGIFADDR requires the the alias name
|
|
+ * (eth0:0) in ifr_name to fetch the address and /proc/net/dev
|
|
+ * on linux > 2.0 lists only the interface names (eth0) without
|
|
+ * any aliases.
|
|
*/
|
|
|
|
/*
|
|
@@ -751,11 +759,11 @@ end_iface_scan(struct iface_conf_list *ifaces) {
|
|
#else
|
|
|
|
/*
|
|
- * BSD support
|
|
- * -----------
|
|
+ * BSD & Linux support
|
|
+ * -------------------
|
|
*
|
|
* FreeBSD, NetBSD, OpenBSD, and OS X all have the getifaddrs()
|
|
- * function.
|
|
+ * function. Linux has it since glibc 2.3.
|
|
*
|
|
* The getifaddrs() man page describes the use.
|
|
*/
|
|
@@ -812,10 +820,39 @@ next_iface(struct iface_info *info, int *err, struct iface_conf_list *ifaces) {
|
|
*err = 1;
|
|
return 0;
|
|
}
|
|
- strcpy(info->name, ifaces->next->ifa_name);
|
|
- memcpy(&info->addr, ifaces->next->ifa_addr,
|
|
- ifaces->next->ifa_addr->sa_len);
|
|
+ info->addr.ss_family = AF_UNSPEC;
|
|
info->flags = ifaces->next->ifa_flags;
|
|
+#ifdef __linux
|
|
+ if (strchr(ifaces->next->ifa_name, ':')) {
|
|
+ /*
|
|
+ * the name contains a ':', which may
|
|
+ * be a IPv4 "alias interface" label;
|
|
+ * resolve to the true interface name
|
|
+ */
|
|
+ if_indextoname(if_nametoindex(ifaces->next->ifa_name),
|
|
+ info->name);
|
|
+ } else {
|
|
+ strcpy(info->name, ifaces->next->ifa_name);
|
|
+ }
|
|
+
|
|
+ if (ifaces->next->ifa_addr != NULL) {
|
|
+ if (ifaces->next->ifa_addr->sa_family == AF_INET) {
|
|
+ memcpy(&info->addr, ifaces->next->ifa_addr,
|
|
+ sizeof(struct sockaddr_in));
|
|
+ } else
|
|
+ if (ifaces->next->ifa_addr->sa_family == AF_INET6) {
|
|
+ memcpy(&info->addr, ifaces->next->ifa_addr,
|
|
+ sizeof(struct sockaddr_in6));
|
|
+ }
|
|
+ /* else e.g. AF_PACKET / link layer address */
|
|
+ }
|
|
+#else
|
|
+ strcpy(info->name, ifaces->next->ifa_name);
|
|
+ if (ifaces->next->ifa_addr != NULL) {
|
|
+ memcpy(&info->addr, ifaces->next->ifa_addr,
|
|
+ ifaces->next->ifa_addr->sa_len);
|
|
+ }
|
|
+#endif
|
|
ifaces->next = ifaces->next->ifa_next;
|
|
*err = 0;
|
|
return 1;
|
|
--
|
|
1.8.4
|
|
|