From 2186fff3675d4e774cecc8f918c05063e0367d28 Mon Sep 17 00:00:00 2001 From: Bernard Iremonger Date: Mon, 7 Mar 2016 11:40:40 +0000 Subject: [PATCH] bonding: fix crash when no slave device If a bonded device is created when there are no slave devices there is a loop in bond_ethdev_promiscuous_enable() which results in a segmentation fault. The solution is to initialise the current_primary_port to an invalid port value when the bonded port is created. Fixes: 2efb58cbab6e ("bond: new link bonding library") Signed-off-by: Bernard Iremonger Acked-by: Ferruh Yigit --- drivers/net/bonding/rte_eth_bond_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c index c6c0ed8..3fca764 100644 --- a/drivers/net/bonding/rte_eth_bond_api.c +++ b/drivers/net/bonding/rte_eth_bond_api.c @@ -231,7 +231,7 @@ rte_eth_bond_create(const char *name, uint8_t mode, uint8_t socket_id) internals->port_id = eth_dev->data->port_id; internals->mode = BONDING_MODE_INVALID; - internals->current_primary_port = 0; + internals->current_primary_port = RTE_MAX_ETHPORTS + 1; internals->balance_xmit_policy = BALANCE_XMIT_POLICY_LAYER2; internals->xmit_hash = xmit_l2_hash; internals->user_defined_mac = 0; -- 2.6.2