- Add "Suggests: %{python}-Pygments".

- Maintenance script qa.sh:
  * Note investigation of some ada test-cases.
  * Update PR30547 kfail.
  * Add PR28561 kfail.
  * Update PKRU-related kfail.
  * Use openSUSE_Factory_LegacyX86.i586 instead of
    openSUSE_Factory.i586.
  * Remove PR27813 kfail and corresponding todo.

OBS-URL: https://build.opensuse.org/package/show/devel:gcc/gdb?expand=0&rev=362

gdb.changes

@@ -1,3 +1,16 @@
+-------------------------------------------------------------------
+Wed Sep 27 09:22:47 UTC 2023 - Tom de Vries <tdevries@suse.com>
+
+- Add "Suggests: %{python}-Pygments".
+- Maintenance script qa.sh:
+  * Note investigation of some ada test-cases.
+  * Update PR30547 kfail.
+  * Add PR28561 kfail.
+  * Update PKRU-related kfail.
+  * Use openSUSE_Factory_LegacyX86.i586 instead of
+    openSUSE_Factory.i586.
+  * Remove PR27813 kfail and corresponding todo.
+
 -------------------------------------------------------------------
 Sun Aug 20 00:41:09 UTC 2023 - Luciano Santos <luc14n0@opensuse.org>
 

gdb.spec

@@ -583,6 +583,15 @@ Requires:       libunwind
 
 %if %{build_main}
 
+%if 0%{!?_without_python:1}
+# For SLE-15 and later, we use source-highlight by default, and
+# pygments as fallback.
+# For SLE-12, source-highlight is not used, and we'd rather not start using
+# pygments as default for an older release.
+# So, suggests rather than recommends is what we want in both cases.
+Suggests:       %{python}-Pygments
+%endif
+
 %description
 GDB, the GNU debugger, allows you to debug programs written in C, C++,
 Java, and other languages, by executing them in a controlled fashion

qa.sh

@@ -1,25 +1,5 @@
 #!/bin/bash
 
-# Note:
-# Occasionally we run into PR28561 - "[gdb/testsuite] Error due to not
-# reading \r\n at end of mi prompt".
-# https://sourceware.org/bugzilla/show_bug.cgi?id=28561
-# Not sure how to filter for that.
-
-# TODO:
-#
-# We run into FAILs like this:
-# FAIL: gdb.base/options.exp: test-print: \
-#   tab complete "thread apply all print " (clearing input line) (timeout)
-# FAIL: gdb.base/options.exp: test-print: \
-#   cmd complete "thread apply all print "
-# in various test-cases.  One instance is reported here (
-# https://sourceware.org/bugzilla/show_bug.cgi?id=27813 ).
-# We could do a generic kfail for "(clearing input line) (timeout)", but that
-# doesn't filter out the following FAIL.  We need to update the testsuite to
-# emit only one FAIL for this, or alternatively, add a possibility in this
-# script to KFAIL one and all following FAILs in the same test-case.
-
 usage ()
 {
     echo "usage: $0 <1-5>"
@@ -161,8 +141,6 @@ kfail=(
     "FAIL: gdb.threads/process-dies-while-detaching.exp: single-process: continue: .*: continue"
     # https://sourceware.org/bugzilla/show_bug.cgi?id=28065
     "FAIL: gdb.threads/access-mem-running-thread-exit.exp:"
-    # https://sourceware.org/bugzilla/show_bug.cgi?id=27813
-    "FAIL: gdb.cp/cpcompletion.exp:"
     # https://sourceware.org/bugzilla/show_bug.cgi?id=25503
     "FAIL: gdb.threads/signal-while-stepping-over-bp-other-thread.exp: step \(pattern 3\)"
     # https://sourceware.org/bugzilla/show_bug.cgi?id=26915
@@ -279,9 +257,15 @@ kfail=(
     "FAIL: gdb.base/info-os.exp: get shared-memory regions"
     "FAIL: gdb.base/info-os.exp: get threads"
 
-    #https://sourceware.org/bugzilla/show_bug.cgi?id=29790
+    # Fails related to PKRU register.  To be investigated.  Might be fixed in
+    # gdb 14, but related patches look non-trivial to backport.
+    "FAIL: gdb.arch/i386-pkru.exp: pkru register"
+    "FAIL: gdb.arch/i386-pkru.exp: read pkru register"
     "FAIL: gdb.arch/i386-pkru.exp: read value after setting value"
     "FAIL: gdb.arch/i386-pkru.exp: variable after reading pkru"
+    "FAIL: gdb.base/gcore.exp: corefile restored all registers"
+    "FAIL: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn"
+    "FAIL: gdb.reverse/insn-reverse.exp: rdseed: compare registers on insn"
 
     # https://sourceware.org/bugzilla/show_bug.cgi?id=28478
     "FAIL: gdb.gdb/selftest.exp: backtrace through signal handler"
@@ -289,10 +273,6 @@ kfail=(
     # https://sourceware.org/bugzilla/show_bug.cgi?id=29781
     "FAIL: gdb.mi/mi-multi-commands.exp: args=: look for second command output, command length .* \(timeout\)"
 
-    # https://sourceware.org/bugzilla/show_bug.cgi?id=27813
-    "FAIL: .*.exp: .*tab complete .* \(clearing input line\) \(timeout\)"
-    "FAIL: .*.exp: .*cmd complete .*"
-
     # https://sourceware.org/bugzilla/show_bug.cgi?id=27027
     # https://sourceware.org/bugzilla/show_bug.cgi?id=28464
     "FAIL: gdb.ada/mi_var_access.exp: Create varobj \(unexpected output\)"
@@ -506,8 +486,10 @@ kfail_factory=(
     # https://sourceware.org/bugzilla/show_bug.cgi?id=29965
     "FAIL: gdb.threads/process-exit-status-is-leader-exit-status.exp: iteration=.*: continue \(the program exited\)"
 
-    # To be investigated.
+    # https://sourceware.org/pipermail/gdb-patches/2023-September/202757.html
     "FAIL: gdb.ada/mi_task_arg.exp: -stack-list-arguments 1 \(unexpected output\)"
+
+    # https://sourceware.org/bugzilla/show_bug.cgi?id=30908
     "FAIL: gdb.ada/str_binop_equal.exp: print my_str = \"ABCD\""
     "FAIL: gdb.ada/widewide.exp: print my_wws = \" helo\""
     "FAIL: gdb.ada/widewide.exp: print my_ws = \"wide\""
@@ -553,6 +535,12 @@ kfail_aarch64=(
     "FAIL: gdb.base/watchpoint-unaligned.exp: continue \(timeout\)"
     "FAIL: gdb.base/watchpoint-unaligned.exp: size8twice write"
 
+    # https://sourceware.org/bugzilla/show_bug.cgi?id=28561
+    # "[gdb/testsuite] Error due to not reading \r\n at end of mi prompt"
+    # We match pretty aggressively here.
+    "FAIL: gdb.mi/.*.exp:"
+    "FAIL: gdb.python/.*-mi.exp:"
+    
 ) # kfail_aarch64
 
 kfail_powerpc64le=(
@@ -770,6 +758,7 @@ case $n in
 	    "UNRESOLVED: gdb.base/gcore-excessive-memory.exp: verify we can get to main"
 
 	    # https://sourceware.org/bugzilla/show_bug.cgi?id=30547
+	    "UNRESOLVED: gdb.base/vfork-follow-parent.exp: resolution_method=schedule-multiple: print unblock_parent = 1"
 	    "UNRESOLVED: gdb.base/vfork-follow-parent.exp: resolution_method=schedule-multiple: continue to break_parent"
 	)
 
@@ -936,7 +925,7 @@ case $n in
 
 	(
 	    # Known clean config: Factory i586
-	    config=openSUSE_Factory.i586/gdb-testresults
+	    config=openSUSE_Factory_LegacyX86.i586/gdb-testresults
 	    sums=("$config/gdb-i586-suse-linux-m32.-fno-PIE.-no-pie.sum"
 		   "$config/gdb-i586-suse-linux-m32.sum")