SHA256
1
0
forked from pool/gdb

- Patches added (swo#29277):

* gdb-fix-assert-in-handle_jit_event.patch
- Maintenance script qa.sh:
  * Add PR29706 and PR28617 kfails.

OBS-URL: https://build.opensuse.org/package/show/devel:gcc/gdb?expand=0&rev=337
This commit is contained in:
Tom de Vries 2022-10-20 10:13:34 +00:00 committed by Git OBS Bridge
parent c834959acd
commit d7562cf604
4 changed files with 69 additions and 0 deletions

View File

@ -0,0 +1,46 @@
[gdb] Fix assert in handle_jit_event
With the cc-with-tweaks.sh patch submitted here (
https://sourceware.org/pipermail/gdb-patches/2022-October/192586.html ) we run
with:
...
$ export STRIP_ARGS_STRIP_DEBUG=--strip-all
$ make check RUNTESTFLAGS="gdb.base/jit-reader.exp \
--target_board cc-with-gnu-debuglink"
...
into the following assert:
...
(gdb) run ^M
Starting program: jit-reader ^M
gdb/jit.c:1247: internal-error: jit_event_handler: \
Assertion `jiter->jiter_data != nullptr' failed.^M
...
Fix this by handling the
jit_bp_sym.objfile->separate_debug_objfile_backlink != nullptr case in
handle_jit_event.
Tested on x86_64-linux.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29277
---
gdb/breakpoint.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index b046adf08f9..34f35135dfe 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -5566,7 +5566,10 @@ handle_jit_event (CORE_ADDR address)
function needs to be updated too. */
bound_minimal_symbol jit_bp_sym = lookup_minimal_symbol_by_pc (address);
gdb_assert (jit_bp_sym.objfile != nullptr);
- jit_event_handler (gdbarch, jit_bp_sym.objfile);
+ objfile *objfile = jit_bp_sym.objfile;
+ if (objfile->separate_debug_objfile_backlink)
+ objfile = objfile->separate_debug_objfile_backlink;
+ jit_event_handler (gdbarch, objfile);
target_terminal::inferior ();
}

View File

@ -1,3 +1,11 @@
-------------------------------------------------------------------
Wed Oct 19 16:35:34 UTC 2022 - Tom de Vries <tdevries@suse.com>
- Patches added (swo#29277):
* gdb-fix-assert-in-handle_jit_event.patch
- Maintenance script qa.sh:
* Add PR29706 and PR28617 kfails.
-------------------------------------------------------------------
Thu Sep 29 08:25:06 UTC 2022 - Fabian Vogt <fvogt@suse.com>

View File

@ -347,6 +347,7 @@ Patch2032: gdb-handle-pending-c-after-rl_callback_read_char.patch
Patch2033: gdb-testsuite-fix-have_mpx-test.patch
Patch2034: gdb-testsuite-fix-gdb.dwarf2-dw2-unspecified-type-foo.c-with-m32.patch
Patch2035: gdb-add-support-for-readline-8.2.patch
Patch2036: gdb-fix-assert-in-handle_jit_event.patch
# Backports from master, not yet available in next release.
@ -783,6 +784,7 @@ find -name "*.info*"|xargs rm -f
%patch2033 -p1
%patch2034 -p1
%patch2035 -p1
%patch2036 -p1
%patch2100 -p1
%patch2101 -p1

13
qa.sh
View File

@ -245,6 +245,16 @@ kfail=(
# https://sourceware.org/bugzilla/show_bug.cgi?id=26873
"FAIL: gdb.threads/watchthreads-threaded.exp: threaded watch loop \(GDB internal error\)"
# https://sourceware.org/bugzilla/show_bug.cgi?id=28617
"FAIL: gdb.base/info-os.exp: get file descriptors"
"FAIL: gdb.base/info-os.exp: get internet-domain sockets"
"FAIL: gdb.base/info-os.exp: get message queues"
"FAIL: gdb.base/info-os.exp: get process groups"
"FAIL: gdb.base/info-os.exp: get semaphores"
"FAIL: gdb.base/info-os.exp: get shared-memory regions"
"FAIL: gdb.base/info-os.exp: get threads"
) # kfail
kfail_sle12=(
@ -353,6 +363,9 @@ kfail_factory=(
"FAIL: gdb.server/stop-reply-no-thread.exp: to_disable=threads: continue to main \(timeout\)"
"FAIL: gdb.server/stop-reply-no-thread.exp: to_disable=threads: continue until exit \(timeout\)"
# https://sourceware.org/bugzilla/show_bug.cgi?id=29706
"FAIL: gdb.base/eof-exit.exp: with non-dump terminal: with bracketed-paste-mode on: close GDB with eof \(missed the prompt\)"
) # kfail_factory
kfail_aarch64=(