From 9768d9e2783de7e836421d9645070bb1917800dd Mon Sep 17 00:00:00 2001 From: Ray Strode Date: Fri, 27 Nov 2009 18:27:53 -0500 Subject: [PATCH 1/2] Save root window to pixmap at _XROOTPMAP_ID This combined with starting the X server with -nr will give us a nice fade transition when g-s-d starts --- daemon/gdm-simple-slave.c | 9 +++++ daemon/gdm-slave.c | 72 +++++++++++++++++++++++++++++++++++++++++++++ daemon/gdm-slave.h | 1 + 3 files changed, 82 insertions(+), 0 deletions(-) Index: gdm-2.91.94/daemon/gdm-simple-slave.c =================================================================== --- gdm-2.91.94.orig/daemon/gdm-simple-slave.c +++ gdm-2.91.94/daemon/gdm-simple-slave.c @@ -88,6 +88,7 @@ struct GdmSimpleSlavePrivate guint start_session_when_ready : 1; guint waiting_to_start_session : 1; + guint plymouth_is_running : 1; #ifdef HAVE_LOGINDEVPERM gboolean use_logindevperm; #endif @@ -95,6 +96,7 @@ struct GdmSimpleSlavePrivate enum { PROP_0, + FORCE_ACTIVE_VT }; static void gdm_simple_slave_class_init (GdmSimpleSlaveClass *klass); @@ -1098,6 +1100,72 @@ on_start_session_later (GdmGreeterServer slave->priv->start_session_when_ready = FALSE; } +static gboolean +plymouth_is_running (void) +{ + int status; + gboolean res; + GError *error; + + error = NULL; + res = g_spawn_command_line_sync ("/bin/plymouth --ping", + NULL, NULL, &status, &error); + if (! res) { + g_debug ("Could not ping plymouth: %s", error->message); + g_error_free (error); + return FALSE; + } + + return WIFEXITED (status) && WEXITSTATUS (status) == 0; +} + +static void +plymouth_prepare_for_transition (GdmSimpleSlave *slave) +{ + gboolean res; + GError *error; + + error = NULL; + res = g_spawn_command_line_sync ("/bin/plymouth deactivate", + NULL, NULL, NULL, &error); + if (! res) { + g_warning ("Could not deactivate plymouth: %s", error->message); + g_error_free (error); + } +} + +static void +plymouth_quit_with_transition (GdmSimpleSlave *slave) +{ + gboolean res; + GError *error; + + error = NULL; + res = g_spawn_command_line_sync ("/bin/plymouth quit --retain-splash", + NULL, NULL, NULL, &error); + if (! res) { + g_warning ("Could not quit plymouth: %s", error->message); + g_error_free (error); + } + slave->priv->plymouth_is_running = FALSE; +} + +static void +plymouth_quit_without_transition (GdmSimpleSlave *slave) +{ + gboolean res; + GError *error; + + error = NULL; + res = g_spawn_command_line_sync ("/bin/plymouth quit", + NULL, NULL, NULL, &error); + if (! res) { + g_warning ("Could not quit plymouth: %s", error->message); + g_error_free (error); + } + slave->priv->plymouth_is_running = FALSE; +} + static void setup_server (GdmSimpleSlave *slave) { @@ -1106,6 +1174,20 @@ setup_server (GdmSimpleSlave *slave) /* Set the busy cursor */ gdm_slave_set_busy_cursor (GDM_SLAVE (slave)); + + + /* The root window has a background that may be useful + * to cross fade or transition from when setting the + * login screen background. We read it here, and stuff + * it into the standard _XROOTPMAP_ID root window property, + * so gnome-settings-daemon can get at it. + */ + gdm_slave_save_root_windows (GDM_SLAVE (slave)); + + /* Plymouth is waiting for the go-ahead to exit */ + if (slave->priv->plymouth_is_running) { + plymouth_quit_with_transition (slave); + } } static void @@ -1305,6 +1387,10 @@ on_server_exited (GdmServer *server g_debug ("GdmSimpleSlave: server exited with code %d\n", exit_code); gdm_slave_stopped (GDM_SLAVE (slave)); + + if (slave->priv->plymouth_is_running) { + plymouth_quit_without_transition (slave); + } } static void @@ -1317,6 +1403,10 @@ on_server_died (GdmServer *server, g_strsignal (signal_number)); gdm_slave_stopped (GDM_SLAVE (slave)); + + if (slave->priv->plymouth_is_running) { + plymouth_quit_without_transition (slave); + } } static gboolean @@ -1325,11 +1415,13 @@ gdm_simple_slave_run (GdmSimpleSlave *sl char *display_name; char *auth_file; gboolean display_is_local; + gboolean force_active_vt; g_object_get (slave, "display-is-local", &display_is_local, "display-name", &display_name, "display-x11-authority-file", &auth_file, + "force-active-vt", &force_active_vt, NULL); /* if this is local display start a server if one doesn't @@ -1361,7 +1453,17 @@ gdm_simple_slave_run (GdmSimpleSlave *sl G_CALLBACK (on_server_ready), slave); - res = gdm_server_start (slave->priv->server); + slave->priv->plymouth_is_running = plymouth_is_running (); + + if (slave->priv->plymouth_is_running) { + plymouth_prepare_for_transition (slave); + res = gdm_server_start_on_active_vt (slave->priv->server); + } else { + if (force_active_vt) + res = gdm_server_start_on_active_vt (slave->priv->server); + else + res = gdm_server_start (slave->priv->server); + } if (! res) { g_warning (_("Could not start the X " "server (your graphical environment) " @@ -1371,6 +1473,9 @@ gdm_simple_slave_run (GdmSimpleSlave *sl "In the meantime this display will be " "disabled. Please restart GDM when " "the problem is corrected.")); + if (slave->priv->plymouth_is_running) { + plymouth_quit_without_transition (slave); + } exit (1); } @@ -1527,12 +1632,14 @@ gdm_simple_slave_finalize (GObject *obje } GdmSlave * -gdm_simple_slave_new (const char *id) +gdm_simple_slave_new (const char *id, + gboolean force_active_vt) { GObject *object; object = g_object_new (GDM_TYPE_SIMPLE_SLAVE, "display-id", id, + "force-active-vt", force_active_vt, NULL); return GDM_SLAVE (object); Index: gdm-2.91.94/daemon/gdm-slave.c =================================================================== --- gdm-2.91.94.orig/daemon/gdm-slave.c +++ gdm-2.91.94/daemon/gdm-slave.c @@ -43,6 +43,7 @@ #include #include /* for Display */ +#include /* for XA_PIXMAP */ #include /* for watch cursor */ #include #include @@ -87,6 +88,7 @@ struct GdmSlavePrivate char *display_hostname; gboolean display_is_local; gboolean display_is_parented; + gboolean force_active_vt; char *display_seat_id; char *display_x11_authority_file; char *parent_display_name; @@ -106,6 +108,7 @@ enum { PROP_DISPLAY_NUMBER, PROP_DISPLAY_HOSTNAME, PROP_DISPLAY_IS_LOCAL, + PROP_FORCE_ACTIVE_VT, PROP_DISPLAY_SEAT_ID, PROP_DISPLAY_X11_AUTHORITY_FILE }; @@ -434,6 +437,77 @@ gdm_slave_set_initial_cursor_position (G } } +static void +gdm_slave_save_root_window_of_screen (GdmSlave *slave, + Atom id_atom, + int screen_number) +{ + Window root_window; + GC gc; + XGCValues values; + Pixmap pixmap; + int width, height, depth; + + root_window = RootWindow (slave->priv->server_display, + screen_number); + + width = DisplayWidth (slave->priv->server_display, screen_number); + height = DisplayHeight (slave->priv->server_display, screen_number); + depth = DefaultDepth (slave->priv->server_display, screen_number); + pixmap = XCreatePixmap (slave->priv->server_display, + root_window, + width, height, depth); + + values.function = GXcopy; + values.plane_mask = AllPlanes; + values.fill_style = FillSolid; + values.subwindow_mode = IncludeInferiors; + + gc = XCreateGC (slave->priv->server_display, + root_window, + GCFunction | GCPlaneMask | GCFillStyle | GCSubwindowMode, + &values); + + if (XCopyArea (slave->priv->server_display, + root_window, pixmap, gc, 0, 0, + width, height, 0, 0)) { + + long pixmap_as_long; + + pixmap_as_long = (long) pixmap; + + XChangeProperty (slave->priv->server_display, + root_window, id_atom, XA_PIXMAP, + 32, PropModeReplace, (guchar *) &pixmap_as_long, + 1); + + } + + XFreeGC (slave->priv->server_display, gc); +} + +void +gdm_slave_save_root_windows (GdmSlave *slave) +{ + int i, number_of_screens; + Atom atom; + + number_of_screens = ScreenCount (slave->priv->server_display); + + atom = XInternAtom (slave->priv->server_display, + "_XROOTPMAP_ID", False); + + if (atom == 0) { + return; + } + + for (i = 0; i < number_of_screens; i++) { + gdm_slave_save_root_window_of_screen (slave, atom, i); + } + + XSync (slave->priv->server_display, False); +} + void gdm_slave_set_busy_cursor (GdmSlave *slave) { @@ -1531,6 +1605,13 @@ _gdm_slave_set_display_is_local (GdmSlav } static void +_gdm_slave_set_force_active_vt (GdmSlave *slave, + gboolean force_active_vt) +{ + slave->priv->force_active_vt = force_active_vt; +} + +static void gdm_slave_set_property (GObject *object, guint prop_id, const GValue *value, @@ -1562,6 +1643,9 @@ gdm_slave_set_property (GObject *ob case PROP_DISPLAY_IS_LOCAL: _gdm_slave_set_display_is_local (self, g_value_get_boolean (value)); break; + case PROP_FORCE_ACTIVE_VT: + _gdm_slave_set_force_active_vt (self, g_value_get_boolean (value)); + break; default: G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); break; @@ -1600,6 +1684,9 @@ gdm_slave_get_property (GObject *obje case PROP_DISPLAY_IS_LOCAL: g_value_set_boolean (value, self->priv->display_is_local); break; + case PROP_FORCE_ACTIVE_VT: + g_value_set_boolean (value, self->priv->force_active_vt); + break; default: G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); break; @@ -1725,6 +1812,14 @@ gdm_slave_class_init (GdmSlaveClass *kla TRUE, G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY)); + g_object_class_install_property (object_class, + PROP_FORCE_ACTIVE_VT, + g_param_spec_boolean ("force-active-vt", + "Force Active VT", + "Force display to active VT", + TRUE, + G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY)); + signals [STOPPED] = g_signal_new ("stopped", G_TYPE_FROM_CLASS (object_class), Index: gdm-2.91.94/daemon/gdm-slave.h =================================================================== --- gdm-2.91.94.orig/daemon/gdm-slave.h +++ gdm-2.91.94/daemon/gdm-slave.h @@ -77,6 +77,7 @@ gboolean gdm_slave_connect_to void gdm_slave_set_initial_cursor_position (GdmSlave *slave); void gdm_slave_set_busy_cursor (GdmSlave *slave); +void gdm_slave_save_root_windows (GdmSlave *slave); gboolean gdm_slave_run_script (GdmSlave *slave, const char *dir, const char *username); Index: gdm-2.91.94/daemon/gdm-server.c =================================================================== --- gdm-2.91.94.orig/daemon/gdm-server.c +++ gdm-2.91.94/daemon/gdm-server.c @@ -32,8 +32,11 @@ #include #include #include +#include #include +#include + #ifdef HAVE_SYS_PRCTL_H #include #endif @@ -673,6 +676,44 @@ gdm_server_spawn (GdmServer *server, return ret; } +static int +get_active_vt (void) +{ + int console_fd; + struct vt_stat console_state = { 0 }; + + console_fd = open ("/dev/tty0", O_RDONLY | O_NOCTTY); + + if (console_fd < 0) { + goto out; + } + + if (ioctl (console_fd, VT_GETSTATE, &console_state) < 0) { + goto out; + } + +out: + if (console_fd >= 0) { + close (console_fd); + } + + return console_state.v_active; +} + +static char * +get_active_vt_as_string (void) +{ + int vt; + + vt = get_active_vt (); + + if (vt <= 0) { + return NULL; + } + + return g_strdup_printf ("vt%d", vt); +} + /** * gdm_server_start: * @disp: Pointer to a GdmDisplay structure @@ -690,6 +731,21 @@ gdm_server_start (GdmServer *server) return res; } + +gboolean +gdm_server_start_on_active_vt (GdmServer *server) +{ + gboolean res; + char *vt; + + g_free (server->priv->command); + server->priv->command = g_strdup (X_SERVER " -background none -verbose"); + vt = get_active_vt_as_string (); + res = gdm_server_spawn (server, vt); + g_free (vt); + + return res; +} static void server_died (GdmServer *server) Index: gdm-2.91.94/daemon/gdm-server.h =================================================================== --- gdm-2.91.94.orig/daemon/gdm-server.h +++ gdm-2.91.94/daemon/gdm-server.h @@ -56,6 +56,7 @@ GType gdm_server_get_type GdmServer * gdm_server_new (const char *display_id, const char *auth_file); gboolean gdm_server_start (GdmServer *server); +gboolean gdm_server_start_on_active_vt (GdmServer *server); gboolean gdm_server_stop (GdmServer *server); char * gdm_server_get_display_device (GdmServer *server); Index: gdm-2.91.94/configure.ac =================================================================== --- gdm-2.91.94.orig/configure.ac +++ gdm-2.91.94/configure.ac @@ -1271,6 +1271,23 @@ AC_SUBST(GDM_SCREENSHOT_DIR) AC_SUBST(GDM_SIMPLE_GREETER_EXTENSIONS_DATA_DIR) dnl --------------------------------------------------------------------------- +dnl - Directory to spool events from other processes +dnl --------------------------------------------------------------------------- + +AC_ARG_WITH(spool-dir, + AS_HELP_STRING([--with-spool-dir=], + [spool directory])) + +if ! test -z "$with_spool_dir"; then + GDM_SPOOL_DIR=$with_spool_dir +else + GDM_SPOOL_DIR=${localstatedir}/spool/gdm +fi + +AC_SUBST(GDM_SPOOL_DIR) + + +dnl --------------------------------------------------------------------------- dnl - Finish dnl --------------------------------------------------------------------------- Index: gdm-2.91.94/daemon/gdm-display.c =================================================================== --- gdm-2.91.94.orig/daemon/gdm-display.c +++ gdm-2.91.94/daemon/gdm-display.c @@ -65,7 +65,9 @@ struct GdmDisplayPrivate gsize x11_cookie_size; GdmDisplayAccessFile *access_file; - gboolean is_local; + guint is_local : 1; + guint force_active_vt : 1; + guint finish_idle_id; GdmSlaveProxy *slave_proxy; @@ -84,6 +86,7 @@ enum { PROP_X11_COOKIE, PROP_X11_AUTHORITY_FILE, PROP_IS_LOCAL, + PROP_FORCE_ACTIVE_VT, PROP_SLAVE_COMMAND, }; @@ -574,9 +577,10 @@ gdm_display_real_prepare (GdmDisplay *di gdm_slave_proxy_set_log_path (display->priv->slave_proxy, log_path); g_free (log_path); - command = g_strdup_printf ("%s --display-id %s", + command = g_strdup_printf ("%s --display-id %s %s", display->priv->slave_command, - display->priv->id); + display->priv->id, + display->priv->force_active_vt? "--force-active-vt" : ""); gdm_slave_proxy_set_command (display->priv->slave_proxy, command); g_free (command); @@ -824,6 +828,13 @@ _gdm_display_set_is_local (GdmDisplay } static void +_gdm_display_set_force_active_vt (GdmDisplay *display, + gboolean force_active_vt) +{ + display->priv->force_active_vt = force_active_vt; +} + +static void _gdm_display_set_slave_command (GdmDisplay *display, const char *command) { @@ -866,6 +877,9 @@ gdm_display_set_property (GObject case PROP_IS_LOCAL: _gdm_display_set_is_local (self, g_value_get_boolean (value)); break; + case PROP_FORCE_ACTIVE_VT: + _gdm_display_set_force_active_vt (self, g_value_get_boolean (value)); + break; case PROP_SLAVE_COMMAND: _gdm_display_set_slave_command (self, g_value_get_string (value)); break; @@ -914,6 +928,9 @@ gdm_display_get_property (GObject case PROP_IS_LOCAL: g_value_set_boolean (value, self->priv->is_local); break; + case PROP_FORCE_ACTIVE_VT: + g_value_set_boolean (value, self->priv->force_active_vt); + break; case PROP_SLAVE_COMMAND: g_value_set_string (value, self->priv->slave_command); break; @@ -1084,6 +1101,13 @@ gdm_display_class_init (GdmDisplayClass NULL, TRUE, G_PARAM_READWRITE | G_PARAM_CONSTRUCT)); + g_object_class_install_property (object_class, + PROP_FORCE_ACTIVE_VT, + g_param_spec_boolean ("force-active-vt", + NULL, + NULL, + FALSE, + G_PARAM_READWRITE | G_PARAM_CONSTRUCT)); g_object_class_install_property (object_class, PROP_SLAVE_COMMAND, Index: gdm-2.91.94/daemon/gdm-simple-slave.h =================================================================== --- gdm-2.91.94.orig/daemon/gdm-simple-slave.h +++ gdm-2.91.94/daemon/gdm-simple-slave.h @@ -48,7 +48,8 @@ typedef struct } GdmSimpleSlaveClass; GType gdm_simple_slave_get_type (void); -GdmSlave * gdm_simple_slave_new (const char *id); +GdmSlave * gdm_simple_slave_new (const char *id, + gboolean force_active_vt); G_END_DECLS Index: gdm-2.91.94/daemon/gdm-static-display.c =================================================================== --- gdm-2.91.94.orig/daemon/gdm-static-display.c +++ gdm-2.91.94/daemon/gdm-static-display.c @@ -86,10 +86,27 @@ gdm_static_display_remove_user_authoriza } static gboolean +triggered_to_force_display_on_active_vt (void) +{ + gboolean should_force_display_on_active_vt; + + should_force_display_on_active_vt = g_file_test (GDM_SPOOL_DIR "/force-display-on-active-vt", + G_FILE_TEST_EXISTS); + g_unlink (GDM_SPOOL_DIR "/force-display-on-active-vt"); + + return should_force_display_on_active_vt; +} + +static gboolean gdm_static_display_manage (GdmDisplay *display) { g_return_val_if_fail (GDM_IS_DISPLAY (display), FALSE); + if (triggered_to_force_display_on_active_vt ()) { + g_object_set (display, "force-active-vt", TRUE, NULL); + } else { + g_object_set (display, "force-active-vt", FALSE, NULL); + } GDM_DISPLAY_CLASS (gdm_static_display_parent_class)->manage (display); return TRUE; Index: gdm-2.91.94/daemon/Makefile.am =================================================================== --- gdm-2.91.94.orig/daemon/Makefile.am +++ gdm-2.91.94/daemon/Makefile.am @@ -15,6 +15,7 @@ AM_CPPFLAGS = \ -DLOGDIR=\"$(logdir)\" \ -DSBINDIR=\"$(sbindir)\" \ -DGNOMELOCALEDIR=\""$(datadir)/locale"\" \ + -DGDM_SPOOL_DIR=\"$(GDM_SPOOL_DIR)\" \ -DGDM_XAUTH_DIR=\"$(GDM_XAUTH_DIR)\" \ -DGDM_SCREENSHOT_DIR=\"$(GDM_SCREENSHOT_DIR)\" \ -DGDM_CACHE_DIR=\""$(localstatedir)/cache/gdm"\" \ Index: gdm-2.91.94/daemon/simple-slave-main.c =================================================================== --- gdm-2.91.94.orig/daemon/simple-slave-main.c +++ gdm-2.91.94/daemon/simple-slave-main.c @@ -177,9 +177,11 @@ main (int argc, DBusGConnection *connection; GdmSlave *slave; static char *display_id = NULL; + static gboolean force_active_vt = FALSE; GdmSignalHandler *signal_handler; static GOptionEntry entries [] = { { "display-id", 0, 0, G_OPTION_ARG_STRING, &display_id, N_("Display ID"), N_("ID") }, + { "force-active-vt", 0, 0, G_OPTION_ARG_NONE, &force_active_vt, N_("Force X to start on active vt"), NULL }, { NULL } }; @@ -248,7 +250,7 @@ main (int argc, gdm_signal_handler_add (signal_handler, SIGUSR1, signal_cb, NULL); gdm_signal_handler_add (signal_handler, SIGUSR2, signal_cb, NULL); - slave = gdm_simple_slave_new (display_id); + slave = gdm_simple_slave_new (display_id, force_active_vt); if (slave == NULL) { goto out; } Index: gdm-2.91.94/data/Makefile.am =================================================================== --- gdm-2.91.94.orig/data/Makefile.am +++ gdm-2.91.94/data/Makefile.am @@ -12,6 +12,7 @@ predir = $(gdmconfdir)/PreSession postlogindir = $(gdmconfdir)/PostLogin workingdir = $(GDM_WORKING_DIR) xauthdir = $(GDM_XAUTH_DIR) +spooldir = $(GDM_SPOOL_DIR) screenshotdir = $(GDM_SCREENSHOT_DIR) cachedir = $(localstatedir)/cache/gdm @@ -144,6 +145,7 @@ uninstall-hook: $(DESTDIR)$(workingdir)/.config/dconf \ $(DESTDIR)$(screenshotdir) \ $(DESTDIR)$(xauthdir) + $(DESTDIR)$(spooldir) -rmdir \ $(DESTDIR)$(sysconfdir)/dconf/db \ @@ -265,6 +267,12 @@ install-data-hook: gdm.conf-custom Xsess chown root:gdm $(DESTDIR)$(cachedir) || : ; \ fi + if test '!' -d $(DESTDIR)$(spooldir); then \ + $(mkinstalldirs) $(DESTDIR)$(spooldir); \ + chmod 775 $(DESTDIR)$(spooldir); \ + chown root:gdm $(DESTDIR)$(spooldir) || : ; \ + fi + $(INSTALL_DATA) $(srcdir)/gconf.path $(DESTDIR)$(workingdir)/.gconf.path gconftool-2 --direct --config-source=xml:merged:$(DESTDIR)$(workingdir)/.gconf.mandatory --recursive-unset / gconftool-2 --direct --config-source=xml:merged:$(DESTDIR)$(workingdir)/.gconf.mandatory --load $(srcdir)/session-setup.entries